From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mx.groups.io with SMTP id smtpd.web11.7241.1572554097927080528 for ; Thu, 31 Oct 2019 13:34:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: canonical.com, ip: 91.189.89.112, mailfrom: dann.frazier@canonical.com) Received: from mail-io1-f71.google.com ([209.85.166.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iQH9k-0005Pa-4d for devel@edk2.groups.io; Thu, 31 Oct 2019 20:34:56 +0000 Received: by mail-io1-f71.google.com with SMTP id o2so5500364ioa.23 for ; Thu, 31 Oct 2019 13:34:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d8ZBU6sO12jHvoCmhliG2iz95Ax/rYSxn1BhvDQDYK4=; b=RcW8z28WUbab/TLbCvrWe6Ga6aZfqOz2wa7pccApbHz90akpVx6ALw6ebuaRV8G0V+ tgKHxNWSIxhFT92AaWsTxjOfoQLrqAD+ECfVOI1n0TOrIh5vv9CQNzehcxruklYUW7Kp 156ne57TFfynZ1YLy1v/XhQasHn8LZdWH/CHG2tI3P8iTjRsTIZ5LRWxLMFeIu2qG9S3 /SAXJ9SortVW6FWTOKuTULWQNL9PxHKPwtXZB7QkVXTl9UVLmXK80w9Aq7Uxcxk3OVb7 reUB0dkwPclvKcGByi+sJ4HUMEgE6q57b+7cltnoglrV/9Q+VmbwG0ALo+wJx03noTR1 jQZA== X-Gm-Message-State: APjAAAW/4JkW4S71ekEsR4u7SavSsVcJ3pZI/aN0cM98FG5DD4ewV5OM bKUg39Tgg7eSs6QQ/qZz6jcMebBKMLYO9OA+CqQPAFXOh2nDDQA1WSV7bDnfs0W+f0fkbYuBHmt 8wWEufaQlbMckI8++otaU+mliezqlunk= X-Received: by 2002:a92:9c16:: with SMTP id h22mr8245684ili.67.1572554094518; Thu, 31 Oct 2019 13:34:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/QkCp8ZRkE9ItFcQiXALg8DfFHZlTDSGYug0gGBvSbjppT6fZaRiAM4TLxxM82adT1uHDNw== X-Received: by 2002:a92:9c16:: with SMTP id h22mr8245650ili.67.1572554093978; Thu, 31 Oct 2019 13:34:53 -0700 (PDT) Received: from xps13.canonical.com (c-71-56-235-36.hsd1.co.comcast.net. [71.56.235.36]) by smtp.gmail.com with ESMTPSA id p24sm438141ioj.35.2019.10.31.13.34.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2019 13:34:53 -0700 (PDT) Date: Thu, 31 Oct 2019 14:34:52 -0600 From: "dann frazier" To: Leif Lindholm Cc: Laszlo Ersek , devel@edk2.groups.io, prabhakar.pkin@gmail.com, Ard Biesheuvel , naresh.bhat@linaro.org Subject: Re: [edk2-devel] How /sys/firmware/fdt getting created Message-ID: <20191031203452.GA24512@xps13.dannf> References: <2b268378-d9be-adb5-f139-a0ca8dab4329@redhat.com> <20191031121642.GA16820@bivouac.eciton.net> <15D2D0302F8A1888.21389@groups.io> MIME-Version: 1.0 In-Reply-To: <15D2D0302F8A1888.21389@groups.io> User-Agent: Mutt/1.12.2 (2019-09-21) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote: > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm wrote: > > > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > > > +Leif, comment at bottom > > > > Thanks Laszlo. +Dann, -kexec. > > > > > On 10/30/19 09:16, Prabhakar Kushwaha wrote: > > > >> So if you want to add these properties, you should add them there. > > > >> > > > >> Can you explain why doing this is necessary? > > > > > > > > I am trying to test kexec -p (kdump feature) on CentOS-release > > > > 7.7.1908 and Ubuntu-18.04 distributions. > > > > > > > > "kexec -p" command show error on Ubuntu. While no error on CentOS > > > > > > > > CentOS: > > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initramfs-`uname > > > > -r`.img --reuse-cmdline > > > > $ ==> No error > > > > > > > > Ubuntu > > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initrd.img-`uname > > > > -r` --reuse-cmdline > > > > $ kexec: elfcorehdr doesn't fit cells-size. > > > > $ kexec: setup_2nd_dtb failed. > > > > $ kexec: load failed. > > > > $ Cannot load /boot/vmlinuz-5.4.0-rc4+ > > > > > > > > Note: Both CentOS and Ubuntu has Linux-5.4-rc4 tag. > > > > > > > > When i debugged further reason for Ubuntu error is due to > > > > address-cells and size-cells as "1" > > > > log from kexec tool :- > > > > load_crashdump_segments: elfcorehdr 0x7f7cbfc000-0x7f7cbff7ff > > > > read_1st_dtb: found name =dtb_sys /sys/firmware/fdt > > > > get_cells_size: #address-cells:1 #size-cells:1 > > > > > > > > On CentOS both values are "2". > > > > log from kexec tool :- > > > > load_crashdump_segments: elfcorehdr 0xbf98bf0000-0xbf98bf33ff > > > > read_1st_dtb: found nmae=dtb_sys /sys/firmware/fdt > > > > get_cells_size: #address-cells:2 #size-cells:2 > > > > > > > > Note: Kexec tool read values from /sys/firmware/fdt. > > > > > > > > I am trying to figure out why 2 distributions showing different values. > > > > > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=347210a5d5ce655b95315f320faa515afb723c11 > > > > > > Ubuntu probably ships a grub version that lacks this commit. > > > > Yes, it came after the 18.04 release. > > Dann: given that 18.04 is LTS, would it be reasonable to cherry-pick > > this grub patch? I would consider the behaviour without it to be a > > bug. > > Leif, > > Likely - I'll run some tests and get back to you... Can you help me understand the scenario in which the above patch is required? I tested an 18.04 VM w/ AAVMF (ACPI-mode), and kexec -p worked fine. I also verified that 18.04 does not carry the above patch. -dann > > > / > > Leif > > > > > (The commit was first released as part of upstream grub-2.04. I have no > > > idea what version of grub is shipped in the CentOS distro you mention > > > above -- it could be based upon upstream 2.04, or the upstream patch may > > > have been backported to CentOS.) > > > > > > Thanks > > > Laszlo > > > > > >