* [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9
2019-11-04 7:21 [PATCH 0/4] Update SMBIOS 3.3.0 Gao, Zhichao
@ 2019-11-04 7:21 ` Gao, Zhichao
2019-11-05 21:24 ` Chaganty, Rangasai V
2019-11-04 7:21 ` [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Gao, Zhichao @ 2019-11-04 7:21 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
System Slots (Type 9):
– SMBIOSCR00184: add PCI Express Gen 4 values
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index fdb7a47d33..ac90f14d14 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1523,6 +1523,30 @@ TABLE_ITEM SystemSlotTypeTable[] = {
{
0xB6,
L"PCI Express Gen 3 X16"
+ },
+ {
+ 0xB8,
+ L"PCI Express Gen 4"
+ },
+ {
+ 0xB9,
+ L"PCI Express Gen 4 X1"
+ },
+ {
+ 0xBA,
+ L"PCI Express Gen 4 X2"
+ },
+ {
+ 0xBB,
+ L"PCI Express Gen 4 X4"
+ },
+ {
+ 0xBC,
+ L"PCI Express Gen 4 X8"
+ },
+ {
+ 0xBD,
+ L"PCI Express Gen 4 X16"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9
2019-11-04 7:21 ` [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
@ 2019-11-05 21:24 ` Chaganty, Rangasai V
0 siblings, 0 replies; 9+ messages in thread
From: Chaganty, Rangasai V @ 2019-11-05 21:24 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Gao, Zhichao
Sent: Sunday, November 03, 2019 11:21 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
System Slots (Type 9):
– SMBIOSCR00184: add PCI Express Gen 4 values
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index fdb7a47d33..ac90f14d14 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1523,6 +1523,30 @@ TABLE_ITEM SystemSlotTypeTable[] = {
{
0xB6,
L"PCI Express Gen 3 X16"
+ },
+ {
+ 0xB8,
+ L"PCI Express Gen 4"
+ },
+ {
+ 0xB9,
+ L"PCI Express Gen 4 X1"
+ },
+ {
+ 0xBA,
+ L"PCI Express Gen 4 X2"
+ },
+ {
+ 0xBB,
+ L"PCI Express Gen 4 X4"
+ },
+ {
+ 0xBC,
+ L"PCI Express Gen 4 X8"
+ },
+ {
+ 0xBD,
+ L"PCI Express Gen 4 X16"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus
2019-11-04 7:21 [PATCH 0/4] Update SMBIOS 3.3.0 Gao, Zhichao
2019-11-04 7:21 ` [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
@ 2019-11-04 7:21 ` Gao, Zhichao
2019-11-05 21:28 ` Chaganty, Rangasai V
2019-11-04 7:21 ` [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
2019-11-04 7:21 ` [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory" Gao, Zhichao
3 siblings, 1 reply; 9+ messages in thread
From: Gao, Zhichao @ 2019-11-04 7:21 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Various:
– SMBIOSCR00183: add support for CXL Flexbus
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index ac90f14d14..e66530690f 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1432,6 +1432,10 @@ TABLE_ITEM SystemSlotTypeTable[] = {
0x23,
L"PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card"
},
+ {
+ 0x30,
+ L"CXL Flexbus 1.0"
+ },
{
0xA0,
L"PC-98/C20 "
@@ -2290,6 +2294,10 @@ TABLE_ITEM PMALocationTable[] = {
{
0xA3,
L" PC-98/Local bus add-on card"
+ },
+ {
+ 0xA4,
+ L" CXL Flexbus 1.0 add-on card"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus
2019-11-04 7:21 ` [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
@ 2019-11-05 21:28 ` Chaganty, Rangasai V
0 siblings, 0 replies; 9+ messages in thread
From: Chaganty, Rangasai V @ 2019-11-05 21:28 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Gao, Zhichao
Sent: Sunday, November 03, 2019 11:21 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Various:
– SMBIOSCR00183: add support for CXL Flexbus
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index ac90f14d14..e66530690f 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1432,6 +1432,10 @@ TABLE_ITEM SystemSlotTypeTable[] = {
0x23,
L"PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card"
},
+ {
+ 0x30,
+ L"CXL Flexbus 1.0"
+ },
{
0xA0,
L"PC-98/C20 "
@@ -2290,6 +2294,10 @@ TABLE_ITEM PMALocationTable[] = {
{
0xA3,
L" PC-98/Local bus add-on card"
+ },
+ {
+ 0xA4,
+ L" CXL Flexbus 1.0 add-on card"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
2019-11-04 7:21 [PATCH 0/4] Update SMBIOS 3.3.0 Gao, Zhichao
2019-11-04 7:21 ` [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
2019-11-04 7:21 ` [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
@ 2019-11-04 7:21 ` Gao, Zhichao
2019-11-05 21:32 ` Chaganty, Rangasai V
2019-11-04 7:21 ` [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory" Gao, Zhichao
3 siblings, 1 reply; 9+ messages in thread
From: Gao, Zhichao @ 2019-11-04 7:21 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00178: add new memory device type value (HBM) and new form
factor value (Die)
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../SmbiosView/QueryTable.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index e66530690f..5e8064b230 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2423,6 +2423,10 @@ TABLE_ITEM MemoryDeviceFormFactorTable[] = {
{
0x0F,
L" FB-DIMM"
+ },
+ {
+ 0x10,
+ L" Die"
}
};
@@ -2538,6 +2542,14 @@ TABLE_ITEM MemoryDeviceTypeTable[] = {
{
0x1F,
L" Logical non-volatile device"
+ },
+ {
+ 0x20,
+ L" HBM (High Bandwidth Memory)"
+ },
+ {
+ 0x21,
+ L" HBM2 (High Bandwidth Memory Generation 2)"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
2019-11-04 7:21 ` [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
@ 2019-11-05 21:32 ` Chaganty, Rangasai V
0 siblings, 0 replies; 9+ messages in thread
From: Chaganty, Rangasai V @ 2019-11-05 21:32 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Gao, Zhichao
Sent: Sunday, November 03, 2019 11:21 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00178: add new memory device type value (HBM) and new form factor value (Die)
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../SmbiosView/QueryTable.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index e66530690f..5e8064b230 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
+++ c
@@ -2423,6 +2423,10 @@ TABLE_ITEM MemoryDeviceFormFactorTable[] = {
{
0x0F,
L" FB-DIMM"
+ },
+ {
+ 0x10,
+ L" Die"
}
};
@@ -2538,6 +2542,14 @@ TABLE_ITEM MemoryDeviceTypeTable[] = {
{
0x1F,
L" Logical non-volatile device"
+ },
+ {
+ 0x20,
+ L" HBM (High Bandwidth Memory)"
+ },
+ {
+ 0x21,
+ L" HBM2 (High Bandwidth Memory Generation 2)"
}
};
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"
2019-11-04 7:21 [PATCH 0/4] Update SMBIOS 3.3.0 Gao, Zhichao
` (2 preceding siblings ...)
2019-11-04 7:21 ` [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
@ 2019-11-04 7:21 ` Gao, Zhichao
2019-11-05 21:38 ` Chaganty, Rangasai V
3 siblings, 1 reply; 9+ messages in thread
From: Gao, Zhichao @ 2019-11-04 7:21 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00179: update the string for Intel persistent memory
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 5e8064b230..da4bf92806 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2639,7 +2639,7 @@ TABLE_ITEM MemoryDeviceMemoryTechnologyTable[] = {
},
{
0x07,
- L" Intel persistent memory"
+ L" Intel Optane DC Persistent Memory"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"
2019-11-04 7:21 ` [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory" Gao, Zhichao
@ 2019-11-05 21:38 ` Chaganty, Rangasai V
0 siblings, 0 replies; 9+ messages in thread
From: Chaganty, Rangasai V @ 2019-11-05 21:38 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Gao, Zhichao
Sent: Sunday, November 03, 2019 11:21 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00179: update the string for Intel persistent memory
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 5e8064b230..da4bf92806 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2639,7 +2639,7 @@ TABLE_ITEM MemoryDeviceMemoryTechnologyTable[] = {
},
{
0x07,
- L" Intel persistent memory"
+ L" Intel Optane DC Persistent Memory"
}
};
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread