public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Desimone, Ashley E" <ashley.e.desimone@intel.com>
To: devel@edk2.groups.io
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Puja Pandya <puja.pandya@intel.com>
Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH 8/8] EdkRepo: Argument Strings Refactor - EdkRepo Command
Date: Tue,  5 Nov 2019 16:02:30 -0800	[thread overview]
Message-ID: <20191106000230.7432-8-ashley.e.desimone@intel.com> (raw)
In-Reply-To: <20191106000230.7432-1-ashley.e.desimone@intel.com>

Move all argument strings for edkrepo_command.py to
edkrepo/commands/arguments/edkrepo_cmd_args.py

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
---
 .../arguments/edkrepo_cmd_args.py}                       |  9 +++------
 edkrepo/commands/edkrepo_command.py                      | 16 ++++++----------
 2 files changed, 9 insertions(+), 16 deletions(-)
 rename edkrepo/{common/argument_strings.py => commands/arguments/edkrepo_cmd_args.py} (65%)

diff --git a/edkrepo/common/argument_strings.py b/edkrepo/commands/arguments/edkrepo_cmd_args.py
similarity index 65%
rename from edkrepo/common/argument_strings.py
rename to edkrepo/commands/arguments/edkrepo_cmd_args.py
index 75e13ee..f2d7eb6 100644
--- a/edkrepo/common/argument_strings.py
+++ b/edkrepo/commands/arguments/edkrepo_cmd_args.py
@@ -7,15 +7,12 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 
-'''Contains help and description strings for arguments in command meta data.'''
+'''Contains help and description strings for arguments in the edkrepo_command
+meta data.
+'''
 
-#Args for edk_command.py
-VERBOSE_DESCRIPTION = 'Enable verbose output'
 VERBOSE_HELP = 'Increases command verbosity'
-DRY_RUN_DESCRIPTION = "Don't actually do anything"
 DRY_RUN_HELP = "Don't actually do anything"
 OVERRIDE_HELP = 'Ignore warnings'
 SUBMODULE_SKIP_HELP = 'Skip the pull or sync of any submodules.'
 COLOR_HELP = 'Force color output (useful with \'less -r\')'
-
-
diff --git a/edkrepo/commands/edkrepo_command.py b/edkrepo/commands/edkrepo_command.py
index 75b6f35..f69bdb8 100644
--- a/edkrepo/commands/edkrepo_command.py
+++ b/edkrepo/commands/edkrepo_command.py
@@ -7,9 +7,7 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 
-# Our modules
-from edkrepo.common.argument_strings import VERBOSE_DESCRIPTION, VERBOSE_HELP, DRY_RUN_DESCRIPTION, DRY_RUN_HELP, COLOR_HELP
-from edkrepo.common.argument_strings import OVERRIDE_HELP, SUBMODULE_SKIP_HELP
+import edkrepo.commands.arguments.edkrepo_cmd_args as arguments
 
 
 class EdkrepoCommand(object):
@@ -25,30 +23,28 @@ VerboseArgument = {'name': 'verbose',
                    'short-name': 'v',
                    'positional': False,
                    'required': False,
-                   'description': VERBOSE_DESCRIPTION ,
-                   'help-text': VERBOSE_HELP}
+                   'help-text': arguments.VERBOSE_HELP}
 
 
 DryRunArgument = {'name': 'dry-run',
                   'positional': False,
                   'required': False,
-                  'description': DRY_RUN_DESCRIPTION,
-                  'help-text': DRY_RUN_HELP}
+                  'help-text': arguments.DRY_RUN_HELP}
 
 OverrideArgument = {'name': 'override',
                     'short-name': 'o',
                     'positional': False,
                     'required': False,
-                    'help-text': OVERRIDE_HELP}
+                    'help-text': arguments.OVERRIDE_HELP}
 
 ColorArgument = {'name' : 'color',
                  'short-name': 'c',
                  'positional' : False,
                  'required' : False,
-                 'help-text' : COLOR_HELP}
+                 'help-text' : arguments.COLOR_HELP}
 
 SubmoduleSkipArgument = {'name': 'skip-submodule',
                          'short-name' : 's',
                          'positional' : False,
                          'required' : False,
-                         'help-text' : SUBMODULE_SKIP_HELP}
+                         'help-text' : arguments.SUBMODULE_SKIP_HELP}
-- 
2.16.2.windows.1


      parent reply	other threads:[~2019-11-06  0:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  0:02 [edk2-devel][edk2-staging/EdkRepo][PATCH 1/8] EdkRepo: Argument String Refactor - Removed Unused Strings Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 2/8] EdkRepo: Argument String Refactor Manifest Command Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 3/8] EdkRepo: Argument String Refactor - Combo Command Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 4/8] EdkRepo: Argument String Refactory " Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 5/8] EdkRepo: Argument Strings Refactor - Sparse Command Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 6/8] EdkRepo: Argument Strings Refactor - Sync Command Desimone, Ashley E
2019-11-06  0:02 ` [edk2-devel][edk2-staging/EdkRepo][PATCH 7/8] EdkRepo: Argument Strings Refactor - Clone Command Desimone, Ashley E
2019-11-06  0:02 ` Desimone, Ashley E [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106000230.7432-8-ashley.e.desimone@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox