* [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable
@ 2019-11-07 6:49 Agyeman, Prince
2019-11-11 18:21 ` Kubacki, Michael A
0 siblings, 1 reply; 2+ messages in thread
From: Agyeman, Prince @ 2019-11-07 6:49 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Chasel Chiu, Nate DeSimone
Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c
to avoid gcc 5 build error unused-but-set-variable.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
.../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
index 3a885e0d71..eff10bddb4 100644
--- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
@@ -47,13 +47,11 @@ DetectPs2Keyboard (
)
{
UINT32 TimeOut;
- UINT32 RegEmptied;
UINT8 Data;
UINT32 SumTimeOut;
BOOLEAN FoundPs2Kbc;
TimeOut = 0;
- RegEmptied = 0;
FoundPs2Kbc = FALSE;
//
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable
2019-11-07 6:49 [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable Agyeman, Prince
@ 2019-11-11 18:21 ` Kubacki, Michael A
0 siblings, 0 replies; 2+ messages in thread
From: Kubacki, Michael A @ 2019-11-11 18:21 UTC (permalink / raw)
To: Agyeman, Prince, devel@edk2.groups.io; +Cc: Chiu, Chasel, Desimone, Nathaniel L
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, November 6, 2019 10:49 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms] [PATCH] BoardModulePkg: Remove unused
> variable
>
> Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c to avoid gcc 5 build
> error unused-but-set-variable.
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
> .../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
> a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> index 3a885e0d71..eff10bddb4 100644
> --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> +++
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> @@ -47,13 +47,11 @@ DetectPs2Keyboard (
> )
> {
> UINT32 TimeOut;
> - UINT32 RegEmptied;
> UINT8 Data;
> UINT32 SumTimeOut;
> BOOLEAN FoundPs2Kbc;
>
> TimeOut = 0;
> - RegEmptied = 0;
> FoundPs2Kbc = FALSE;
>
> //
> --
> 2.19.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-11 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-07 6:49 [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable Agyeman, Prince
2019-11-11 18:21 ` Kubacki, Michael A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox