From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.5915.1573141407821742748 for ; Thu, 07 Nov 2019 07:43:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=m3ayLHhp; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id z19so2952795wmk.3 for ; Thu, 07 Nov 2019 07:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l54Cv13BHJxdRneTF/tzzoz6FOzaHES/YgbBdIGj9F4=; b=m3ayLHhpvDh5AqXH1Bp5OtvUpfM0X1xtohyhECbeRfWf7DGw5zUx0i2DeYMkka3Kas QaiYuInj06xo2jwy8BDz457svsfO7l2DtTiy/uFg7pqplQdkt2FPH7Wl078zaNNpO0FO RlSG04vshp/FtutrbseGgEC4oux554cjRNanuTYoqsEzlxjIA3J/Q2+icu8Z7xTOy118 b/PQh+5XzQiJyj3DnT1vO7L3JnFH8cbA+0+dkH/GSAv232bjaAFwnDn286zYE+hGoVbH eegClK/2OFqhHNrSHH8yhPOP6l/UdsuljNGuYc2ncGmtprfWMjltuylxPsjkLibBBKU2 a7VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l54Cv13BHJxdRneTF/tzzoz6FOzaHES/YgbBdIGj9F4=; b=PEGq/FB76l1+uqi368AzMf42mG9r8CETzIF23TxICk7pM5uCmD9SpN3EVSmBhKclWt JjXuC0/yAgXPQukrMJprH4D66iZ5XH+Zpan1FWVIQJ4vjQfJQCUNWex1q+jeD0WU1478 YkgZ25heMPnCKkSGl8aSNqoZf3mq/KJz/EB2GrEIrK9gnoLrGUOpFyc0hRNk3pdLFnL3 hh+NFTyigsBnG9cU3Q/DbKg7t49m6yggXLK3cvEcLd9yBiIXeLH9U4WCo+yrUxBkKW99 Yz3iRRQrmOIrc+fVDRgGKTkxMaDboW53uaNGGus5HCrd4PEr7RwZg+Ehxe9Zo3GflsM4 dG5g== X-Gm-Message-State: APjAAAWUJ0sitkWAxU0iGIa4yL0+AoNb4eKqC314SFHyznKoenYZJUe0 42Vn6PwzP2+wSVToUFOx6EKOVg== X-Google-Smtp-Source: APXvYqy+GJ9nckhLieZgrpegcJRCqzDblkGKL7uHwkuenWrnOwcS9t0/8/N1MdYirmAD1W4qLG64sw== X-Received: by 2002:a7b:ce11:: with SMTP id m17mr3786531wmc.113.1573141406168; Thu, 07 Nov 2019 07:43:26 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y2sm2983063wmy.2.2019.11.07.07.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 07:43:25 -0800 (PST) Date: Thu, 7 Nov 2019 15:43:24 +0000 From: "Leif Lindholm" To: Laszlo Ersek Cc: Michael D Kinney , devel@edk2.groups.io, Sean Brogan , Andrew Fish Subject: Re: [Patch v4 03/22] requirements.txt: Add python pip requirements file Message-ID: <20191107154324.GM16820@bivouac.eciton.net> References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-4-michael.d.kinney@intel.com> <019f8e7f-388e-839b-d723-3d78027752fb@redhat.com> MIME-Version: 1.0 In-Reply-To: <019f8e7f-388e-839b-d723-3d78027752fb@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 07, 2019 at 11:39:37AM +0100, Laszlo Ersek wrote: > > +## @file > > +# EDK II Python PIP requirements file > > +# > > +# This file provides the list of python components to install using PIP. > > +# > > +# Copyright (c) Microsoft Corporation. All rights reserved.
> > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > +# https://pypi.org/project/pip/ > > +# https://pip.pypa.io/en/stable/user_guide/#requirements-files > > +# https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format > > +# > > +## > > + > > +edk2-pytool-library==0.10.* > > +edk2-pytool-extensions==0.12.* > > > > This is better, but I still find the plain "requirements.txt" filename > in the root directory of the project very confusing. What component > *exactly* insists on this file path and file name? > > I've checked > > https://pip.pypa.io/en/stable/user_guide/#requirements-files > > and it seems like "pip" can take any pathname as an argument to option "-r". > > There must be a component in the CI environment that invokes "pip". Can > we file a feature request for that component, that it try > "pip-requirements.txt" first? > > Hmmm... I just googled "github pip requirements.txt", assuming that > "github" was the component calling "pip". In the result list, I've found: > > https://github.com/ClearingHouse/clearinghoused/blob/master/pip-requirements.txt > > Is it possible that github already knows to look for > "pip-requirements.txt"? (Honestly I only suggested > "pip-requirements.txt" above because it seemed sensible.) If that's the > case, we should use it. I agree it would be sensible to investigate this approach first. > Furthermore, my understanding is that "the list of python components to > install using PIP" is only there for CI purposes. Can we please state > that explicitly in the comment block? (The commit message already does > that, and that's great.) Good point. > Basically when someone clones edk2 and runs "ls -l" for the first time, > there's a good chance "requirements.txt" will be among the few files > they open right after. Yeah. For a specific project to use that as a default config filename is ... pretty arrogant. / Leif