Re: [edk2-devel] [PATCH 1/1] Readme.md: remove positional references from submodule description

Re: [edk2-devel] [PATCH 1/1] Readme.md: remove positional references from submodule description

[Leif Lindholm]

On Thu, Nov 07, 2019 at 05:38:15PM +0000, Leif Lindholm via Groups.Io wrote:
> Remove references to the number of submodules in the tree, as well as
> reword the referring to specific submodules as "former" and "previous".
> This means we won't need to keep updating the surrounding text if we
> add/remove submodules.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Not seen any responses, so since this is a trivial text update an I
had Laszlo's pregiven R-b - pushed as cc6854506c2b.

Thanks!

> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 27e4ce07719b..9bf60bede8ec 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -144,12 +144,12 @@ Signed-off-by: Contributor Name <contributor@example.com>
>  # Submodules
>  
>  Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains two submodules
> +as possible as we can. Currently EDK II contains the following submodules
>  
>  - CryptoPkg/Library/OpensslLib/openssl
>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
>  
> -The latter one is actually required by previous one. It's inevitable
> +ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
>  in openssl-1.1.1 (since stable201905) for floating point parameter
>  conversion, but should be dropped once there's no such need in future
>  release of openssl.
> -- 
> 2.20.1
> 
> 
> 
>