public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH V5 0/8] Update SMBIOS 3.3.0
@ 2019-11-13  2:04 Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-11-13  2:04 UTC (permalink / raw)
  To: devel; +Cc: Michael D Kinney, Liming Gao, Ray Ni, Sai Chaganty

The following changes were made to version 3.2.0 of the document to produce this
version:
System Slots (Type 9):
- Add PCI Express Gen 4 values
- Clarify bus number usage for PCI Express
Memory Device (Type 17):
- Add new memory device type value (HBM) and new form factor value (Die)
- Update the string for Intel persistent memory
Various:
- Add support for RISC-V processors, add structure type 44 (processor-additional information)
- add support for CXL Flexbus

V2:
Add the new definition to MdePkg/Smbios.h.

V3:
Avoid change the enum name to casue the incompatible issue.
Add the comment instead change the enum define name.

V4:
Use the enums instead of the magic numbers.
Plan to add a new BZ to add the missing enums/MACROs and convert all
magic numbers into enums/MACROs.

V5:
Fix the typo Smbios.h to SmBios.h.

Notes:
Clarify bus number usage for PCI Express - Update the spec no code change requirement
Add support for RISC-V processors, add structure type 44 (processor-additional information) -
Already done at https://bugzilla.tianocore.org/show_bug.cgi?id=2202

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>

Gao, Zhichao (8):
  MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9
  MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus
  MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17
  MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string
  ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9
  ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus
  ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
  ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"

 MdePkg/Include/IndustryStandard/SmBios.h           | 25 ++++++++---
 .../SmbiosView/QueryTable.c                        | 50 ++++++++++++++++++++--
 .../SmbiosView/QueryTable.h                        |  4 +-
 3 files changed, 70 insertions(+), 9 deletions(-)

-- 
2.16.2.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9
  2019-11-13  2:04 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
@ 2019-11-13  2:04 ` Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
  2 siblings, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-11-13  2:04 UTC (permalink / raw)
  To: devel; +Cc: Gao, Zhichao, Michael D Kinney, Liming Gao, Sai Chaganty

From: "Gao, Zhichao" <zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305

System Slots (Type 9):
- SMBIOSCR00184: add PCI Express Gen 4 values

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index f504cc84e7..0a31e37f18 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1,7 +1,7 @@
 /** @file
   Industry Standard Definitions of SMBIOS Table Specification v3.3.0.
 
-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
 (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
 (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1307,7 +1307,13 @@ typedef enum {
   SlotTypePciExpressGen3X2             = 0xB3,
   SlotTypePciExpressGen3X4             = 0xB4,
   SlotTypePciExpressGen3X8             = 0xB5,
-  SlotTypePciExpressGen3X16            = 0xB6
+  SlotTypePciExpressGen3X16            = 0xB6,
+  SlotTypePciExpressGen4               = 0xB8,
+  SlotTypePciExpressGen4X1             = 0xB9,
+  SlotTypePciExpressGen4X2             = 0xBA,
+  SlotTypePciExpressGen4X4             = 0xBB,
+  SlotTypePciExpressGen4X8             = 0xBC,
+  SlotTypePciExpressGen4X16            = 0xBD
 } MISC_SLOT_TYPE;
 
 ///
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V5 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus
  2019-11-13  2:04 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
@ 2019-11-13  2:04 ` Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
  2 siblings, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-11-13  2:04 UTC (permalink / raw)
  To: devel; +Cc: Gao, Zhichao, Michael D Kinney, Liming Gao, Sai Chaganty

From: "Gao, Zhichao" <zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305

Various:
- SMBIOSCR00183: add support for CXL Flexbus

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 0a31e37f18..54ec837671 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1285,6 +1285,7 @@ typedef enum {
   SlotTypePciExpressMini52pinWithBSKO  = 0x21,      ///< PCI Express Mini 52-pin (CEM spec. 2.0) with bottom-side keep-outs.
   SlotTypePciExpressMini52pinWithoutBSKO = 0x22,    ///< PCI Express Mini 52-pin (CEM spec. 2.0) without bottom-side keep-outs.
   SlotTypePciExpressMini76pin          = 0x23,      ///< PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card.
+  SlotTypeCXLFlexbus10                 = 0x30,
   SlotTypePC98C20                      = 0xA0,
   SlotTypePC98C24                      = 0xA1,
   SlotTypePC98E                        = 0xA2,
@@ -1612,7 +1613,8 @@ typedef enum {
   MemoryArrayLocationPc98C20AddonCard      = 0xA0,
   MemoryArrayLocationPc98C24AddonCard      = 0xA1,
   MemoryArrayLocationPc98EAddonCard        = 0xA2,
-  MemoryArrayLocationPc98LocalBusAddonCard = 0xA3
+  MemoryArrayLocationPc98LocalBusAddonCard = 0xA3,
+  MemoryArrayLocationCXLFlexbus10AddonCard = 0xA4
 } MEMORY_ARRAY_LOCATION;
 
 ///
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V5 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17
  2019-11-13  2:04 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
  2019-11-13  2:04 ` [PATCH V5 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
@ 2019-11-13  2:04 ` Gao, Zhichao
  2 siblings, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-11-13  2:04 UTC (permalink / raw)
  To: devel; +Cc: Gao, Zhichao, Michael D Kinney, Liming Gao, Sai Chaganty

From: "Gao, Zhichao" <zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305

Memory Device (Type 17):
- SMBIOSCR00178: add new memory device type value (HBM) and new form
factor value (Die)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 54ec837671..9aa8cf3e72 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1681,7 +1681,8 @@ typedef enum {
   MemoryFormFactorRimm                     = 0x0C,
   MemoryFormFactorSodimm                   = 0x0D,
   MemoryFormFactorSrimm                    = 0x0E,
-  MemoryFormFactorFbDimm                   = 0x0F
+  MemoryFormFactorFbDimm                   = 0x0F,
+  MemoryFormFactorDie                      = 0x10
 } MEMORY_FORM_FACTOR;
 
 ///
@@ -1715,7 +1716,9 @@ typedef enum {
   MemoryTypeLpddr2                         = 0x1C,
   MemoryTypeLpddr3                         = 0x1D,
   MemoryTypeLpddr4                         = 0x1E,
-  MemoryTypeLogicalNonVolatileDevice       = 0x1F
+  MemoryTypeLogicalNonVolatileDevice       = 0x1F,
+  MemoryTypeHBM                            = 0x20,
+  MemoryTypeHBM2                           = 0x21
 } MEMORY_DEVICE_TYPE;
 
 ///
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V5 2/8] MdePkg/SmBios.h: SMBIOS 3.3.0 add support for CXL Flexbus
  2019-11-13  2:11 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
@ 2019-11-13  2:11 ` Gao, Zhichao
  0 siblings, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-11-13  2:11 UTC (permalink / raw)
  To: devel; +Cc: Gao, Zhichao, Michael D Kinney, Liming Gao, Sai Chaganty

From: "Gao, Zhichao" <zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305

Various:
- SMBIOSCR00183: add support for CXL Flexbus

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 0a31e37f18..54ec837671 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1285,6 +1285,7 @@ typedef enum {
   SlotTypePciExpressMini52pinWithBSKO  = 0x21,      ///< PCI Express Mini 52-pin (CEM spec. 2.0) with bottom-side keep-outs.
   SlotTypePciExpressMini52pinWithoutBSKO = 0x22,    ///< PCI Express Mini 52-pin (CEM spec. 2.0) without bottom-side keep-outs.
   SlotTypePciExpressMini76pin          = 0x23,      ///< PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card.
+  SlotTypeCXLFlexbus10                 = 0x30,
   SlotTypePC98C20                      = 0xA0,
   SlotTypePC98C24                      = 0xA1,
   SlotTypePC98E                        = 0xA2,
@@ -1612,7 +1613,8 @@ typedef enum {
   MemoryArrayLocationPc98C20AddonCard      = 0xA0,
   MemoryArrayLocationPc98C24AddonCard      = 0xA1,
   MemoryArrayLocationPc98EAddonCard        = 0xA2,
-  MemoryArrayLocationPc98LocalBusAddonCard = 0xA3
+  MemoryArrayLocationPc98LocalBusAddonCard = 0xA3,
+  MemoryArrayLocationCXLFlexbus10AddonCard = 0xA4
 } MEMORY_ARRAY_LOCATION;
 
 ///
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-11-13  2:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-13  2:04 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
2019-11-13  2:04 ` [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 Gao, Zhichao
2019-11-13  2:04 ` [PATCH V5 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao
2019-11-13  2:04 ` [PATCH V5 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17 Gao, Zhichao
  -- strict thread matches above, loose matches on Subject: below --
2019-11-13  2:11 [PATCH V5 0/8] Update SMBIOS 3.3.0 Gao, Zhichao
2019-11-13  2:11 ` [PATCH V5 2/8] MdePkg/SmBios.h: SMBIOS 3.3.0 add support for CXL Flexbus Gao, Zhichao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox