[PATCH 0/3] Add missing strings for uni files

[PATCH 0/3] Add missing strings for uni files

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

There are missing strings in MdeModulePkg.uni, NetworkPkg.uni
and UefiCpuPkg.uni. So add them into uni files.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Shenglei Zhang (3):
  MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD
  NetworkPkg/NetworkPkg.uni: Add missing strings for PCD
  UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

 MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++
 NetworkPkg/NetworkPkg.uni     |  7 +++++++
 UefiCpuPkg/UefiCpuPkg.uni     | 16 ++++++++++++++++
 3 files changed, 35 insertions(+)

-- 
2.18.0.windows.1

[PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index a2c7a7ded3e8..d9c7b1ac6cf0 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -660,6 +660,18 @@
                                                                                                         "TRUE  - Device Path From Text Protocol will be produced.<BR>\n"
                                                                                                         "FALSE - Device Path From Text Protocol will not be produced.<BR>"
 
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEnableVariableRuntimeCache_PROMPT  #language en-US "Enable the UEFI variable runtime cache."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEnableVariableRuntimeCache_HELP  #language en-US "Indicates if the UEFI variable runtime cache should be enabled.<BR><BR>\n"
+                                                                                               "This setting only applies if SMM variables are enabled. When enabled, all variable<BR>\n"
+                                                                                               "data for Runtime Service GetVariable () and GetNextVariableName () calls is retrieved<BR>\n"
+                                                                                               "from a runtime data buffer referred to as the "runtime cache". An SMI is not triggered<BR>\n"
+                                                                                               "at all for these requests. Variables writes still trigger an SMI. This can greatly<BR>\n"
+                                                                                               "reduce overall system SMM usage as most boots tend to issue far more variable reads<BR>\n"
+                                                                                               "than writes.<BR>\n"
+                                                                                               "TRUE  - The UEFI variable runtime cache is enabled.<BR>\n"
+                                                                                               "FALSE - The UEFI variable runtime cache is disabled.<BR>"
+
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVariableCollectStatistics_PROMPT  #language en-US "Enable variable statistics collection"
 
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVariableCollectStatistics_HELP  #language en-US "Indicates if the statistics about variable usage will be collected. This information is stored as a vendor configuration table into the EFI system table. Set this PCD to TRUE to use VariableInfo application in MdeModulePkg\Application directory to get variable usage info. VariableInfo application will not output information if not set to TRUE.<BR><BR>\n"
-- 
2.18.0.windows.1

[PATCH] MdePkg: Update the comments of IsLanguageSupported

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

Keep the comment style of IsLanguageSupported align with
other functions.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
 MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
index cc03be84c2d8..07c45d1e91ff 100644
--- a/MdePkg/Library/UefiLib/UefiLib.c
+++ b/MdePkg/Library/UefiLib/UefiLib.c
@@ -641,15 +641,15 @@ EfiTestChildHandle (
 }
 
 /**
- * This function checks the supported languages list for a target language,
- * This only supports RFC 4646 Languages.
- *
- * @param      SupportedLanguages  The supported languages
- * @param      TargetLanguage      The target language
- *
- * @return     Returns EFI_SUCCESS if the language is supported,
- *             EFI_UNSUPPORTED otherwise
- */
+  This function checks the supported languages list for a target language,
+  This only supports RFC 4646 Languages.
+
+  @param  SupportedLanguages  The supported languages
+  @param  TargetLanguage      The target language
+
+  @retval Returns EFI_SUCCESS if the language is supported,
+          EFI_UNSUPPORTED otherwise
+**/
 EFI_STATUS
 EFIAPI
 IsLanguageSupported (
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
index 67c6f96747ca..0abb40d6ecbd 100644
--- a/MdePkg/Include/Library/UefiLib.h
+++ b/MdePkg/Include/Library/UefiLib.h
@@ -462,15 +462,16 @@ EfiTestChildHandle (
   );
 
 /**
- * This function checks the supported languages list for a target language,
- * This only supports RFC 4646 Languages.
- *
- * @param      SupportedLanguages  The supported languages
- * @param      TargetLanguage      The target language
- *
- * @return     Returns EFI_SUCCESS if the language is supported,
- *             EFI_UNSUPPORTED otherwise
- */
+  This function checks the supported languages list for a target language,
+  This only supports RFC 4646 Languages.
+
+  @param  SupportedLanguages  The supported languages
+  @param  TargetLanguage      The target language
+
+  @retval Returns EFI_SUCCESS if the language is supported,
+          EFI_UNSUPPORTED otherwise
+
+**/
 EFI_STATUS
 EFIAPI
 IsLanguageSupported (
-- 
2.18.0.windows.1

[PATCH] UefiCpuPkg: Update the coding styles

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

In MpLib.c, remove the white space on a new line.
In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index 49be5d5385d9..d32adf0780b7 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -475,7 +475,7 @@ CollectProcessorCount (
     CpuPause ();
   }
 
-  
+
   //
   // Enable x2APIC mode if
   //  1. Number of CPU is greater than 255; or
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
index f891a811126f..2483f2ea849d 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
@@ -342,7 +342,7 @@ RestoreCr2 (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
index e5c4788c13d7..810985df20ae 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
@@ -1275,7 +1275,7 @@ RestoreCr2 (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
index daf977f654b4..7e7c73f27f76 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
@@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
 
   @retval TRUE  Access to non-SMRAM is restricted.
   @retval FALSE Access to non-SMRAM is not restricted.
-*/
+**/
 BOOLEAN
 IsRestrictedMemoryAccess (
   VOID
-- 
2.18.0.windows.1

[PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 NetworkPkg/NetworkPkg.uni | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
index 19e57a4a60de..328d8cb54a6e 100644
--- a/NetworkPkg/NetworkPkg.uni
+++ b/NetworkPkg/NetworkPkg.uni
@@ -61,6 +61,13 @@
                                                                                           "TRUE  - Certificate Authentication feature is enabled.<BR>\n"
                                                                                           "FALSE - Does not support Certificate Authentication.<BR>"
 
+#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_PROMPT  #language en-US "Indicates whether SnpDxe creates event for ExitBootServices() call."
+
+#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_HELP  #language en-US "Indicates whether SnpDxe driver will create an event that will be notified<BR><BR>\n"
+                                                                                                 "upon gBS->ExitBootServices() call.<BR>\n"
+                                                                                                 "TRUE - Event being triggered upon ExitBootServices call will be created<BR>\n"
+                                                                                                 "FALSE - Event being triggered upon ExitBootServices call will NOT be created<BR>"
+
 #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_PROMPT  #language en-US "Type Value of Dhcp6 Unique Identifier (DUID)."
 
 #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_HELP  #language en-US "IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355).\n"
-- 
2.18.0.windows.1

[PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

[Zhang, Shenglei]

From: Shenglei Zhang <shenglei.zhang@intel.com>

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
index a7e279c5cb14..bfd696f48c35 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -195,6 +195,22 @@
 
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_HELP  #language en-US "Indicates if the current boot is a power-on reset."
 
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_PROMPT  #language en-US "Access to non-SMRAM memory is restricted to reserved, runtime and ACPI NVS type after SmmReadyToLock."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_HELP  #language en-US "Indicate access to non-SMRAM memory is restricted to reserved, runtime and ACPI NVS type after SmmReadyToLock.<BR><BR>\n"
+                                                                                            "MMIO access is always allowed regardless of the value of this PCD.<BR>\n"
+                                                                                            "Loose of such restriction is only required by RAS components in X64 platforms.<BR>\n"
+                                                                                            "The PCD value is considered as constantly TRUE in IA32 platforms.<BR>\n"
+                                                                                            "When the PCD value is TRUE, page table is initialized to cover all memory spaces<BR>\n"
+                                                                                            "and the memory occupied by page table is protected by page table itself as read-only.<BR>\n"
+                                                                                            "In X64 build, it cannot be enabled at the same time with SMM profile feature (PcdCpuSmmProfileEnable).<BR>\n"
+                                                                                            "In X64 build, it could not be enabled also at the same time with heap guard feature for SMM<BR>\n"
+                                                                                            "(PcdHeapGuardPropertyMask in MdeModulePkg).<BR>\n"
+                                                                                            "In IA32 build, page table memory is not marked as read-only when either SMM profile feature (PcdCpuSmmProfileEnable)<BR>\n"
+                                                                                            "or heap guard feature for SMM (PcdHeapGuardPropertyMask in MdeModulePkg) is enabled.<BR>\n"
+                                                                                            "TRUE  - Access to non-SMRAM memory is restricted to reserved, runtime and ACPI NVS type after SmmReadyToLock.<BR>\n"
+                                                                                            "FALSE - Access to any type of non-SMRAM memory after SmmReadyToLock is allowed.<BR>"
+
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_PROMPT  #language en-US "Processor feature capabilities."
 
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_HELP  #language en-US "Indicates processor feature capabilities, each bit corresponding to a specific feature."
-- 
2.18.0.windows.1

Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files

[Laszlo Ersek]

On 11/14/19 12:46, Zhang, Shenglei wrote:
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> There are missing strings in MdeModulePkg.uni, NetworkPkg.uni
> and UefiCpuPkg.uni. So add them into uni files.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Shenglei Zhang (3):
>   MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD
>   NetworkPkg/NetworkPkg.uni: Add missing strings for PCD
>   UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD
> 
>  MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++
>  NetworkPkg/NetworkPkg.uni     |  7 +++++++
>  UefiCpuPkg/UefiCpuPkg.uni     | 16 ++++++++++++++++
>  3 files changed, 35 insertions(+)
> 

This blurb announces three patches in the series. However, in response to the blurb, five patches in total seem to have been posted (and, based on the message-id fields in those patch emails, everything was sent out in a single git invocation):

[edk2-devel] [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD
[edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported
[edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles
[edk2-devel] [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD
[edk2-devel] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

This makes no sense to me. Please either repost the full (5-part) series with correct numbering on each patch (including the blurb), or else, please split out the un-numbered patches to standalone postings. The decision between both options should be based on whether it is logical to collect all five patches into a single series, or if it's more logical to post 3 + 1 + 1 patches.

(Note: despite appearances, this problem is *not* inherent to mailing lists -- if you submit a github pull request with 5 patches, and it turns out that 2 out of 5 are (each) unrelated to anything else, then any reviewer worth their salt will request separate PRs for each of those stand-alone patches.)

Thanks
Laszlo

Re: [PATCH] MdePkg: Update the comments of IsLanguageSupported

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg: Update the comments of IsLanguageSupported
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Keep the comment style of IsLanguageSupported align with
> other functions.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
>  MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
>  2 files changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index cc03be84c2d8..07c45d1e91ff 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -641,15 +641,15 @@ EfiTestChildHandle (
>  }
> 
>  /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param      SupportedLanguages  The supported languages
> - * @param      TargetLanguage      The target language
> - *
> - * @return     Returns EFI_SUCCESS if the language is supported,
> - *             EFI_UNSUPPORTED otherwise
> - */
> +  This function checks the supported languages list for a target language,
> +  This only supports RFC 4646 Languages.
> +
> +  @param  SupportedLanguages  The supported languages
> +  @param  TargetLanguage      The target language
> +
> +  @retval Returns EFI_SUCCESS if the language is supported,
> +          EFI_UNSUPPORTED otherwise
> +**/
>  EFI_STATUS
>  EFIAPI
>  IsLanguageSupported (
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 67c6f96747ca..0abb40d6ecbd 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -462,15 +462,16 @@ EfiTestChildHandle (
>    );
> 
>  /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param      SupportedLanguages  The supported languages
> - * @param      TargetLanguage      The target language
> - *
> - * @return     Returns EFI_SUCCESS if the language is supported,
> - *             EFI_UNSUPPORTED otherwise
> - */
> +  This function checks the supported languages list for a target language,
> +  This only supports RFC 4646 Languages.
> +
> +  @param  SupportedLanguages  The supported languages
> +  @param  TargetLanguage      The target language
> +
> +  @retval Returns EFI_SUCCESS if the language is supported,
> +          EFI_UNSUPPORTED otherwise
> +
> +**/
>  EFI_STATUS
>  EFIAPI
>  IsLanguageSupported (
> --
> 2.18.0.windows.1

Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files

[Zhang, Shenglei]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, November 14, 2019 5:33 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda,
> Maciej <maciej.rabeda@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files
> 
> On 11/14/19 12:46, Zhang, Shenglei wrote:
> > From: Shenglei Zhang <shenglei.zhang@intel.com>
> >
> > There are missing strings in MdeModulePkg.uni, NetworkPkg.uni
> > and UefiCpuPkg.uni. So add them into uni files.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Shenglei Zhang (3):
> >   MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD
> >   NetworkPkg/NetworkPkg.uni: Add missing strings for PCD
> >   UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD
> >
> >  MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++
> >  NetworkPkg/NetworkPkg.uni     |  7 +++++++
> >  UefiCpuPkg/UefiCpuPkg.uni     | 16 ++++++++++++++++
> >  3 files changed, 35 insertions(+)
> >
> 
> This blurb announces three patches in the series. However, in response to the
> blurb, five patches in total seem to have been posted (and, based on the
> message-id fields in those patch emails, everything was sent out in a single git
> invocation):
> 
> [edk2-devel] [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing
> strings for PCD
> [edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported
> [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles
> [edk2-devel] [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for
> PCD
> [edk2-devel] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for
> PCD
> 
> This makes no sense to me. Please either repost the full (5-part) series with
> correct numbering on each patch (including the blurb), or else, please split out
> the un-numbered patches to standalone postings. The decision between both
> options should be based on whether it is logical to collect all five patches into a
> single series, or if it's more logical to post 3 + 1 + 1 patches.
> 
> (Note: despite appearances, this problem is *not* inherent to mailing lists -- if
> you submit a github pull request with 5 patches, and it turns out that 2 out of 5
> are (each) unrelated to anything else, then any reviewer worth their salt will
> request separate PRs for each of those stand-alone patches.)
> 

Hi Laszlo,

I sent all these 5 patches in one git command. So they may cause confusion.
I think I can submit separated pull request for these patches.

Thanks,
Shenglei

> Thanks
> Laszlo
> 
> 
> 

Re: [PATCH] UefiCpuPkg: Update the coding styles

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH] UefiCpuPkg: Update the coding styles
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> In MpLib.c, remove the white space on a new line.
> In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 49be5d5385d9..d32adf0780b7 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -475,7 +475,7 @@ CollectProcessorCount (
>      CpuPause ();
>    }
> 
> -
> +
>    //
>    // Enable x2APIC mode if
>    //  1. Number of CPU is greater than 255; or diff --git
> a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> index f891a811126f..2483f2ea849d 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> @@ -342,7 +342,7 @@ RestoreCr2 (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index e5c4788c13d7..810985df20ae 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1275,7 +1275,7 @@ RestoreCr2 (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7e7c73f27f76 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
> 
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> --
> 2.18.0.windows.1

Re: [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD

[Wu, Jiaxin]

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>



> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej
> <maciej.rabeda@intel.com>
> Subject: [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for
> PCD
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  NetworkPkg/NetworkPkg.uni | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
> index 19e57a4a60de..328d8cb54a6e 100644
> --- a/NetworkPkg/NetworkPkg.uni
> +++ b/NetworkPkg/NetworkPkg.uni
> @@ -61,6 +61,13 @@
>                                                                                            "TRUE  - Certificate
> Authentication feature is enabled.<BR>\n"
>                                                                                            "FALSE - Does not support
> Certificate Authentication.<BR>"
> 
> +#string
> STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_
> PROMPT  #language en-US "Indicates whether SnpDxe creates event for
> ExitBootServices() call."
> +
> +#string
> STR_gEfiNetworkPkgTokenSpaceGuid_PcdSnpCreateExitBootServicesEvent_
> HELP  #language en-US "Indicates whether SnpDxe driver will create an
> event that will be notified<BR><BR>\n"
> +                                                                                                 "upon gBS-
> >ExitBootServices() call.<BR>\n"
> +                                                                                                 "TRUE - Event being
> triggered upon ExitBootServices call will be created<BR>\n"
> +                                                                                                 "FALSE - Event being
> triggered upon ExitBootServices call will NOT be created<BR>"
> +
>  #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_PROMPT
> #language en-US "Type Value of Dhcp6 Unique Identifier (DUID)."
> 
>  #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdDhcp6UidType_HELP
> #language en-US "IPv6 DHCP Unique Identifier (DUID) Type configuration
> (From RFCs 3315 and 6355).\n"
> --
> 2.18.0.windows.1

Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for
> PCD
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
> a7e279c5cb14..bfd696f48c35 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -195,6 +195,22 @@
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_HELP
> #language en-US "Indicates if the current boot is a power-on reset."
> 
> +#string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_P
> ROMPT  #language en-US "Access to non-SMRAM memory is restricted to
> reserved, runtime and ACPI NVS type after SmmReadyToLock."
> +
> +#string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_H
> ELP  #language en-US "Indicate access to non-SMRAM memory is restricted
> to reserved, runtime and ACPI NVS type after
> SmmReadyToLock.<BR><BR>\n"
> +
> "MMIO access is always allowed regardless of the value of this PCD.<BR>\n"
> +
> "Loose of such restriction is only required by RAS components in X64
> platforms.<BR>\n"
> +
> "The PCD value is considered as constantly TRUE in IA32 platforms.<BR>\n"
> +
> "When the PCD value is TRUE, page table is initialized to cover all memory
> spaces<BR>\n"
> +
> "and the memory occupied by page table is protected by page table itself as
> read-only.<BR>\n"
> +
> "In X64 build, it cannot be enabled at the same time with SMM profile
> feature (PcdCpuSmmProfileEnable).<BR>\n"
> +
> "In X64 build, it could not be enabled also at the same time with heap guard
> feature for SMM<BR>\n"
> +
> "(PcdHeapGuardPropertyMask in MdeModulePkg).<BR>\n"
> +
> "In IA32 build, page table memory is not marked as read-only when either
> SMM profile feature (PcdCpuSmmProfileEnable)<BR>\n"
> +
> "or heap guard feature for SMM (PcdHeapGuardPropertyMask in
> MdeModulePkg) is enabled.<BR>\n"
> +
> "TRUE  - Access to non-SMRAM memory is restricted to reserved, runtime
> and ACPI NVS type after SmmReadyToLock.<BR>\n"
> +
> "FALSE - Access to any type of non-SMRAM memory after SmmReadyToLock
> is allowed.<BR>"
> +
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_PROMPT
> #language en-US "Processor feature capabilities."
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_HELP
> #language en-US "Indicates processor feature capabilities, each bit
> corresponding to a specific feature."
> --
> 2.18.0.windows.1

Re: [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD

[Wang, Jian J]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings
> for PCD
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index a2c7a7ded3e8..d9c7b1ac6cf0 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -660,6 +660,18 @@
>                                                                                                          "TRUE  - Device Path
> From Text Protocol will be produced.<BR>\n"
>                                                                                                          "FALSE - Device Path
> From Text Protocol will not be produced.<BR>"
> 
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEnableVariableRuntimeCache_PR
> OMPT  #language en-US "Enable the UEFI variable runtime cache."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEnableVariableRuntimeCache_HEL
> P  #language en-US "Indicates if the UEFI variable runtime cache should be
> enabled.<BR><BR>\n"
> +                                                                                               "This setting only applies if
> SMM variables are enabled. When enabled, all variable<BR>\n"
> +                                                                                               "data for Runtime Service
> GetVariable () and GetNextVariableName () calls is retrieved<BR>\n"
> +                                                                                               "from a runtime data
> buffer referred to as the "runtime cache". An SMI is not triggered<BR>\n"
> +                                                                                               "at all for these requests.
> Variables writes still trigger an SMI. This can greatly<BR>\n"
> +                                                                                               "reduce overall system
> SMM usage as most boots tend to issue far more variable reads<BR>\n"
> +                                                                                               "than writes.<BR>\n"
> +                                                                                               "TRUE  - The UEFI variable
> runtime cache is enabled.<BR>\n"
> +                                                                                               "FALSE - The UEFI variable
> runtime cache is disabled.<BR>"
> +
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVariableCollectStatistics_PROMPT
> #language en-US "Enable variable statistics collection"
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVariableCollectStatistics_HELP
> #language en-US "Indicates if the statistics about variable usage will be
> collected. This information is stored as a vendor configuration table into the EFI
> system table. Set this PCD to TRUE to use VariableInfo application in
> MdeModulePkg\Application directory to get variable usage info. VariableInfo
> application will not output information if not set to TRUE.<BR><BR>\n"
> --
> 2.18.0.windows.1

Re: [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles

[Laszlo Ersek]

On 11/14/19 12:46, Zhang, Shenglei wrote:
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> In MpLib.c, remove the white space on a new line.
> In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/MpLib.c       | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c   | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c    | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 49be5d5385d9..d32adf0780b7 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -475,7 +475,7 @@ CollectProcessorCount (
>      CpuPause ();
>    }
>  
> -  
> +
>    //
>    // Enable x2APIC mode if
>    //  1. Number of CPU is greater than 255; or
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> index f891a811126f..2483f2ea849d 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c
> @@ -342,7 +342,7 @@ RestoreCr2 (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> index e5c4788c13d7..810985df20ae 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c
> @@ -1275,7 +1275,7 @@ RestoreCr2 (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7e7c73f27f76 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -1455,7 +1455,7 @@ InitializeDataForMmMp (
>  
>    @retval TRUE  Access to non-SMRAM is restricted.
>    @retval FALSE Access to non-SMRAM is not restricted.
> -*/
> +**/
>  BOOLEAN
>  IsRestrictedMemoryAccess (
>    VOID
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>