From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web09.6383.1573747677456414388 for ; Thu, 14 Nov 2019 08:07:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=NIbf9zYy; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id n1so7085197wra.10 for ; Thu, 14 Nov 2019 08:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C2tDvDkhhmqPhUxoHLTvN1U0TETFVyrXrkE/zqR7808=; b=NIbf9zYyBE83xf66PPdbHLD6jj/0ayLfOT+nI9JCus3x12iyY8oVK1eR0+655Sre4R QMPUrXyHNcKylwQ4Ki6xKTYgdFehXa4kkK/xGnqw6xotsZ+4ZmvKy6A50PZ+4LxOd1rd NvMy4bpKpYZjHxBd3aB9PyO5pUbPztS4igSH2wKOjsu4R1xtEJOB8ZGTSODP4cOPMqS2 OUv53ZFS4+xbsDCF712NXe/kRQwJPlla95GEh0Xrvx6nlTz1ZvC7T84lQW5H6CCo/zgh PNIh0nEmw6ECglD69srh1jgzrb9Ap+XRMJQkp8KJZazpWV8mZVZTwXH9JlUUCCHU4t/u /Skg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C2tDvDkhhmqPhUxoHLTvN1U0TETFVyrXrkE/zqR7808=; b=XmdYxk4g39A7FcaLs+WQ47HZKZ6p7+Tw347oMrXpyFM0PqgVDhvS42Fx+DOSTc4F0c OpG3zrt1l5min1Y38cwtka4h1CsuGP+7jzd9bJ9qTNQyY3MgcCaNKnGbE435UnA1Gi2v Dlzlbahy/kgyt+kIy1ERa9YXRtFza+0beuM3Hrx/uROCs8THfaEcf8YOmGzUQpvo/4Up QwWosXMHm0H5KOPSeRtiw9J2mi4ljiX5gAyGSJO36vUFTryRcXDecEa3Lg20QMbCrJ3H R9hNELtCuV0h5RTVDLebQo7Fokt/lolm3kxUKS2WB+EKOJYDrReUhcAbnI0wIJxn0sMS KGQg== X-Gm-Message-State: APjAAAVVue++TIQtf89zMqxqbxt06ZpK92h+7t39l0z1JhlU7+OcrFfG mOkiZQWkX41j10lJ62N9LBEea9yjIeQ= X-Google-Smtp-Source: APXvYqzTeDnCHJiMtHEcySFh0SmKPAzwlSjlkEQqdJZbDutyM10fXgRf+7CH6jeCgvUu6mq84YBxlQ== X-Received: by 2002:adf:9323:: with SMTP id 32mr8922633wro.15.1573747675554; Thu, 14 Nov 2019 08:07:55 -0800 (PST) Return-Path: Received: from localhost.localdomain ([84.203.67.47]) by smtp.gmail.com with ESMTPSA id a16sm6793088wmd.11.2019.11.14.08.07.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 08:07:54 -0800 (PST) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, philmd@redhat.com Subject: [edk2-platforms][PATCH 2/8] Platform/RPi: Replace Bcm283x SoC base register address with a PCD Date: Thu, 14 Nov 2019 16:07:34 +0000 Message-Id: <20191114160740.10072-3-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20191114160740.10072-1-pete@akeo.ie> References: <20191114160740.10072-1-pete@akeo.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Samer El-Haj-Mahmoud Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is needed in preparation for adding Raspberry Pi 4 support, since the two Pi's have a different base addresses for the Bcm283x specific registers. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 2 ++ Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 2 ++ Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 4 ++++ Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 5 ++++- Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf | 2 ++ Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf | 3 ++- Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++- Silicon/Broadcom/Bcm283x/Bcm283x.dec | 7 +++++++ Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf | 4 +++- Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf | 5 +++++ Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 3 ++- Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf | 4 ++++ 12 files changed, 42 insertions(+), 5 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf index 3f0d7b6b9e9d..034c8c449f00 100644 --- a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf +++ b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf @@ -1,5 +1,6 @@ #/** @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2017, Andrei Warkentin # Copyright (c) Microsoft Corporation. All rights reserved. # @@ -42,6 +43,7 @@ [Protocols] [Pcd] gRaspberryPiTokenSpaceGuid.PcdSdIsArasan + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress [Depex] gRaspberryPiFirmwareProtocolGuid AND gRaspberryPiConfigAppliedProtocolGuid diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf index 28fc2682b585..4f4fdef4e003 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf @@ -1,5 +1,6 @@ #/** @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2018, Andrei Warkentin # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -66,6 +67,7 @@ [Pcd] gRaspberryPiTokenSpaceGuid.PcdDebugShowUEFIExit gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress [FeaturePcd] diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf index e880c2fb0261..8817f20622d6 100644 --- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf +++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf @@ -1,5 +1,6 @@ #/** @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2017-2018, Andrei Warkentin # Copyright (c) 2015-2016, Linaro Limited. All rights reserved. # @@ -51,5 +52,8 @@ [Protocols] gEfiUsb2HcProtocolGuid gRaspberryPiFirmwareProtocolGuid +[FixedPcd] + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress + [Depex] gRaspberryPiFirmwareProtocolGuid diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf index 87bca98fec28..a3fc0fa49a3c 100644 --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf @@ -1,5 +1,5 @@ #/** @file -# +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2017-2018, Andrei Warkentin # Copyright (c) 2016, Linaro, Ltd. All rights reserved. # @@ -40,5 +40,8 @@ [LibraryClasses] [Protocols] gRaspberryPiFirmwareProtocolGuid ## PRODUCES +[FixedPcd] + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress + [Depex] TRUE diff --git a/Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf b/Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf index 7386ff251864..b99f197bb007 100644 --- a/Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf +++ b/Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.inf @@ -1,5 +1,6 @@ #/** @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2017, Andrei Warkentin # Copyright (c) Microsoft Corporation. All rights reserved. # @@ -44,6 +45,7 @@ [Protocols] [Pcd] gRaspberryPiTokenSpaceGuid.PcdSdIsArasan + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress [Depex] gRaspberryPiFirmwareProtocolGuid AND gRaspberryPiConfigAppliedProtocolGuid diff --git a/Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf b/Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf index ed986034b957..85462febdd8d 100644 --- a/Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf +++ b/Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf @@ -2,7 +2,7 @@ # # Copyright (c) 2017-2018, Andrei Warkentin # Copyright (c) 2014-2016, Linaro Limited. All rights reserved. -# Copyright (c) 2011-2014, ARM Limited. All rights reserved. +# Copyright (c) 2011-2019, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -54,6 +54,7 @@ [FixedPcd] gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress [Ppis] gArmMpCoreInfoPpiGuid diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index a0365c5cf606..4e5a9f0b05e6 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -1,6 +1,6 @@ # @file # -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. +# Copyright (c) 2011 - 2019, ARM Limited. All rights reserved. # Copyright (c) 2014, Linaro Limited. All rights reserved. # Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. # Copyright (c) 2017 - 2018, Andrei Warkentin @@ -372,6 +372,10 @@ [PcdsFixedAtBuild.common] gArmTokenSpaceGuid.PcdSystemMemoryBase|0x00400000 gArmTokenSpaceGuid.PcdSystemMemorySize|0x3FC00000 + # + # Device specific addresses + # + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress|0x3f000000 ## NS16550 compatible UART gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x3f215040 gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|TRUE diff --git a/Silicon/Broadcom/Bcm283x/Bcm283x.dec b/Silicon/Broadcom/Bcm283x/Bcm283x.dec index ec62ff27fbb3..5b839b00d286 100644 --- a/Silicon/Broadcom/Bcm283x/Bcm283x.dec +++ b/Silicon/Broadcom/Bcm283x/Bcm283x.dec @@ -1,5 +1,6 @@ ## @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2019, Pete Batard # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -14,3 +15,9 @@ [Defines] [Includes] Include + +[Guids] + gBcm283xTokenSpaceGuid = {0x82f36a92, 0xfb7e, 0x43a1, {0xb9, 0x9e, 0x49, 0x13, 0x3f, 0xc7, 0xa4, 0x2e}} + +[PcdsFixedAtBuild.common] + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress|0x0|UINT32|0x00000001 diff --git a/Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf b/Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf index cdce11a51e14..6c58df5c3285 100644 --- a/Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf +++ b/Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.inf @@ -1,5 +1,5 @@ #/** @file -# +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2017, Andrei Warkentin # Copyright (c) 2016 Linaro, Ltd. All rights reserved. # @@ -30,6 +30,7 @@ [LibraryClasses] UefiBootServicesTableLib UefiLib UefiDriverEntryPoint + PcdLib [Protocols] gHardwareInterruptProtocolGuid ## PRODUCES @@ -37,6 +38,7 @@ [Protocols] [FixedPcd] gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress [Depex] TRUE diff --git a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf b/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf index cb1695bd2dfc..4481d71aaff0 100644 --- a/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf +++ b/Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.inf @@ -1,5 +1,6 @@ #/** @file # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2019 Linaro, Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -28,6 +29,7 @@ [LibraryClasses] IoLib UefiBootServicesTableLib UefiDriverEntryPoint + PcdLib [Protocols] gEfiRngProtocolGuid ## PRODUCES @@ -35,5 +37,8 @@ [Protocols] [Guids] gEfiRngAlgorithmRaw +[FixedPcd] + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress + [Depex] TRUE diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h index 4007301228be..8bd68c234bfd 100644 --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h @@ -1,5 +1,6 @@ /** @file * + * Copyright (c) 2019, ARM Limited. All rights reserved. * Copyright (c) 2017, Andrei Warkentin * Copyright (c) 2016, Linaro Limited. All rights reserved. * @@ -13,7 +14,7 @@ /* * Both "core" and SoC perpherals (1M each). */ -#define BCM2836_SOC_REGISTERS 0x3f000000 +#define BCM2836_SOC_REGISTERS (FixedPcdGet64 (PcdBcm283xRegistersAddress)) #define BCM2836_SOC_REGISTER_LENGTH 0x02000000 /* diff --git a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf b/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf index 50da4eb771f3..ff1b5af6db6e 100644 --- a/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf +++ b/Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf @@ -2,6 +2,7 @@ # # Manipulate GPIOs. # +# Copyright (c) 2019, ARM Limited. All rights reserved. # Copyright (c) 2018, Andrei Warkentin # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -30,4 +31,7 @@ [LibraryClasses] DebugLib IoLib +[FixedPcd] + gBcm283xTokenSpaceGuid.PcdBcm283xRegistersAddress + [Guids] -- 2.21.0.windows.1