public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py
@ 2019-11-14 22:46 Desimone, Ashley E
  2019-11-14 23:17 ` Nate DeSimone
  0 siblings, 1 reply; 2+ messages in thread
From: Desimone, Ashley E @ 2019-11-14 22:46 UTC (permalink / raw)
  To: devel; +Cc: Nate DeSimone, Puja Pandya

Add traceback to the case where the preferred entry point cannot
be loaded.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
---
 edkrepo/edkrepo_entry_point.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.py
index d63d8cb..76a5a18 100644
--- a/edkrepo/edkrepo_entry_point.py
+++ b/edkrepo/edkrepo_entry_point.py
@@ -90,8 +90,9 @@ def main():
         mod = importlib.import_module(pref_entry)
         func = getattr(mod, pref_entry_func)
         func()
-    except:
+    except Exception as e:
         print('Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py')
+        traceback.print_exc()
         import edkrepo.edkrepo_cli
         edkrepo.edkrepo_cli.main()
 
@@ -100,4 +101,4 @@ if __name__ == "__main__":
         sys.exit(main())
     except Exception as e:
         traceback.print_exc()
-        sys.exit(1)
\ No newline at end of file
+        sys.exit(1)
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py
  2019-11-14 22:46 [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py Desimone, Ashley E
@ 2019-11-14 23:17 ` Nate DeSimone
  0 siblings, 0 replies; 2+ messages in thread
From: Nate DeSimone @ 2019-11-14 23:17 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io; +Cc: Pandya, Puja

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Thursday, November 14, 2019 2:47 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>
Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py

Add traceback to the case where the preferred entry point cannot be loaded.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
---
 edkrepo/edkrepo_entry_point.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.py index d63d8cb..76a5a18 100644
--- a/edkrepo/edkrepo_entry_point.py
+++ b/edkrepo/edkrepo_entry_point.py
@@ -90,8 +90,9 @@ def main():
         mod = importlib.import_module(pref_entry)
         func = getattr(mod, pref_entry_func)
         func()
-    except:
+    except Exception as e:
         print('Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py')
+        traceback.print_exc()
         import edkrepo.edkrepo_cli
         edkrepo.edkrepo_cli.main()
 
@@ -100,4 +101,4 @@ if __name__ == "__main__":
         sys.exit(main())
     except Exception as e:
         traceback.print_exc()
-        sys.exit(1)
\ No newline at end of file
+        sys.exit(1)
--
2.16.2.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-14 23:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-14 22:46 [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py Desimone, Ashley E
2019-11-14 23:17 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox