From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web09.7880.1574095843354429916 for ; Mon, 18 Nov 2019 08:50:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=D9pF31Bx; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id b11so18160992wmb.5 for ; Mon, 18 Nov 2019 08:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5kPXeqc63XovMpnzawA98htukZjbFE4T2x6goLtpsxw=; b=D9pF31BxG0m6ArDHufPxWbXDk3d2fsQ85ljuAXEHA4xEPXQuK9o2G3P9Fx+unsN/fe jVLnt3zz3nLSH24qa/it0vU+ADMMYGZCSXavz0rJrIy0F7yYgaqt9/JSOcstr1ieXAJr GS98qQk9bkyO95plVwBZYd+3KNoFOwBHaXh8HlpC1tjKGTodbzOALw1YiBhWqGPooDn0 I2TjNdYoZh/TKsLvPHXgtTwi1CdSilNBKUSiM44oSGVIcsTLj2VsPkRPnUGe7WhQnF8e dRbPq50GJIlXns9WET68TOYXPqPJLZvavyA+UZsGzKsS5KD4toBj1ivuJSLPCPvLtloT 5tdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5kPXeqc63XovMpnzawA98htukZjbFE4T2x6goLtpsxw=; b=MGQ+kAW0BlmikiEJ0D8UGyavKiDD86ZGbfTWOnOkHIFsBGrO7EpDUcYRAql/fFQS5g r/cWONT3V3hcFzGhcofdf6B7piqnDN9sXs2Hmb7tD1O/mbEYWE/OCw1Sx5aujjt0Yzkg iQuivc95DW5DF+GO8QIZKE7pCWhjqP+x4PHvKsOkfOt5vbOctAeRs8Juexv66rvkHIt7 DYQoH/kSs3/uZz2uZVod38MINbYW0yqZEDmHjhPIghXHt2P4ok++0J3tY4urnCRVMSyT NwmkDsmyCivcnvws5fi7ctwcMbcSoixy9a1qURFxoMPFVebGEdAFmN3xnkaPPQFzfbYI rFzQ== X-Gm-Message-State: APjAAAWrA0bGRdpwt31tfS4CCByPlMl8N/9VUL3kXxQQtzh4+npzoMvE QQbREvrD9Hmu8wPwR8yotEULsa8deTg= X-Google-Smtp-Source: APXvYqz6MtH4oR+wgINAqBW3lk3Y7v8wD6o5Ak75S1vln0D0C/58SZEDm6TnjrzNjoyus4NikPUoWg== X-Received: by 2002:a1c:a404:: with SMTP id n4mr29520253wme.135.1574095841785; Mon, 18 Nov 2019 08:50:41 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w81sm22798114wmg.5.2019.11.18.08.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 08:50:40 -0800 (PST) Date: Mon, 18 Nov 2019 16:50:39 +0000 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com Subject: Re: [edk2-platforms][PATCH 3/8] Silicon/Broadcom: Add Bcm2711 header Message-ID: <20191118165039.GR7323@bivouac.eciton.net> References: <20191114160740.10072-1-pete@akeo.ie> <20191114160740.10072-4-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191114160740.10072-4-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 14, 2019 at 04:07:35PM +0000, Pete Batard wrote: > Bcm2711 is the SoC used by the Raspberry Pi 4. For the most part it > is backward compatible with the Bcm283x SoC used by older models but > some new Bcm2711 registers have been introduced such as the ones for > PCIe. > > We therefore introduce a new Bcm27xx module, which contains only the > base address for the new registers for now (set from a PCD as is the > case for Bcm283x) but which should get populated further as we add > support for the Raspberry Pi 4. > > Signed-off-by: Pete Batard > --- > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 22 ++++++++++++++++++++ > Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 15 +++++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec b/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec > new file mode 100644 > index 000000000000..815302f6d209 > --- /dev/null > +++ b/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec > @@ -0,0 +1,22 @@ > +## @file > +# > +# Copyright (c) 2019, Pete Batard > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x0001001A > + PACKAGE_NAME = Bcm27xxPkg > + PACKAGE_GUID = D4B585C5-EBCA-4779-B974-05A3CF2F10C4 > + PACKAGE_VERSION = 1.0 > + > +[Includes] > + Include > + > +[Guids] > + gBcm27xxTokenSpaceGuid = {0x44045e56, 0x7056, 0x4be6, {0x88, 0xc0, 0x49, 0x0c, 0x67, 0x90, 0x2f, 0xba}} > + > +[PcdsFixedAtBuild.common] > + gBcm27xxTokenSpaceGuid.PcdBcm27xxRegistersAddress|0x0|UINT32|0x00000001 > diff --git a/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h > new file mode 100644 > index 000000000000..389667714214 > --- /dev/null > +++ b/Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h > @@ -0,0 +1,15 @@ > +/** @file > + * > + * Copyright (c) 2019, Pete Batard . > + * > + * SPDX-License-Identifier: BSD-2-Clause-Patent > + * > + **/ > + > +#ifndef __BCM2711_H__ > +#define __BCM2711_H__ Nit: Could you drop leading __ for macros? With that: Reviewed-by: Leif Lindholm / Leif > + > +#define BCM2711_SOC_REGISTERS (FixedPcdGet64 (PcdBcm27xxRegistersAddress)) > +#define BCM2711_SOC_REGISTER_LENGTH 0x02000000 > + > +#endif /*__BCM2711_H__ */ > -- > 2.21.0.windows.1 >