From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.8934.1574099519930887565 for ; Mon, 18 Nov 2019 09:52:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=DkFzFQFs; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id q70so215619wme.1 for ; Mon, 18 Nov 2019 09:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BPXZzEOlp7g4U7pbfwfDV1o9dexnpSWvvYwzpylnISw=; b=DkFzFQFs/r59tt0UHSJjLb10UY9gXR8a7a3EY9F9L/rsrt3+2rIiWowcR9bPIeq+WZ cHwUqzvn/9ooeompCG0nQUn9A5tkKZTiseHw6UBGTCX5liUTrUjpisoIYEqy7eHf5g0Z 3s89+773SJSl2n2xvY5rBbjS9cRhB7gvH3Oh2DU1Lws6zc/ZppZ/wHvXCaGuN/v7evzv pDWttkt8LUxfluJqxPCxmE+ShrkFuQac+kWJiiHPa8re/f83+SvEDBzv5+f32xgRXEvp nYyUs2y5xRaV7rhX76KtbX6mj3KPirQC0tyMz0GgalTz7bqm4Cw8YjPX4/zXHVGgpGa/ vQFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BPXZzEOlp7g4U7pbfwfDV1o9dexnpSWvvYwzpylnISw=; b=G1m0+HcIo9b2qQ+ZI/P8Dh3v+gpJpVKsY71FLdccxtN1vUPPFE/yf7fSmcsQPKCiSz Lr4bY+xvvW5t3QgzKwDLdQDFlsx4OZ/Ra0qDBvWOItJF5iDEm9n7IANP+cOQ+V9du0rk g7xoMj5J7oo2FpN2tVk6Ds/G6yzFzIrVAooayr2skaJgVmXsOUePNDKUb5xKhxNmtCsa f4x4ySVW7kUUqLX6E08njcnLZNWkxMlo/qVbVtCLQn+IxFZn7HJJcQsShf6SFs92SI+u 98b4MiQrr0zSb+xa59a5jrSpaqLBb9Qjjlm9SLHts7e+B0Hitl8FcOcEX8iTVapzPWNX Y3jw== X-Gm-Message-State: APjAAAWwsvsnRQju3vloH8KljGPl/jHs3X8PLUZAe2IIpI4oV3q6Gae8 1lOD5ENKSK08Sy8t1c2/qOsiKw== X-Google-Smtp-Source: APXvYqzUIF479RLHz/uyKTPYDr5lefbVwCM6TAcrRW5v4aI3Y3QNOVxSqG2PrkS7tQdhT0G/nGFZiw== X-Received: by 2002:a1c:a556:: with SMTP id o83mr237543wme.165.1574099518464; Mon, 18 Nov 2019 09:51:58 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a5sm23380094wrv.56.2019.11.18.09.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 09:51:57 -0800 (PST) Date: Mon, 18 Nov 2019 17:51:56 +0000 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com Subject: Re: [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection Message-ID: <20191118175156.GX7323@bivouac.eciton.net> References: <20191114160740.10072-1-pete@akeo.ie> <20191114160740.10072-2-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191114160740.10072-2-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 14, 2019 at 04:07:33PM +0000, Pete Batard wrote: > From: Samer El-Haj-Mahmoud > > Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. > > This uses the board revision to return a numeric value representing > the RPi family (1=RPi, 2=RPi2, 3=RPi3 and 4=RPi4). > > Knowing the Pi family will help us set the SD card routing when we > introduce support for the Pi 4 and should also be easier to maintain > than if using individual model detection. > > Also add a missing entry for the "Raspberry Pi Compute Module 3+" in > RpiFirmwareGetModelName (). Can you drop the above line and include the below as 1/? in v2? / Leif >>From 59f01ff36ac7918e9ce166acbd3e963f638ab4b1 Mon Sep 17 00:00:00 2001 From: Samer El-Haj-Mahmoud Date: Mon, 18 Nov 2019 17:47:06 +0000 Subject: [PATCH edk2-platforms 1/1] Platform/RPi: Add missing model name add a missing entry for the "Raspberry Pi Compute Module 3+" in RpiFirmwareGetModelName (). Signed-off-by: Leif Lindholm --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c index 9b4aa068857c..dcb434fabefe 100644 --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c @@ -1,5 +1,6 @@ /** @file * + * Copyright (c) 2019, ARM Limited. All rights reserved. * Copyright (c) 2017-2018, Andrei Warkentin * Copyright (c) 2016, Linaro, Ltd. All rights reserved. * @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( return "Raspberry Pi 3 Model B+"; case 0x0E: return "Raspberry Pi 3 Model A+"; + case 0x10: + return "Raspberry Pi Compute Module 3+"; case 0x11: return "Raspberry Pi 4 Model B"; default: -- 2.20.1