From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.9118.1574100325071136872 for ; Mon, 18 Nov 2019 10:05:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vvCvGFTi; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id f2so20642131wrs.11 for ; Mon, 18 Nov 2019 10:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VbGtNKcwZh3QPOqBpl6SQU+0Ze+n/3I3QDHckadNiF4=; b=vvCvGFTixSSRETKQzoiy4c1LMneT1p1RTy3vDTz+9BHtLWSQycjYPEvlR00dmylfDZ ktXP3SRHi8bs70NglRy6QZtM5goaNvnE6S8PQnhm7h9PYOLDdSrljFfMxzR6kdPOudxf RgJ+KqIWyuxmB4eghGR2WTsCkigF7XBRU32aJn8JCM9+QxUmC0jVbecmnp9ZF2GHCG1a cFzG8T9+3kP5DP5AkIVz2pAs+LJiOL2RoCF/olvqcxVlzoWm2F+LcbN4ut3VINNQ6ngR R7qGLupzikPzeieypyIn5clWtnknpPEqqYx/KuTLgdG9XaFtUVGwhk7/5XWAyWH7Czey C1cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VbGtNKcwZh3QPOqBpl6SQU+0Ze+n/3I3QDHckadNiF4=; b=Zt/H4P2Fv/SFjLUZIfLHZoMgGBEBJfnujrl4M3UhdNjhab47qZMJPCupR3PLMdZoLX 43TiEGA4MFjMms3dd6f6H3Dt/0ZPCe9uvIOpQ4IpUIDRrexRpX9V677JNhmfdEc+AF92 E/M4RVjUmNTBLGboNZ8wtyQg/k3+bBDdrisWvrjbIMgcmBknq2M/tf4nwK377PLMGE+N DKHnfofXfbQaLfEWYNLV49asATyxzimgm/40BxmnCWnTGrZA0165XHCp7P7uisiAARxs VqIocn07Ij3UOS/L9I4TKbfyd44y6itzOMbu4MI9ZDvlfcxprtSe0+UjGXl4xditx6N1 oRvg== X-Gm-Message-State: APjAAAX/G12sYCxMJqmk4q7eXJ5UmlPxUGOQviH3VeWCThMeZol2KrcD XXC1DmmtKt34mOcSzAEcA6/8ZQ== X-Google-Smtp-Source: APXvYqyhIFgbY1m1RieAdyrSBQdjWLZ9R7LCtxEvTLOmJTQ58oC47FSCnEQ0uPcNkgiOvMBeTNYuVA== X-Received: by 2002:adf:e78c:: with SMTP id n12mr29616837wrm.94.1574100323487; Mon, 18 Nov 2019 10:05:23 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o81sm140041wmb.38.2019.11.18.10.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 10:05:22 -0800 (PST) Date: Mon, 18 Nov 2019 18:05:21 +0000 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com Subject: Re: [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection Message-ID: <20191118180521.GY7323@bivouac.eciton.net> References: <20191114160740.10072-1-pete@akeo.ie> <20191114160740.10072-2-pete@akeo.ie> <20191118175156.GX7323@bivouac.eciton.net> <99b30bf5-a9c6-62aa-f7e2-7db9c2bc9848@akeo.ie> MIME-Version: 1.0 In-Reply-To: <99b30bf5-a9c6-62aa-f7e2-7db9c2bc9848@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 05:58:05PM +0000, Pete Batard wrote: > On 2019.11.18 17:51, Leif Lindholm wrote: > > On Thu, Nov 14, 2019 at 04:07:33PM +0000, Pete Batard wrote: > > > From: Samer El-Haj-Mahmoud > > > > > > Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. > > > > > > This uses the board revision to return a numeric value representing > > > the RPi family (1=RPi, 2=RPi2, 3=RPi3 and 4=RPi4). > > > > > > Knowing the Pi family will help us set the SD card routing when we > > > introduce support for the Pi 4 and should also be easier to maintain > > > than if using individual model detection. > > > > > > Also add a missing entry for the "Raspberry Pi Compute Module 3+" in > > > RpiFirmwareGetModelName (). > > > > Can you drop the above line and include the below as 1/? in v2? > > Okay. > > Note that since you requested alphabetical for PCDs, I'm going to have an > "Also" in 2/ (now 3/) since the existing PCDs in > Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf are out of > alphabetical order. Actually, I try to never request reordering of existing lines, so I would be quite happy for you to skip the changes that would motivate the use of the "also". I tend to apply a rule of trying to insert *new* (or moved) lines in a way that will improve the existing order - or in messy cases at least not make it worse. I have had it pointed out to me that this is maybe not entirely obvious... Regards, Leif > I sure hope you're not going to ask me to split this extra reordering into a > separate commit... > > Regards, > > /Pete > > > > > / > > Leif > > > > From 59f01ff36ac7918e9ce166acbd3e963f638ab4b1 Mon Sep 17 00:00:00 2001 > > From: Samer El-Haj-Mahmoud > > Date: Mon, 18 Nov 2019 17:47:06 +0000 > > Subject: [PATCH edk2-platforms 1/1] Platform/RPi: Add missing model name > > > > add a missing entry for the "Raspberry Pi Compute Module 3+" in > > RpiFirmwareGetModelName (). > > > > Signed-off-by: Leif Lindholm > > --- > > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > > index 9b4aa068857c..dcb434fabefe 100644 > > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > > @@ -1,5 +1,6 @@ > > /** @file > > * > > + * Copyright (c) 2019, ARM Limited. All rights reserved. > > * Copyright (c) 2017-2018, Andrei Warkentin > > * Copyright (c) 2016, Linaro, Ltd. All rights reserved. > > * > > @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( > > return "Raspberry Pi 3 Model B+"; > > case 0x0E: > > return "Raspberry Pi 3 Model A+"; > > + case 0x10: > > + return "Raspberry Pi Compute Module 3+"; > > case 0x11: > > return "Raspberry Pi 4 Model B"; > > default: > > >