From: "Steven Shi" <steven.shi@intel.com>
To: devel@edk2.groups.io
Cc: liming.gao@intel.com, bob.c.feng@intel.com, "Shi,
Steven" <steven.shi@intel.com>
Subject: [PATCH 2/4] BaseTools: enhance the CacheCopyFile method arg names
Date: Tue, 19 Nov 2019 17:26:59 +0800 [thread overview]
Message-ID: <20191119092701.22988-3-steven.shi@intel.com> (raw)
In-Reply-To: <20191119092701.22988-1-steven.shi@intel.com>
From: "Shi, Steven" <steven.shi@intel.com>
Enhance the CacheCopyFile method arg names to be more
clear and readable
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Steven Shi <steven.shi@intel.com>
---
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
index be87e58f58..d2c23eed6d 100755
--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
@@ -1633,9 +1633,9 @@ class ModuleAutoGen(AutoGen):
self.IsAsBuiltInfCreated = True
- def CacheCopyFile(self, OriginDir, CopyDir, File):
- sub_dir = os.path.relpath(File, CopyDir)
- destination_file = os.path.join(OriginDir, sub_dir)
+ def CacheCopyFile(self, DestDir, SourceDir, File):
+ sub_dir = os.path.relpath(File, SourceDir)
+ destination_file = os.path.join(DestDir, sub_dir)
destination_dir = os.path.dirname(destination_file)
CreateDirectory(destination_dir)
try:
--
2.16.1.windows.4
next prev parent reply other threads:[~2019-11-19 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 9:26 [PATCH 0/4] BaseTools: Leverage compiler output dependency files for binary cache Steven Shi
2019-11-19 9:26 ` [PATCH 1/4] BaseTools: store more complete output files in " Steven Shi
2019-11-19 9:26 ` Steven Shi [this message]
2019-11-19 9:27 ` [PATCH 3/4] BaseTools: Leverage compiler output to optimize " Steven Shi
2019-11-19 9:27 ` [PATCH 4/4] BaseTools: Remove redundant binary cache file Steven Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119092701.22988-3-steven.shi@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox