From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.10511.1574165652799059790 for ; Tue, 19 Nov 2019 04:14:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=OrQDb/Hk; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id z19so3306408wmk.3 for ; Tue, 19 Nov 2019 04:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=T4xtjorbPa6voodVu39bi799Knl5D6Zd9ssKHMMUMcQ=; b=OrQDb/Hkfoz5euYJ1RnEAkwXdJH99CDqOHthDproPApLu8ClGyM/NOXD9X2RF3z7Uq Y5rgZDtJ9A8xQmggTTEO4oCXhrOx2PF1tdincI/gRBGFuwOIRZN4EpEkBgFx+d0EXePm /Nnqe+qANBrurZiV1bpS3KdEDrHf6GugVTA7AkbVRNCiAD1ml4VVfjKbvMbrRpJd46I9 g++J2KLarbglB49WggIMHgJ9wGNAEep2YTI19gVVtwjbdWENcmYvUnkkDO2gnepp6IoD D00Vqzl7ACfHwKHqrCve+78Dek0WWEJBPKeFaaB5I+BqHH36j611gfEqpgCsYQ12kk0u RCow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=T4xtjorbPa6voodVu39bi799Knl5D6Zd9ssKHMMUMcQ=; b=oZm4AjwIwf8A2jjpsA3Zw8RniYZj4+dFw/XYiT/cQomS9tg6YPxbnQP5psM/HUZQl1 UeqaOwsWAVNXAENBzrXK7oOsuA9zOpXJ4cu/9fVyELklrWX378MkcRv8xabWhyT2vDzi 1ic5uPf830LNhkuWHu8W56f8KbjbZ5KlHeMYXcdmKc/oTgZqVE9lhNZnqGCDvF1FhEhV a+8dOTExPxPZstk42WZrv4p5HgylLz9Ggf0vyN+gUP545rl98JgCCJHSlLROEzDYNzcr p+YoVMDhwuawCg/bnWIjBSI4df13NVH4thgRtgZ1oIqU/7GACEjA7UuOgo4XMHVObeDF LQew== X-Gm-Message-State: APjAAAXvwfDnozs+dz+A34Ff4BV5BWM4WmcxGAnr8QeaqqaGweLP3o5z p6nTJfXFjQy+cWiTk70hLroxVTnPPSk= X-Google-Smtp-Source: APXvYqzV2rV6ufm5b/XmUYHlRiED+EewOKwpjUqfzBeqkMZS5z9BSMYx9F4Tcs7ZAtfrz9pFBe5Waw== X-Received: by 2002:a1c:6a0d:: with SMTP id f13mr5459137wmc.164.1574165650717; Tue, 19 Nov 2019 04:14:10 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f13sm26393244wrq.96.2019.11.19.04.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 04:14:09 -0800 (PST) Date: Tue, 19 Nov 2019 12:14:08 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, philmd@redhat.com Cc: Pete Batard , ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/RPi: Add missing model name Message-ID: <20191119121408.GA7323@bivouac.eciton.net> References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-2-pete@akeo.ie> <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> MIME-Version: 1.0 In-Reply-To: <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Nov 19, 2019 at 01:02:20PM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 12:38 PM, Pete Batard wrote: > > From: Samer El-Haj-Mahmoud > > > > Add a missing entry for the "Raspberry Pi Compute Module 3+" in > > RpiFirmwareGetModelName (). > > > > Signed-off-by: Leif Lindholm > > I feel really lost with how the S-o-b are handled. Signed-off-by, as per https://developercertificate.org/, starts off with "By making a contribution to this project, I certify that:". That is only a valid statement at the point of contributing code to a project. It is also only a valid statement when given by the person contributing it. Samer has authored this code, but he has not contributed it. My own litmus test is the legal usefulness of the statament "Samer said he signed the contract.". > I'd have expected, Samer as the author, signs it. Pete forwards it, then > Leif refactors a bit by extracting a part of the previous bigger patch. > So: > > Signed-off-by: Samer El-Haj-Mahmoud > Signed-off-by: Pete Batard > Signed-off-by: Leif Lindholm What might be confusing you is where a set is collaboratively developed, or where multiple patch sets are smashed together to be merged atomically; when someone other than the poster has previously contributed a given patch to the project but it is being *reposted* by someone else to the same project, it is customary to include the original Signed-off-by, since it still applies. Similarly, when non-trivial changes are made by a maintainer (or whoever reposted the patches), the maintainer *should* add their own S-o-b - something that is usually done after a line briefly explaining [which changes were done] . (You will however find that different maintainers have different opinion of what constitutes "trivial".) / Leif