From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.20577.1574167478411400552 for ; Tue, 19 Nov 2019 04:44:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=PHGdsjpk; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id z26so3022458wmi.4 for ; Tue, 19 Nov 2019 04:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4uzgrS96taSCLHATh4MmQstRRCp98fWZdS7qeAZ1EdE=; b=PHGdsjpk/WyTlCLV79nVEJEKFn2j+U1m6CIl6AoVsaHmgOA8EE7dS09yhu8dBBLxJG BMo1yvCSDf97X53O6rHgbVq9DNRqA78svgfdjz398snW7O8vpOkuSFbIO66VnsNFDPdJ CWGmZViC55igncgAf9iW6Gvnhfmx6l8pkjiRBRMbUZHw2g+n1/e4vdUyB/jLWLVRarqf NXDyV4VHlYGLrVXmQK3td8qmPu8wZ1U5T5ZbGtCWQHDkPXg/Qc/g9h5gHhE58sAjZO2/ MQrlPM6rQ+hryUcpG5+tZ7ZeSitoZaclQfp65lVMqU2XTpemdRu5d0xl+XBStYtGW5aK /Kjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4uzgrS96taSCLHATh4MmQstRRCp98fWZdS7qeAZ1EdE=; b=ObKsCDmL1aUQX8gys/LRGzm4EFkyqC3vfDLjZN/9zHBKe9UapENb91yTC9JG6eMh36 8H7wXBcfxspNjkD5LgdLCRm/hFHzr4GFjMqW4FpmjbbZYgCCwBxl7OpocKKXpAPu3ldk R2IGeDdMe5dynC+FeI9ZjyPt1zdgA11gpX9be+Mwy9l56fmRI45FUlrxHZVLNUjdLeyf 4gFv9+TYwLSHYVE1JbYC7d6PhATas1YKLggC4a1vCcy05YsrO578FY8uKrNh4LO+BVo7 rHHxN3hzy2E+Ed52Esz5CVoUxQWi+2IRieAmJ7gU28TrveV3DxLOZcD0dhSQHPinv5/C nZmg== X-Gm-Message-State: APjAAAXoRS439mEHKG4i0UaOTgyzgDUcdASCZlW5x1/Mlfa3Yvb9I/Nt OnNIlE1CMirbk/dt+/nZwlHzTQ== X-Google-Smtp-Source: APXvYqzb7Jm34GxUJkl04d2puvlMTeV/wE72X9rJ/rv/ul3AOxa9x2SLvqinQYD6m1Y5tKNIeanPWg== X-Received: by 2002:a05:600c:2919:: with SMTP id i25mr5359030wmd.158.1574167476719; Tue, 19 Nov 2019 04:44:36 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l4sm2923395wme.4.2019.11.19.04.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 04:44:35 -0800 (PST) Date: Tue, 19 Nov 2019 12:44:34 +0000 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, Pete Batard , ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com, Laszlo Ersek Subject: Re: [edk2-platforms][PATCH v2 3/7] Platform/RPi: Replace Bcm283x SoC base register address with a PCD Message-ID: <20191119124434.GB7323@bivouac.eciton.net> References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-4-pete@akeo.ie> <092d22cc-cd21-61ad-0317-3b2a3fc6c2cf@redhat.com> <1ae9ef75-aecb-e71c-c1b5-ce9f5d99c5a0@akeo.ie> <87a12ccb-0441-72dd-875f-840b0a2a2861@redhat.com> MIME-Version: 1.0 In-Reply-To: <87a12ccb-0441-72dd-875f-840b0a2a2861@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Nov 19, 2019 at 01:16:28PM +0100, Philippe Mathieu-Daudé wrote: > > As per Leif's comments in > > https://www.mail-archive.com/devel@edk2.groups.io/msg05292.html: > > > > "I don't want patches submitted with anyone other than the > > contributor's Signed-off-by" > > I missed this thread, now I'm slightly confused. > > Checking the Wiki: > > https://github.com/tianocore/edk2/blob/master/Readme.md#code-contributions > > and: > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Signature-Format#signed-off-by > > Signed-off-by > > Authors should use Signed-off-by (See example below) > If you've received the code from a trusted source, and are > forwarding it along, please add a Signed-off-by line for > yourself to indicate that you know this code to be usable > by our community. > > The guideline is simply "add a S-o-b", but Leif says "[only?] No. Whoever contributes the patch must add an S-o-b. And contracts are signed in one's own name. This is not a TianoCore twitch, this is the fundamental way in which DCO works in all projects that use it - including linux and QEMU. https://wiki.qemu.org/Contribute/SubmitAPatch: * You must provide a Signed-off-by: line (this is a hard requirement because it's how you say "I'm legally okay to contribute this and happy for it to go into QEMU" which is based on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.4-rc8#n418 The confusing bit I find here is in https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line with its statement of "but again, that author's Signed-off-by: line is mandatory,", in direct conflict with the text at the top of the page *if* the patch was not one already contributed to QEMU. / Leif > If patches are > modified after contribution, but before being pushed, then then additional > contributions can be reflected with additional Signed-off-bys." and then "I > don't want patches submitted with anyone other than the contributor's > Signed-off-by:". > > Leif, can we clarify and update the documentation accordingly? > > Sorry to be picky, but that would clear any confusion.