From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com []) by mx.groups.io with SMTP id smtpd.web10.21388.1574326763463229475 for ; Thu, 21 Nov 2019 00:59:24 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 00:59:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="210033043" Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga006.jf.intel.com with ESMTP; 21 Nov 2019 00:59:20 -0800 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Michael Kubacki , Sai Chaganty Subject: [edk2-platforms] [PATCH V2 01/14] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Date: Thu, 21 Nov 2019 00:58:40 -0800 Message-Id: <20191121085853.2626-2-nathaniel.l.desimone@intel.com> X-Mailer: git-send-email 2.24.0.windows.2 In-Reply-To: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This library contains PEI phase only code. For example, ClearIchSmiAndWake() calls PeiServicesGetBootMode(). Accordingly, this library should have never been marked as a BASE library. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../PeiSiliconInitLib.inf} | 5 +++-- .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c | 0 .../SiliconInitPreMem.c | 0 3 files changed, 3 insertions(+), 2 deletions(-) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconIni= tLib.inf =3D> PeiSiliconInitLib/PeiSiliconInitLib.inf} (86%) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> PeiSi= liconInitLib}/SiliconInit.c (100%) rename Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> PeiSi= liconInitLib}/SiliconInitPreMem.c (100%) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silico= nInitLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/P= eiSiliconInitLib.inf similarity index 86% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= InitLib.inf rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSil= iconInitLib.inf index 132080e876..bd77b081e5 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLi= b.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSilicon= InitLib.inf @@ -11,8 +11,9 @@ BASE_NAME =3D SiliconInitLib=0D FILE_GUID =3D 72CD3A7B-FEA5-4F5E-9165-4DD12187BB13= =0D VERSION_STRING =3D 1.0=0D - MODULE_TYPE =3D BASE=0D - LIBRARY_CLASS =3D SiliconInitLib=0D + MODULE_TYPE =3D PEIM=0D + LIBRARY_CLASS =3D SiliconInitLib|SEC PEIM=0D +=0D #=0D # The following information is for reference only and not required by the = build tools.=0D #=0D diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silico= nInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silico= nInit.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= Init.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silico= nInit.c diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silico= nInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/= SiliconInitPreMem.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= InitPreMem.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silico= nInitPreMem.c --=20 2.24.0.windows.2