Re: [edk2-devel] [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

["Leif Lindholm" <leif.lindholm@linaro.org>]

Hi Zhiguang,

A couple of comments.

On Wed, Nov 20, 2019 at 02:34:43PM +0800, Zhiguang Liu wrote:
> After unifying the definition of size_t, EBC compiler has failure.
> So don't compile this inf file for EBC
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +-
>  MdeModulePkg/MdeModulePkg.dsc                                            | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> index 42b741c64b..e8061f54f9 100644
> --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> @@ -25,7 +25,7 @@
>  #
>  # The following information is for reference only and not required by the build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 EBC
> +#  VALID_ARCHITECTURES           = IA32 X64

If updating this line, we may as well add the missing architectures:
AARCH64 and ARM.

>  #
>  
>  [Sources]
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 4320839abf..f7dbb27ce2 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -299,7 +299,6 @@
>    MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
>    MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
>    MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf
> -  MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>    MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>    MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
>    MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -433,6 +432,7 @@
>  
>  [Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
>    MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> +  MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf

I agree this solves the current problem, but then becomes something we
need to come back and fix for RISC-V (32 and 64) anyway.

Although I guess that applies to this whole section already...
And this antipattern repeats in NetworkPkg/Network.dsc.inc and
SecurityPkg/SecurityPkg.dsc.

I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=2370 for
this latent issue. But I'm OK for this patch to go in as is (although
preferably with updated VALID_ARCHITECTURES) after stable tag.

Best Regards,

Leif

>    MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
>    MdeModulePkg/Core/Dxe/DxeMain.inf {
>      <LibraryClasses>
> -- 
> 2.16.2.windows.1
> 
> 
> 
>