From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.22379.1574334362342218812 for ; Thu, 21 Nov 2019 03:06:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=aeEHkQrz; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id f129so1834713wmf.2 for ; Thu, 21 Nov 2019 03:06:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GXWQwnB+nfiwFAhX6UPZgV5Ozrtpankqf6fGXRa4hdE=; b=aeEHkQrz46uSL0ruWP4BBUTJnP9Dm5Umf+ewPgW6zQBxWNm39NG57bZlnWyUjrLlnV wDwn6psJsjiyPhGlZ+FM6FBcEV6Q1dTYqr7QMlq56nm1Es+z2N3dEMlMvUaA8RXb+GsQ c48057hk3eXxE0gyttg5SEfM7mkeJuOOFGCzoTRa7PyUNvinIfHXwn/rTeAxjT0MAtDg 91Gv7uxRjWmhFnR9kX9bSqUtlqMd/e8F3zNlosTp97JZBHUDn2QdaWeqBQC71S0c/0eZ iVsbogc0zhKTF55byN9q1/3qAKYPRpZAyRiOWhtk1pO2DFpPow3DWNHh3/QJeb+dSSiI buuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GXWQwnB+nfiwFAhX6UPZgV5Ozrtpankqf6fGXRa4hdE=; b=Sw9mnb/uB9UvDZSaKC1BnAMjL6jbwX2le2zHYs0v/h5NR3ayzuKB3SvbtLrlWDKRJQ TQk9tbt3/jm0l8RtdQCuA7tja2s3efGIMVrLU3wwvlYAA4XQLfB8fQKaCakWWHrz9fA5 anlzIhn7Hdm5ssdvrPCGlQJ8cxi/KQ82WbrFuquSdsHNU29HL2+PH8Pp17OsY8XvYPZv 7ZqicVPP15rVHFRh5dGcbdUM3bvxV35AqATlQIrKJnofzMiKX3iHbo6EG6kQTJICKIsB SFo58mqaKW/5AOAdmF+6pLPCoOK77YYKT0HVzXDIqTVKy3he/FAqrhXtiRDym2Z3q//J Wm0A== X-Gm-Message-State: APjAAAXrxgv0+Nq4HofeyBVyfoEiae3XK+X6Zp5/RJ/GD4pMDqEemPKL p4MFpcj2xR5pjLVAH1gjvsABjbxI5iI= X-Google-Smtp-Source: APXvYqygbH8tG6y0kvjELf12t7/zj2+Vsnms9orGV69vKiRY+OcZF+ic7FagomRrPM/1sFZOKcoIqg== X-Received: by 2002:a05:600c:23ce:: with SMTP id p14mr9204282wmb.176.1574334360445; Thu, 21 Nov 2019 03:06:00 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d67sm2461086wmd.13.2019.11.21.03.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 03:05:59 -0800 (PST) Date: Thu, 21 Nov 2019 11:05:58 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, zhiguang.liu@intel.com Cc: Liming Gao , Jian J Wang , Hao A Wu Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Message-ID: <20191121110558.GM7323@bivouac.eciton.net> References: <20191120063443.30604-1-zhiguang.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20191120063443.30604-1-zhiguang.liu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Zhiguang, A couple of comments. On Wed, Nov 20, 2019 at 02:34:43PM +0800, Zhiguang Liu wrote: > After unifying the definition of size_t, EBC compiler has failure. > So don't compile this inf file for EBC > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338 > > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +- > MdeModulePkg/MdeModulePkg.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > index 42b741c64b..e8061f54f9 100644 > --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > @@ -25,7 +25,7 @@ > # > # The following information is for reference only and not required by the build tools. > # > -# VALID_ARCHITECTURES = IA32 X64 EBC > +# VALID_ARCHITECTURES = IA32 X64 If updating this line, we may as well add the missing architectures: AARCH64 and ARM. > # > > [Sources] > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 4320839abf..f7dbb27ce2 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -299,7 +299,6 @@ > MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf > MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf > MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf > - MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -433,6 +432,7 @@ > > [Components.IA32, Components.X64, Components.ARM, Components.AARCH64] > MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf > + MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf I agree this solves the current problem, but then becomes something we need to come back and fix for RISC-V (32 and 64) anyway. Although I guess that applies to this whole section already... And this antipattern repeats in NetworkPkg/Network.dsc.inc and SecurityPkg/SecurityPkg.dsc. I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=2370 for this latent issue. But I'm OK for this patch to go in as is (although preferably with updated VALID_ARCHITECTURES) after stable tag. Best Regards, Leif > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > MdeModulePkg/Core/Dxe/DxeMain.inf { > > -- > 2.16.2.windows.1 > > > >