From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ard.biesheuvel@linaro.org>,
<leif.lindholm@linaro.org>, <Matteo.Carlini@arm.com>,
<Laura.Moretta@arm.com>, <nd@arm.com>
Subject: [PATCH v1 2/2] ArmPlatformPkg: Fix 'missing header' warnings
Date: Thu, 21 Nov 2019 14:32:51 +0000 [thread overview]
Message-ID: <20191121143251.10204-3-sami.mujawar@arm.com> (raw)
In-Reply-To: <20191121143251.10204-1-sami.mujawar@arm.com>
The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.
Update the inf files to include the respective
header files to fix the reported warnings.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Notes:
v1:
- Fix missing header warnings [SAMI]
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 3 ++-
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf | 1 +
ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf | 3 ++-
ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf | 3 ++-
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
index 2176e5a5789f3728964b7cc286f85fb03ee88cb4..662256d5aebef20d4223ab2b582b27bade4fa76a 100644
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
@@ -2,7 +2,7 @@
#
# Component description file for LcdGraphicsOutputDxe module
#
-# Copyright (c) 2011-2012, ARM Ltd. All rights reserved.<BR>
+# Copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -18,6 +18,7 @@ [Defines]
[Sources.common]
LcdGraphicsOutputDxe.c
+ LcdGraphicsOutputDxe.h
LcdGraphicsOutputBlt.c
[Packages]
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
index 01cea6c3ab21c7b22df5afebde804e0131fa47f3..cdfaaccbff5195674db93f1bcf24754e25981435 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
@@ -17,6 +17,7 @@ [Defines]
[Sources.common]
PL061Gpio.c
+ PL061Gpio.h
[Packages]
MdePkg/MdePkg.dec
diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
index c70377bc7cfaeac1128aae3754f5c56ac8e1ca5c..864cd5958d6761a6d9d520b701dbe7da62525628 100644
--- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
@@ -1,7 +1,7 @@
#/** @file
# INF file for the MMC Host Protocol implementation for the ARM PrimeCell PL180.
#
-# Copyright (c) 2011, ARM Limited. All rights reserved.
+# Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -18,6 +18,7 @@ [Defines]
[Sources.common]
PL180Mci.c
+ PL180Mci.h
[Packages]
ArmPlatformPkg/ArmPlatformPkg.dec
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
index 048f6697e93d702c5ec878ccc827e64e583893ea..f152a59fdcd72921528f1e9993f05df0d39aac89 100644
--- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
+++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
@@ -1,6 +1,6 @@
/** @file
*
-* Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+* Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
* Copyright (c) 2018, Linaro Limited. All rights reserved.
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -17,6 +17,7 @@ [Defines]
[Sources.common]
SP805Watchdog.c
+ SP805Watchdog.h
[Packages]
ArmPkg/ArmPkg.dec
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2019-11-21 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 14:32 [PATCH v1 0/2] ArmPlatformPkg: Fix build warnings Sami Mujawar
2019-11-21 14:32 ` [PATCH v1 1/2] ArmPlatformPkg: PL061: Minor section alignment Sami Mujawar
2019-11-21 14:32 ` Sami Mujawar [this message]
2019-11-21 15:57 ` [edk2-devel] [PATCH v1 0/2] ArmPlatformPkg: Fix build warnings Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121143251.10204-3-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox