From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.25601.1574351339761914439 for ; Thu, 21 Nov 2019 07:49:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=KVfA5uBY; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id z3so5032552wru.3 for ; Thu, 21 Nov 2019 07:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3my1HMI4H2MuMGAqvocUV2YaOjcIoFVUmkm5Zkalhnw=; b=KVfA5uBYyYUC4Qbfwfeg1ykP8QvF0B78FgEtJxOL1owhikyK07FUy8rQzpee0e4cEm CY6ImRDPQiggRFUs94YmA2WBmlm266MLK616dh4kKuKAXC7AlFNzV+5e0wKZl+d8JPjk Jnv8BsCp96bOs163IBgoJrxCv5kGlkKeGqIVvyKf/4BFfEVAQ7VGsG6ro0S6yiM6Cl88 hZkjCFdrxhDyBqQrmThY4HE/YA3TJcvfWjyZPcEomhDzdgKn/pAr2usKrfYo3oeD93/X KXed6wXL2N8zuNzZvUG/NyGflZpzoMyLfokQYNfU5guUJcCt1sdBVdT1TH9kZx7KZWdI ZT+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3my1HMI4H2MuMGAqvocUV2YaOjcIoFVUmkm5Zkalhnw=; b=KYYjxLRxylI4eggklXDP/yHCUShaB33EYwoVDHFhnnZ9BZr+TXMdUlrIj5bcs2X0/V vcDqICEd54AFXVt0uzzzWDSABudVB6h4E/9j9dtOjvBgj8/+4Sn0rNqf1nX51bFF55lQ pNUJ/4L8uxF5tJf1Xd+FdaJQ72Ly8lSBZp9XNGl+IJILB7W6EPl+wIRog3BhKANSrRfX lVrR/Yqm9Ssvc5VhDJGwa9KcolqoP4rBKicot5x3UejElw2gC1R2+J83DfZ6dKQbG7rk nMGLDYRHUA2y6KuG0i21OFBwQML1X2csFSwIP2vPjA7xz3I0ktqtRohuV0hZtMv+v2JC CwTA== X-Gm-Message-State: APjAAAV4egjfcOeIFaJVi2qv6pB18nTxBOmO4TR23zvSt6URjLKjzVDU bSX8afel1dkyXaLymOVanRBKug== X-Google-Smtp-Source: APXvYqxL8wmvXRuRWu3GZbl8diTIbhwIzPyXrhNyF4wCcTC/UfsgCEWxsA8DSg3CyeWqnEK/1QRrCA== X-Received: by 2002:adf:f547:: with SMTP id j7mr11903778wrp.69.1574351338274; Thu, 21 Nov 2019 07:48:58 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p14sm3927565wrq.72.2019.11.21.07.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 07:48:57 -0800 (PST) Date: Thu, 21 Nov 2019 15:48:56 +0000 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, sami.mujawar@arm.com, Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, nd@arm.com Subject: Re: [edk2-devel] [PATCH v1 10/19] DynamicTablesPkg: Serial debug port initialisation Message-ID: <20191121154856.GI7359@bivouac.eciton.net> References: <20190823105539.13260-1-sami.mujawar@arm.com> <20190823105539.13260-11-sami.mujawar@arm.com> <20191121152320.GH7359@bivouac.eciton.net> <90d963b6-4422-cdac-ed20-61f0e2329fe3@redhat.com> MIME-Version: 1.0 In-Reply-To: <90d963b6-4422-cdac-ed20-61f0e2329fe3@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Nov 21, 2019 at 16:29:16 +0100, Philippe Mathieu-Daudé wrote: > On 11/21/19 4:23 PM, Leif Lindholm wrote: > > On Thu, Nov 21, 2019 at 16:20:31 +0100, Philippe Mathieu-Daudé wrote: > > > On 8/23/19 12:55 PM, Sami Mujawar wrote: > > > > The ARM DCC serial port subtype is an option that is > > > > supported by the DBG2 generator. However, the serial > > > > port initialisation should only be done for PL011/SBSA > > > > compatible UARTs. > > > > > > > > Add check to conditionally initialise the serial port. > > > > > > > > Signed-off-by: Sami Mujawar > > > > --- > > > > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 27 ++++++++++++-------- > > > > 1 file changed, 17 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > > > index 346ab5b22f5402bf87c385558f68f080d1b454ed..51c843d25f75388104694855ce133b3d61860196 100644 > > > > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > > > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > > > @@ -175,7 +175,7 @@ GET_OBJECT_LIST ( > > > > CM_ARM_SERIAL_PORT_INFO > > > > ); > > > > -/** Initialize the PL011 UART with the parameters obtained from > > > > +/** Initialize the PL011/SBSA UART with the parameters obtained from > > > > the Configuration Manager. > > > > > > Isn't the SBSA UART a PL011? > > > > No. It's a compatible subset. > > So a PL011 can be used as an SBSA UART. > > OK thanks. > > Can you update the comment? Maybe: > > "Initialize the PL011 compatible UART with the parameters ..." The original is correct, the suggested alternative is not (an SBSA UART is a subset, so not fully compatible). If the comment was to change, I would suggest that dropping the model name completely and simply refer to it as "the UART" would be preferable. / Leif > Regardless: > Reviewed-by: Philippe Mathieu-Daude > > > > > / > > Leif