From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.27054.1574356515618822124 for ; Thu, 21 Nov 2019 09:15:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=jN4rpKvT; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id t2so5429511wrr.1 for ; Thu, 21 Nov 2019 09:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wTYsLpe+ldYBd2J3fKfTVai+/MtfZrgLoZF/QYbqflM=; b=jN4rpKvTJwy5tvXv69KcWemSPY+8CZL+dWO9mDZ9uikGS6L/vPl3VsNmCZfvxoVSDm VK60FHn1bvXparju/RjBiwY+wi/gpauEY740NlCdcchwvKtw1eNRUnA8Rn1T7B7vSecH l+CfwzkxjFjdBtP+hHDqQRm8byD0wkNayY6NLCmwAAtKE9mfIGJsjeZgD7JkoemEIB92 Fj5WDiAvflRbajNVPasvdjtjossUTv/LNORCuy60z50JALIvgaNNubjHJnGx3+SQPmnF uDc9r6iGPrxCu0yVaWUpT0srYMTeLPVHVRoN5N7u8B2HWptZT38ZXFmTBS/S0cq1xian e/jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wTYsLpe+ldYBd2J3fKfTVai+/MtfZrgLoZF/QYbqflM=; b=nY1+sX3oHwDK6I1N7QgFIolPbdr4zq4IIEQxr3OklHfHrWY0mS0VFDDNZYYpiLomqv ho4cvEa1g9D9PynidRh/l+KMuF3YyYXTPjFog5rLNvr8GREnW7B3x8T655JJVoux8i/T Gc5dckacw3Zrq5n6UMd7FbiDAxQANRoaHWnmDeK6OGcvEmWy4WsL/Ii/1pnlwRF8IeGz oV1Bw3BIiQHQiJL41PcyYX3tC+m9Jb2dXulHLf+QBsR3lLU+PGImOXFa8b/Y7AF5MsMn s8lK1kWgHwNoqIElk8Nu9zTlMWXZT32xWOxHb0ODXRVzr6BG2DumU3d4gttQnEo4z05p Oyxw== X-Gm-Message-State: APjAAAUozkXcXdLAyjI5zRSz0OGRZijgoS1UxEco7cxtKFzNWmlZvhvQ cDnhMZvVBa7oonFXd8A1immw+43/8x0= X-Google-Smtp-Source: APXvYqzNCqmV61PFoegQlO4RTI3qspCcnFNB2STyCdOv1RCMb355h0rd4CKQLBrIxkyOSvl3pQqxRQ== X-Received: by 2002:adf:db8e:: with SMTP id u14mr3089593wri.274.1574356513846; Thu, 21 Nov 2019 09:15:13 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o187sm294827wmo.20.2019.11.21.09.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 09:15:13 -0800 (PST) Date: Thu, 21 Nov 2019 17:15:11 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Andrew Fish , Laszlo Ersek , Michael D Kinney , Gilbert Chen , Palmer Dabbelt Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md Message-ID: <20191121171511.GR7359@bivouac.eciton.net> References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-40-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1572227957-13169-40-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Well, there's no 0/39 for me to give a generic comment on (please use a cover-letter). Anything in this set I have not commented on I would consider good to go into -staging (and pretty close to be able to go into edk2 master). I have given a few comments that should be trivial to respin. I have given one comment that will not be, but it needs to happen - the include wrappers. Clearly that will have impact on other patches as well, but as long as include statements are all that changes, that does not need further review. *But*, it will mean we have compartmentalised the opensbi import, and can improve its importability upstream without having to do this work at the same time. / Leif On Mon, Oct 28, 2019 at 09:59:17 +0800, Abner Chang wrote: > Add opensbi submodule. > > Signed-off-by: Abner Chang > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Gilbert Chen > --- > Readme.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Readme.md b/Readme.md > index 27e4ce0..4b3d2a5 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules > > - CryptoPkg/Library/OpensslLib/openssl > - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi > > The latter one is actually required by previous one. It's inevitable > in openssl-1.1.1 (since stable201905) for floating point parameter > -- > 2.7.4 > > > >