From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
piwg@uefi.org, kimon.berlin@hp.com, eugene@hp.com
Subject: [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNICATE2_PROTOCOL
Date: Fri, 22 Nov 2019 09:32:28 +0100 [thread overview]
Message-ID: <20191122083234.12756-1-ard.biesheuvel@linaro.org> (raw)
As discussed in the PIWG call on 21 November, I am sending out my
implementation of the MM communicate 2 protocol for review. It is
intended to work around the impedance mismatch between traditional
SMM (which uses physical addresses in the communication between DXE
components) and standalone MM (which uses virtual addresses)
The solution presented here is to introduce a new protocol that takes
both addresses, forcing the clients to pass both, but freeing them
from the responsibility to reason about which kind of address to pass:
this becomes the responsibility of the MM_COMMUNICATE implementation,
which is where it belongs.
Cc: piwg@uefi.org
Cc: kimon.berlin@hp.com
Cc: eugene@hp.com
Ard Biesheuvel (6):
MdePkg: introduce MM communicate 2 protocol
MdeModulePkg/SmmIpl: expose MM communicate 2 protocol
ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol
MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol
MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2
protocol
MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2
protocol
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 83 +++++++++-----------
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 6 +-
MdeModulePkg/Application/VariableInfo/VariableInfo.c | 19 +++--
MdeModulePkg/Application/VariableInfo/VariableInfo.inf | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 79 +++++++++++++++++++
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 1 +
MdeModulePkg/Include/Guid/SmmVariableCommon.h | 6 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 2 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.c | 25 +++---
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.h | 2 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.inf | 4 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 39 ++++-----
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 4 +-
MdePkg/Include/Protocol/MmCommunication2.h | 69 ++++++++++++++++
MdePkg/MdePkg.dec | 7 ++
15 files changed, 254 insertions(+), 94 deletions(-)
create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h
--
2.20.1
next reply other threads:[~2019-11-22 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 8:32 Ard Biesheuvel [this message]
2019-11-22 8:32 ` [PATCH 1/6] MdePkg: introduce MM communicate 2 protocol Ard Biesheuvel
2019-11-22 8:32 ` [PATCH 2/6] MdeModulePkg/SmmIpl: expose " Ard Biesheuvel
2019-11-22 8:32 ` [PATCH 3/6] ArmPkg/MmCommunicationDxe: expose MM Communicate " Ard Biesheuvel
2019-11-22 8:32 ` [PATCH 4/6] MdeModulePkg/VariableInfo: switch to MM communicate " Ard Biesheuvel
2019-11-22 8:32 ` [PATCH 5/6] MdeModulePkg/FaultTolerantWriteSmmDxe: " Ard Biesheuvel
2019-11-22 8:32 ` [PATCH 6/6] MdeModulePkg/VariableSmmRuntimeDxe: " Ard Biesheuvel
2019-11-25 14:21 ` [edk2-devel] [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNICATE2_PROTOCOL Liming Gao
2019-11-25 14:52 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122083234.12756-1-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox