From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: devel@edk2.groups.io, Liming Gao <liming.gao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
Date: Fri, 22 Nov 2019 09:59:43 +0000 [thread overview]
Message-ID: <20191122095943.GW7359@bivouac.eciton.net> (raw)
In-Reply-To: <20191122080726.36584-1-zhiguang.liu@intel.com>
On Fri, Nov 22, 2019 at 16:07:26 +0800, Zhiguang Liu wrote:
> V1:
>
> After unifying the definition of size_t, EBC compiler has failure.
> So don't compile this inf file for EBC
>
> V2:
>
> Thanks for Leif's comment
> Updated VALID_ARCHITECTURES in inf file
Please remove the versioning information from the commit message -
such infofmation goes below ---. The part that is in the V1 section
(minus the "V1:" bit) is a sufficient commit message - please keep
only that.
With that
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +-
> MdeModulePkg/MdeModulePkg.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> index 42b741c64b..4ed1d83a40 100644
> --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> @@ -25,7 +25,7 @@
> #
> # The following information is for reference only and not required by the build tools.
> #
> -# VALID_ARCHITECTURES = IA32 X64 EBC
> +# VALID_ARCHITECTURES = IA32 X64 AARCH64 ARM
> #
>
> [Sources]
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 4320839abf..f7dbb27ce2 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -299,7 +299,6 @@
> MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
> MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
> MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf
> - MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -433,6 +432,7 @@
>
> [Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
> MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> + MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> --
> 2.16.2.windows.1
>
next prev parent reply other threads:[~2019-11-22 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 8:07 [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
2019-11-22 9:59 ` Leif Lindholm [this message]
2019-11-22 11:30 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-22 11:34 ` Leif Lindholm
2019-11-25 1:29 ` Zhiguang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122095943.GW7359@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox