From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.4546.1574416786969778720 for ; Fri, 22 Nov 2019 01:59:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=BANjTfWL; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id n188so4934993wme.1 for ; Fri, 22 Nov 2019 01:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bt/WMDljeCKDcboSvjY6XedlDoKtEK0vGslxCtBtU5s=; b=BANjTfWL7DYEU9TjRHD8XEow6WlVMkzrgETmMM2F+0UeUPJ8ZG7xSU2vDzukokg4LV ZhLuG6B+0KbnQ+EAxvXGKAxlBH7Zvjb0sEyP8e+jl8jCewqJ6LwO448ASOYfkmLnwqfh cNqm6WtF03mgG1skL0CrMrObay7XM3ybM4YoDAyaT35Fre5U/gtzC5OJzsEWjPvLTxHj e2fO4/xAPH+hOQtuO8XfdNpg6K6f/runn6X6eQK3/2LmECP6VIZjBJf/8wpEw+9Ah2w6 JJnMKj0Y/LPboCYMujRAwVnLnfC9y2BTTD0TDfAuaL1Y7r4oTW566LQrOLzrUppfAwtS SaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bt/WMDljeCKDcboSvjY6XedlDoKtEK0vGslxCtBtU5s=; b=ojA2eX9pADM6B868BjSlUH+6ujhsXXqVMz8ClwPIspSwocXpQ0XUN0wZQ6uG8Oy1zu gD2AkSyZfRhmrX5nRc8uRfp0rBJ0Eio6VDATzsGJ5NfKiRKH/AfiKtUWwsVx21vZ7uG1 hzDWvlAuf5PvC4ZSB/0jGlmgU5+DXPReQ4Wnj4BMG0JbnZX+GFF+ubdMwgEDhRL5DYct pDGAmZxqHfag82/GwR6EeXhByfPzXUa0CdwUutDRv9i4LR1W3RNEIbZjZf6NZnj31zrn n5awmvAp/ArytoiEYrZU4tsv7y+V+6AECJ1fwNX4zyP71cJp7WJFLKnRe4KijpscU6+R TFfw== X-Gm-Message-State: APjAAAXljd7Abkiz2oj7ABSStoiimgbB/js3HLlh8E+KhV5vdahHjOTE L6c1peUBwSwSZ9P+3nLGT1oN5g== X-Google-Smtp-Source: APXvYqwOUYE8CqfMeNneW8uFcHOOUfYVR/1EwI8W+OTnwxQ30SS0/lNPZ4jQPFBmYPBVLQt8d247dg== X-Received: by 2002:a05:600c:20e:: with SMTP id 14mr15046217wmi.107.1574416785540; Fri, 22 Nov 2019 01:59:45 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d16sm5284642wrg.27.2019.11.22.01.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 01:59:44 -0800 (PST) Date: Fri, 22 Nov 2019 09:59:43 +0000 From: "Leif Lindholm" To: Zhiguang Liu Cc: devel@edk2.groups.io, Liming Gao , Jian J Wang , Hao A Wu Subject: Re: [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Message-ID: <20191122095943.GW7359@bivouac.eciton.net> References: <20191122080726.36584-1-zhiguang.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20191122080726.36584-1-zhiguang.liu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 22, 2019 at 16:07:26 +0800, Zhiguang Liu wrote: > V1: > > After unifying the definition of size_t, EBC compiler has failure. > So don't compile this inf file for EBC > > V2: > > Thanks for Leif's comment > Updated VALID_ARCHITECTURES in inf file Please remove the versioning information from the commit message - such infofmation goes below ---. The part that is in the V1 section (minus the "V1:" bit) is a sufficient commit message - please keep only that. With that Reviewed-by: Leif Lindholm > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338 > > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Leif Lindholm > Reviewed-by: Liming Gao > > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +- > MdeModulePkg/MdeModulePkg.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > index 42b741c64b..4ed1d83a40 100644 > --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > @@ -25,7 +25,7 @@ > # > # The following information is for reference only and not required by the build tools. > # > -# VALID_ARCHITECTURES = IA32 X64 EBC > +# VALID_ARCHITECTURES = IA32 X64 AARCH64 ARM > # > > [Sources] > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 4320839abf..f7dbb27ce2 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -299,7 +299,6 @@ > MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf > MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf > MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf > - MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -433,6 +432,7 @@ > > [Components.IA32, Components.X64, Components.ARM, Components.AARCH64] > MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf > + MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > MdeModulePkg/Core/Dxe/DxeMain.inf { > > -- > 2.16.2.windows.1 >