From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.6856.1574431720058753269 for ; Fri, 22 Nov 2019 06:08:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=CSU7MAhi; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id i12so8782372wro.5 for ; Fri, 22 Nov 2019 06:08:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3IX1o4TYyn7h1A92GqRJFe3LsUnb6YU6tCwl+I8GKZ8=; b=CSU7MAhiT5U/HuuFN17vrZbi8QGlxPQlOEP0usObB7a41N5se1Y+PiiHuRXLAvQMsu OyV8ZS64E3R5sAUtX2jAaDJhuMy+mHuYCdnVT9Tlpc/K0E+4v1Beh7rZ4eiphr8ObTsZ k/uv0Rp/B1ex3s4HqzClHEwr0GeaL3rlsp35WkYwIo0PnnE3657q4fOxNvIWQjJ7HibE b14CvleqqBYH0wOfb012KqiuUvf0uzODE68w9tZh86zBC6mict4ChOCCdkuGCDK5jtNL Wea1kzUmCvDMoDIS7uPbVXF5cHX28BGB6bHQLoxe7YCqV+mI35fhC9NMfr2LOat1Yc3I k5Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3IX1o4TYyn7h1A92GqRJFe3LsUnb6YU6tCwl+I8GKZ8=; b=gaBYbuD9je8PicMkkIdgW6SRcLFZ0wnmigGki1/ccmBrqfEDmWt/sEZKJapB41cNrF S8G9NQPgZH93u1DYeVMwZu7UDXpdt3DSfQpiokYuFdDSCOLfxN16G0R/55X3k+xVuIBA iKy0vIKYu9mBKDL5iO0Y0zwS6rDE0PFKnlVVADHTQu0ZvE5gWuv+HnaUjBM1fQDdeCTj yp83sTemHiBR1lUc0D2cKE/d4GJ7CAEC5IuPGvxFWt50tMvsnxSv2QrSxulQbb4Z+4jh g99nNvzELq9xmL9wIJ0WEK4+UsSsWYPB7xIsjY2to2yzbyjcJx8GL0z8jftYgfc/UHQA ms1Q== X-Gm-Message-State: APjAAAV/CuSkPTvIZ08gN5y6e7kxGilKIFvxtONNQBRZLJAIABQDy7B2 CEw/J5lmpti+9Rr5xcoUBB0Q3Q== X-Google-Smtp-Source: APXvYqyZQstsiokfBaCBwzX9VtynAXPuAiIO+s9gjuDkhXroLkMrZDj7+P7mN/kJ0Bt+H11QEzwsIw== X-Received: by 2002:adf:f688:: with SMTP id v8mr1107584wrp.147.1574431718621; Fri, 22 Nov 2019 06:08:38 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a206sm3820835wmf.15.2019.11.22.06.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 06:08:37 -0800 (PST) Date: Fri, 22 Nov 2019 14:08:35 +0000 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "Chen, Gilbert" Subject: Re: [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Message-ID: <20191122140835.GF7359@bivouac.eciton.net> References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-30-git-send-email-abner.chang@hpe.com> <20191121170254.GP7359@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 22, 2019 at 12:28:01 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Friday, November 22, 2019 1:03 AM > > To: Chang, Abner (HPS SW/FW Technologist) > > Cc: devel@edk2.groups.io; Chen, Gilbert > > Subject: Re: [edk2-staging/RISC-V-V2 PATCH v3 29/39] > > RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. > > > > On Mon, Oct 28, 2019 at 09:59:07 +0800, Abner Chang wrote: > > > Null instance of Real Time Clock lib for RISC-V platform. > > > > > > Signed-off-by: Abner Chang > > > > > > Cc: Leif Lindholm > > > Cc: Gilbert Chen > > > > Can you drop this one in favour of > > EmbeddedPkg/Library/VirtualRealTimeClockLib/ > > Both U500.dsc and U540.dsc use > EmbeddedPkg/Library/VirtualRealTimeClockLib, you can see this in > edk2-platform patches. > > The NULL one is only used in RiscVplatformPkg for build. I don't > think we have to use VirtualRealTimeClockLib in this > RiscVplatformPkg package. Sure, but we also don't *need* to add a new implementation for this - RiscVPkg can still use the EmbeddedPkg one. (And if we did, it should probably be in MdeModulePkg.) / Leif