From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.637.1574434551648313648 for ; Fri, 22 Nov 2019 06:55:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=YOKhqSBW; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id t2so9007746wrr.1 for ; Fri, 22 Nov 2019 06:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HAuxGJ680gauDnW6IyN9tkGwi2CvPDDKvYGcNsO+gss=; b=YOKhqSBWFZXSSEJ1WXT2ITMmnE+gkSsE1bWQOokX5K3QLfIcfeZnCrlrOVBaQLjKtp D3pNoM+25f7wjTErMoRjej2P02CHDy/xCba8oaYvEYawCVO14yk7rY5RcdfLBsjVmdCY C24OQyfhIFUHVG9a5P7P9L/EAsLFfTxigqqcmcvA/XpHbzbNcdz1zf6pSdjZkYviWcIj 4rItCIucUskwivCVjEyO0MDSS+aYchyG1JZ3+6J8216hqYtPbOQMujeR76g2s1GXfFk3 yqKE3mLTwuO8rck/VAVEP70VHRvhaIPV+w9jFLCPspbs/igg7sd3G75QaEXX0Kv5NvuP nGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HAuxGJ680gauDnW6IyN9tkGwi2CvPDDKvYGcNsO+gss=; b=L4Dda0PNgWoSSWBPz6Mbnqx4NGDeOgYMwb0ecF8ddeWOZQpi8cnTWuCsMi/rVF7PRO hsaMTji0qWZJHttWaz0HnX3Zi57XVyIlW0QulhYECD2N/5bJcqPQMo6QgvDa4zSLfK0g A/eK+OdeslBJwP1TKEOsLFeWi655D/KNsOwqnTEo31IsISPkSEcaB0kB80CmAUP7HDNM PmGjNE2IaPe9EzbUv6lwcNWu4ViKelnKyGhAw4YZgzEExXLA3osHCh7uN6B+1x69bAJc gv8bxlUF9v2xRdTacRtwiKFujnc8C78LS37blm0+LxG+KHsalnUFTO1q8y8o0Pkp5EEV vBmg== X-Gm-Message-State: APjAAAXWpp5LJLzISP/yEnU2rljUztyOjDIooS89zE2+VwhZtYdKXfrb ACxnRKczUaiDqFVbEvR48tYh1A== X-Google-Smtp-Source: APXvYqwM2dhUnkg5LnHXI5ECHLiMCszhbs4JjM1S3YuhAecQ1dIBPiTPcWXQcUabbzu7Bddt3NrsZw== X-Received: by 2002:adf:d844:: with SMTP id k4mr17568769wrl.333.1574434550072; Fri, 22 Nov 2019 06:55:50 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j10sm7925931wrx.30.2019.11.22.06.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 06:55:48 -0800 (PST) Date: Fri, 22 Nov 2019 14:55:47 +0000 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "Chen, Gilbert" Subject: Re: [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Message-ID: <20191122145547.GH7359@bivouac.eciton.net> References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-30-git-send-email-abner.chang@hpe.com> <20191121170254.GP7359@bivouac.eciton.net> <20191122140835.GF7359@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 22, 2019 at 14:19:55 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > On Mon, Oct 28, 2019 at 09:59:07 +0800, Abner Chang wrote: > > > > > Null instance of Real Time Clock lib for RISC-V platform. > > > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > > > Cc: Leif Lindholm > > > > > Cc: Gilbert Chen > > > > > > > > Can you drop this one in favour of > > > > EmbeddedPkg/Library/VirtualRealTimeClockLib/ > > > > > > Both U500.dsc and U540.dsc use > > > EmbeddedPkg/Library/VirtualRealTimeClockLib, you can see this in > > > edk2-platform patches. > > > > > > The NULL one is only used in RiscVplatformPkg for build. I don't think > > > we have to use VirtualRealTimeClockLib in this RiscVplatformPkg > > > package. > > > > Sure, but we also don't *need* to add a new implementation for this - > > RiscVPkg can still use the EmbeddedPkg one. > > > > (And if we did, it should probably be in MdeModulePkg.) > > I think we had similar discussion about this before. My comment was > RiscVPkg as a processor package should not have dependence with > EmbeddedPkg. This is not RiscVPkg though, this is RiscVPlatformPkg. And also, it does not appear to be used there anyway? Certainly I can still build RiscVPlatformPkg.dsc if I delete that library mapping. / Leif