* [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
@ 2019-11-25 1:57 Zhiguang Liu
2019-11-25 8:06 ` Philippe Mathieu-Daudé
2019-12-03 7:58 ` [edk2-devel] " Liming Gao
0 siblings, 2 replies; 3+ messages in thread
From: Zhiguang Liu @ 2019-11-25 1:57 UTC (permalink / raw)
To: devel
Cc: Liming Gao, Jian J Wang, Hao A Wu, Leif Lindholm,
Philippe Mathieu-Daudé
After unifying the definition of size_t, EBC compiler has failure.
So don't compile this inf file for EBC
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +-
MdeModulePkg/MdeModulePkg.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
index 42b741c64b..e8061f54f9 100644
--- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
@@ -25,7 +25,7 @@
#
# The following information is for reference only and not required by the build tools.
#
-# VALID_ARCHITECTURES = IA32 X64 EBC
+# VALID_ARCHITECTURES = IA32 X64
#
[Sources]
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index 4320839abf..f7dbb27ce2 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -299,7 +299,6 @@
MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf
- MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -433,6 +432,7 @@
[Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
+ MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
MdeModulePkg/Core/Dxe/DxeMain.inf {
<LibraryClasses>
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
2019-11-25 1:57 [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
@ 2019-11-25 8:06 ` Philippe Mathieu-Daudé
2019-12-03 7:58 ` [edk2-devel] " Liming Gao
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-25 8:06 UTC (permalink / raw)
To: Zhiguang Liu, devel; +Cc: Liming Gao, Jian J Wang, Hao A Wu, Leif Lindholm
On 11/25/19 2:57 AM, Zhiguang Liu wrote:
> After unifying the definition of size_t, EBC compiler has failure.
> So don't compile this inf file for EBC
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +-
> MdeModulePkg/MdeModulePkg.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> index 42b741c64b..e8061f54f9 100644
> --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> @@ -25,7 +25,7 @@
> #
> # The following information is for reference only and not required by the build tools.
> #
> -# VALID_ARCHITECTURES = IA32 X64 EBC
> +# VALID_ARCHITECTURES = IA32 X64
> #
>
> [Sources]
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 4320839abf..f7dbb27ce2 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -299,7 +299,6 @@
> MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
> MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
> MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf
> - MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -433,6 +432,7 @@
>
> [Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
> MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> + MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
2019-11-25 1:57 [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
2019-11-25 8:06 ` Philippe Mathieu-Daudé
@ 2019-12-03 7:58 ` Liming Gao
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2019-12-03 7:58 UTC (permalink / raw)
To: devel@edk2.groups.io, Liu, Zhiguang
Cc: Wang, Jian J, Wu, Hao A, Leif Lindholm,
Philippe Mathieu-Daudé
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhiguang Liu
>Sent: Monday, November 25, 2019 9:58 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Wang, Jian J
><jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Leif Lindholm
><leif.lindholm@linaro.org>; Philippe Mathieu-Daudé <philmd@redhat.com>
>Subject: [edk2-devel] [Patch V3 1/2] MdeModulePkg:
>LzmaCustomDecompressLib.inf don't support EBC anymore
>
>After unifying the definition of size_t, EBC compiler has failure.
>So don't compile this inf file for EBC
>
>REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
>---
>
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf | 2 +-
> MdeModulePkg/MdeModulePkg.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
>essLib.inf
>b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp
>ressLib.inf
>index 42b741c64b..e8061f54f9 100644
>---
>a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
>essLib.inf
>+++
>b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp
>ressLib.inf
>@@ -25,7 +25,7 @@
> #
> # The following information is for reference only and not required by the
>build tools.
> #
>-# VALID_ARCHITECTURES = IA32 X64 EBC
>+# VALID_ARCHITECTURES = IA32 X64
> #
>
> [Sources]
>diff --git a/MdeModulePkg/MdeModulePkg.dsc
>b/MdeModulePkg/MdeModulePkg.dsc
>index 4320839abf..f7dbb27ce2 100644
>--- a/MdeModulePkg/MdeModulePkg.dsc
>+++ b/MdeModulePkg/MdeModulePkg.dsc
>@@ -299,7 +299,6 @@
> MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
>
>MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLi
>bNull.inf
>
>MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerial
>PortPpi.inf
>-
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf
>
>MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLib
>ReportStatusCode.inf
> MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>@@ -433,6 +432,7 @@
>
> [Components.IA32, Components.X64, Components.ARM,
>Components.AARCH64]
>
>MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre
>ssLib.inf
>+
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf
> MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
>--
>2.16.2.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-03 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-25 1:57 [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
2019-11-25 8:06 ` Philippe Mathieu-Daudé
2019-12-03 7:58 ` [edk2-devel] " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox