public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, philmd@redhat.com
Subject: [edk2-platforms][PATCH 1/2] Platform/RPi3: Disable DEBUG output at runtime for the RTC driver
Date: Tue, 26 Nov 2019 10:57:32 +0000	[thread overview]
Message-ID: <20191126105733.6300-2-pete@akeo.ie> (raw)
In-Reply-To: <20191126105733.6300-1-pete@akeo.ie>

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Using DEBUG () at runtime can crash the OS if we don't take care to
inhibit serial output to MMIO mapped UARTs that we don't inform the
OS about via the memory map.

So use a version of DebugLib that does exactly that for the RTC
driver.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 98c75e373fa7..8ec82fc6d598 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -505,6 +505,7 @@ [Components.common]
   EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
   EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
     <LibraryClasses>
+      DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
       RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
   }
   EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
-- 
2.21.0.windows.1


  reply	other threads:[~2019-11-26 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 10:57 [edk2-platforms][PATCH 0/2] Platform/RPi3: Fix a crash and add acpiview to shell Pete Batard
2019-11-26 10:57 ` Pete Batard [this message]
2019-11-26 10:57 ` [edk2-platforms][PATCH 2/2] Platform/RPi3: Add acpiview to the builtin UEFI Shell Pete Batard
2019-11-26 17:05 ` [edk2-platforms][PATCH 0/2] Platform/RPi3: Fix a crash and add acpiview to shell Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191126105733.6300-2-pete@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox