[edk2-platforms][PATCH 0/2] Platform/RPi3: Fix a crash and add acpiview to shell

[edk2-platforms][PATCH 0/2] Platform/RPi3: Fix a crash and add acpiview to shell

[Pete Batard]

These two patches were provided by Ard against the current Pi 4
development effort, but it makes a lot of sense to have them in
the Pi 3 tree as well, especially as the first one addresses an
issue that can also be experienced on the platform when using the
the DEBUG version of the firmware against some Linux kernels.

Ard Biesheuvel (2):
  Platform/RPi3: Disable DEBUG output at runtime for the RTC driver
  Platform/RPi3: Add acpiview to the builtin UEFI Shell

 Platform/RaspberryPi/RPi3/RPi3.dsc | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.21.0.windows.1

[edk2-platforms][PATCH 1/2] Platform/RPi3: Disable DEBUG output at runtime for the RTC driver

[Pete Batard]

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Using DEBUG () at runtime can crash the OS if we don't take care to
inhibit serial output to MMIO mapped UARTs that we don't inform the
OS about via the memory map.

So use a version of DebugLib that does exactly that for the RTC
driver.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 98c75e373fa7..8ec82fc6d598 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -505,6 +505,7 @@ [Components.common]
   EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
   EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf {
     <LibraryClasses>
+      DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
       RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
   }
   EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
-- 
2.21.0.windows.1

[edk2-platforms][PATCH 2/2] Platform/RPi3: Add acpiview to the builtin UEFI Shell

[Pete Batard]

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

acpiview is a UEFI shell command that can be used to inspect and
validate ACPI tables from the pre-OS environment. Let's add it to
our build of the shell.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 8ec82fc6d598..6a808b287ea9 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -617,6 +617,7 @@ [Components.common]
       NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
       NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
       HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
       PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
       BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
-- 
2.21.0.windows.1

Re: [edk2-platforms][PATCH 0/2] Platform/RPi3: Fix a crash and add acpiview to shell

[Leif Lindholm]

On Tue, Nov 26, 2019 at 10:57:31 +0000, Pete Batard wrote:
> These two patches were provided by Ard against the current Pi 4
> development effort, but it makes a lot of sense to have them in
> the Pi 3 tree as well, especially as the first one addresses an
> issue that can also be experienced on the platform when using the
> the DEBUG version of the firmware against some Linux kernels.
> 
> Ard Biesheuvel (2):
>   Platform/RPi3: Disable DEBUG output at runtime for the RTC driver
>   Platform/RPi3: Add acpiview to the builtin UEFI Shell

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 0d076ec2a233..110d01162892.

Thanks!


>  Platform/RaspberryPi/RPi3/RPi3.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> -- 
> 2.21.0.windows.1
>