From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.12932.1574779603685706410 for ; Tue, 26 Nov 2019 06:46:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=E+gltb9K; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id s5so22757942wrw.2 for ; Tue, 26 Nov 2019 06:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QFF64tRctEPjavDEYPpAsiIaE5Qec9gvp+HMIuYasCQ=; b=E+gltb9KwTeZn7nCgJMQjzys+Tg5G3Ujfl/WsH0q6dZe+w9fwEkhwFqXsGDy7f6Xcf YcS7f1HGlLHgGoT1/vIsC9zgxSs6pZ4oEbANrjGk338FYT2IjpdhZ+HMWhxc18/TvOel vmT+7RBc6wjH+k9TtTeLoHPnpLyWxXh/cy9injiBgKts/zy457kGswafLr8b473vYcEt v8P93VHyekOYqeuKMFOmslzKzpomjWF4HBghaWTuInrgE8eZX6bXgESbiIPBmEhOnV2C KIBapGlEkR1/RwsWtbytS4hl4Zg2ckw5ClmZZVCQRiGvyasXHK2uJ7RdKqw9ANkkQjKS uDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QFF64tRctEPjavDEYPpAsiIaE5Qec9gvp+HMIuYasCQ=; b=UrxC0oja2UYl/iXWtfBN04GSspqQjgH5zelkLRYnbkjMSKFtJUe7UATNDifCXkPhpO Xc8MQWqx0fZyRNjrKZWLskbNTpOW0YKG+bOPyF2tK/kdxOAGeKQf/Z6NdMTp5bAu2XMs 9Pt9ap3rsw/biD541NsYQwqVQCZXTzvWChNiqP3XmLwbQjZR8RTcpMsg541XFQ4p0P7/ R+AWTnT1mA/NuGNpeQCGCGRlR4niw62mEW6fkPB/qnfiHTmFB/aGpbKombayIwQYVuYE SietyYhyajq3DS7KgKoXMWHTIyTqoiSnUgiDbdnmvzydwJZyCwPDSpZeiKqS++DOtsJe 8JPg== X-Gm-Message-State: APjAAAWZZes9LeO0flZCGSRcu8IgCKf3XvAHboI4us0hxq/pw4MPzcow mY3q9MlEsYxzVUVq6j7wlCIMqg== X-Google-Smtp-Source: APXvYqyh7HU87rzSvr37kl9Z6nbemQxEzhWN3M24mrcBWj42R8ywnprdfJ79+vEd8/gjbPpg2vATpw== X-Received: by 2002:adf:ffd0:: with SMTP id x16mr36049449wrs.86.1574779602173; Tue, 26 Nov 2019 06:46:42 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z15sm3153046wmi.12.2019.11.26.06.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 06:46:41 -0800 (PST) Date: Tue, 26 Nov 2019 14:46:39 +0000 From: "Leif Lindholm" To: Abner Chang Cc: devel@edk2.groups.io, Michael D Kinney , Ard Biesheuvel , Gilbert Chen , Palmer Dabbelt Subject: Re: [platform/devel-riscv-v2 PATCHv5 07/18] U5SeriesPkg/RamFvbServicesRuntimeDxe: Firmware Volume Block service. Message-ID: <20191126144639.GY7359@bivouac.eciton.net> References: <1572228122-13265-1-git-send-email-abner.chang@hpe.com> <1572228122-13265-8-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1572228122-13265-8-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 28, 2019 at 10:01:49 +0800, Abner Chang wrote: > RAM based Firmware Volume Block service runtime driver for U5 series > platforms. For this patch, could you please update the commit message to describe what this is and what it is used for? This includes one more item below. > Signed-off-by: Abner Chang > > Cc: Michael D Kinney > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Gilbert Chen > Cc: Palmer Dabbelt > --- > .../FvbServicesRuntimeDxe.inf | 80 ++ > .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h | 187 ++++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.h | 85 ++ > .../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c | 127 +++ > .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c | 1114 ++++++++++++++++++++ > .../RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 150 +++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.c | 145 +++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c | 20 + > 8 files changed, 1908 insertions(+) > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.h > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.c > create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c > > diff --git a/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > new file mode 100644 > index 0000000..9db112a > --- /dev/null > +++ b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > @@ -0,0 +1,80 @@ > +## @file > +# Component description file for RAM Flash Fimware Volume Block DXE driver > +# module. > +# > +# This DXE runtime driver implements and produces the Fimware Volue Block > +# Protocol for a RAM flash device. > +# > +# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001b > + BASE_NAME = FvbServicesRuntimeDxe > + FILE_GUID = B04036D3-4C60-43D6-9850-0FCC090FF054 > + MODULE_TYPE = DXE_RUNTIME_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = FvbInitialize > + > +# > +# The following information is for reference only and not required by the build > +# tools. > +# > +# VALID_ARCHITECTURES = RISCV64 > +# > + > +[Sources] > + FvbInfo.c > + FwBlockService.c > + FwBlockServiceDxe.c > + RamFlash.c > + RamFlashDxe.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + RiscVPlatformPkg/RiscVPlatformPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + DevicePathLib > + DxeServicesTableLib > + MemoryAllocationLib > + PcdLib > + UefiBootServicesTableLib > + UefiDriverEntryPoint > + UefiRuntimeLib > + > +[Guids] > + gEfiEventVirtualAddressChangeGuid # ALWAYS_CONSUMED > + # gEfiEventVirtualAddressChangeGuid # Create Event: EVENT_GROUP_GUID > + > +[Protocols] > + gEfiFirmwareVolumeBlockProtocolGuid # PROTOCOL SOMETIMES_PRODUCED > + gEfiDevicePathProtocolGuid # PROTOCOL SOMETIMES_PRODUCED > + > +[FixedPcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize > + > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageVariableBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageFtwWorkingBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageFtwSpareBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdBaseAddress > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdSize > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdBlockSize > + > +[Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 > + > +[Depex] > + TRUE > diff --git a/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > new file mode 100644 > index 0000000..96d0141 > --- /dev/null > +++ b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > @@ -0,0 +1,187 @@ > +/**@file > + > + Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> + Copyright (c) 2006, Intel Corporation. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + Module Name: > + > + FwBlockService.h > + > + Abstract: > + > + Firmware volume block driver for Intel Firmware Hub (FWH) device The FWH comment is surely incorrect here? Please describe the thing actually implemented. No need to resubmit - just update in your repo and I will grab it from there when I get to pushing this port to a -devel branch. / Leif