public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, abner.chang@hpe.com
Subject: Re: [edk2-devel] [platform/devel-riscv-v2 PATCHv5 00/18] Initial version of RISC-V
Date: Tue, 26 Nov 2019 15:22:14 +0000	[thread overview]
Message-ID: <20191126152214.GC7359@bivouac.eciton.net> (raw)
In-Reply-To: <1572236433-15404-1-git-send-email-abner.chang@hpe.com>

Apart from the minor comments I've made, and the fallout from header
wrapper changes, I think this is ready to go into a -devel branch.

I still think the SMBIOS generation code needs to be consolidated, but
sure, let's do that once the code is in the branch.

Regards,

Leif

On Mon, Oct 28, 2019 at 12:20:15 +0800, Abner Chang wrote:
> The is the set of patches for belwo two platforms,
>  - SiFive Freedom U500 VC707 FPGA Dev Kit
>  - SiFive Freedom U540 HiFive Unleashed development board
> Refer to Readme.md under platforms/SiFive/U5SeriesPkg.
> 
> These patches have to be incorporated with RISC-V-V2 pacth v3 of edk2-staging.
> 
> Besides of patches, you can also get code from belwo git repository.
> - edk2-platforms for RISC-V platform,
> https://github.com/gilbert225/edk2-platforms/tree/devel-riscv-v2-PATCHv5
> - edk2-staging for RISC-V,
> https://github.com/changab/edk2-staging-riscv/tree/RISC-V-V2-v3
> 
> Abner Chang (18):
>   Silicon/SiFive: Initial version of SiFive silicon package.
>   SiFive/E51: Initial version of SiFive E51 core library.
>   SiFive/U54: Initial version of SiFive U54 core library.
>   SiFive/U54MC: Initial version of SiFive U54MC Coreplex library.
>   U5SeriesPkg/PeiCoreInfoHobLib: Library to create core information.
>   U5SeriesPkg/TimerDxe: U5 Series Platform Timer DXE driver.
>   U5SeriesPkg/RamFvbServicesRuntimeDxe: Firmware Volume Block service.
>   U5SeriesPkg/RiscVPlatformTimerLib: Platform Timer library
>   U5SeriesPkg/SerialIoLib: Platform Serial Port library
>   FreedomU540HiFiveUnleashedBoard/PlatformPei: Platform PEI for U540
>     platform.
>   FreedomU540HiFiveUnleashedBoard/OpensbiPlatformLib: OpenSBI platform
>     library     for U540 platform.
>   U5SeriesPkg/FreedomU540HiFiveUnleashedBoard: Add SiFive U540 platform.
>   FreedomU500VC707Board/PlatformPei: Platform initialization PEI module.
>   FreedomU500VC707Board/OpensbiPlatformLib: OpenSBI platform interface.
>   U5SeriesPkg/FreedomU500VC707Board: Add SiFive U500 platform.
>   SiFive/U5SeriesPkg Add U5SeriesPkg.
>   edk2-platforms: Update Readme.md for RISC-V platform.
>   edk2-platforms: Update Maintainers file.
> 
>  .../U5SeriesPkg/FreedomU500VC707Board/U500.dec     |   25 +
>  .../FreedomU540HiFiveUnleashedBoard/U540.dec       |   25 +
>  Platform/SiFive/U5SeriesPkg/U5SeriesPkg.dec        |   33 +
>  Silicon/SiFive/SiFive.dec                          |   39 +
>  .../U5SeriesPkg/FreedomU500VC707Board/U500.dsc     |  543 ++++++++++
>  .../FreedomU540HiFiveUnleashedBoard/U540.dsc       |  543 ++++++++++
>  .../U5SeriesPkg/FreedomU500VC707Board/U500.fdf     |  336 ++++++
>  .../FreedomU540HiFiveUnleashedBoard/U540.fdf       |  336 ++++++
>  .../U5SeriesPkg/FreedomU500VC707Board/U500.fdf.inc |   55 +
>  .../FreedomU500VC707Board/VarStore.fdf.inc         |   78 ++
>  .../FreedomU540HiFiveUnleashedBoard/U540.fdf.inc   |   54 +
>  .../VarStore.fdf.inc                               |   78 ++
>  .../OpensbiPlatformLib/OpensbiPlatformLib.inf      |   52 +
>  .../Universal/Pei/PlatformPei/PlatformPei.inf      |   73 ++
>  .../OpensbiPlatformLib/OpensbiPlatformLib.inf      |   52 +
>  .../Universal/Pei/PlatformPei/PlatformPei.inf      |   72 ++
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   58 +
>  .../RiscVPlatformTimerLib.inf                      |   36 +
>  .../Library/SerialIoLib/SerialIoLib.inf            |   38 +
>  .../FvbServicesRuntimeDxe.inf                      |   80 ++
>  .../Universal/Dxe/TimerDxe/TimerDxe.inf            |   53 +
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   47 +
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   48 +
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   46 +
>  .../Universal/Pei/PlatformPei/Platform.h           |   86 ++
>  .../Universal/Pei/PlatformPei/Platform.h           |   86 ++
>  .../U5SeriesPkg/Include/SiFiveU5MCCoreplex.h       |   51 +
>  Platform/SiFive/U5SeriesPkg/Include/U5Clint.h      |   20 +
>  .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h  |  187 ++++
>  .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.h        |   85 ++
>  .../U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.h     |  174 +++
>  Silicon/SiFive/Include/Library/SiFiveE51.h         |   60 ++
>  Silicon/SiFive/Include/Library/SiFiveU54.h         |   60 ++
>  .../SiFive/Include/Library/SiFiveU54MCCoreplex.h   |   55 +
>  .../Library/OpensbiPlatformLib/Platform.c          |  213 ++++
>  .../Universal/Pei/PlatformPei/Fv.c                 |   51 +
>  .../Universal/Pei/PlatformPei/MemDetect.c          |   74 ++
>  .../Universal/Pei/PlatformPei/Platform.c           |  310 ++++++
>  .../Library/OpensbiPlatformLib/Platform.c          |  213 ++++
>  .../Universal/Pei/PlatformPei/Fv.c                 |   51 +
>  .../Universal/Pei/PlatformPei/MemDetect.c          |   74 ++
>  .../Universal/Pei/PlatformPei/Platform.c           |  310 ++++++
>  .../Library/PeiCoreInfoHobLib/CoreInfoHob.c        |  195 ++++
>  .../Library/SerialIoLib/SerialPortLib.c            |  253 +++++
>  .../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c         |  127 +++
>  .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c  | 1114 ++++++++++++++++++++
>  .../RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c   |  150 +++
>  .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.c        |  145 +++
>  .../Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c     |   20 +
>  .../U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.c     |  304 ++++++
>  .../E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c    |  242 +++++
>  .../U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c    |  290 +++++
>  .../Library/PeiCoreInfoHobLib/CoreInfoHob.c        |  184 ++++
>  Platform/SiFive/U5SeriesPkg/Readme.md              |  110 ++
>  Readme.md                                          |   13 +
>  Maintainers.txt                                    |   16 +
>  .../U5SeriesPkg/FreedomU500VC707Board/U500.uni     |   13 +
>  .../FreedomU500VC707Board/U500PkgExtra.uni         |   12 +
>  .../FreedomU540HiFiveUnleashedBoard/U540.uni       |   13 +
>  .../U540PkgExtra.uni                               |   12 +
>  .../RiscVPlatformTimerLib/RiscVPlatformTimerLib.S  |   48 +
>  .../Library/SerialIoLib/U5SerialPortLib.uni        |   16 +
>  Platform/SiFive/U5SeriesPkg/U5SeriesPkg.uni        |   13 +
>  Platform/SiFive/U5SeriesPkg/U5SeriesPkgExtra.uni   |   12 +
>  .../U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.uni   |   14 +
>  .../Universal/Dxe/TimerDxe/TimerExtra.uni          |   12 +
>  66 files changed, 8288 insertions(+)
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dec
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dec
>  create mode 100644 Platform/SiFive/U5SeriesPkg/U5SeriesPkg.dec
>  create mode 100644 Silicon/SiFive/SiFive.dec
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf.inc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/VarStore.fdf.inc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf.inc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/VarStore.fdf.inc
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Library/OpensbiPlatformLib/OpensbiPlatformLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Universal/Pei/PlatformPei/PlatformPei.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/OpensbiPlatformLib/OpensbiPlatformLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/PlatformPei.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/SerialIoLib/SerialIoLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/TimerDxe/TimerDxe.inf
>  create mode 100644 Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
>  create mode 100644 Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
>  create mode 100644 Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Universal/Pei/PlatformPei/Platform.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/Platform.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Include/U5Clint.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.h
>  create mode 100644 Silicon/SiFive/Include/Library/SiFiveE51.h
>  create mode 100644 Silicon/SiFive/Include/Library/SiFiveU54.h
>  create mode 100644 Silicon/SiFive/Include/Library/SiFiveU54MCCoreplex.h
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Library/OpensbiPlatformLib/Platform.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Universal/Pei/PlatformPei/Fv.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Universal/Pei/PlatformPei/MemDetect.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/Universal/Pei/PlatformPei/Platform.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/OpensbiPlatformLib/Platform.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/Fv.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/MemDetect.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/Platform.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/SerialIoLib/SerialPortLib.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.c
>  create mode 100644 Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c
>  create mode 100644 Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c
>  create mode 100644 Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/CoreInfoHob.c
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Readme.md
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500PkgExtra.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540PkgExtra.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.S
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Library/SerialIoLib/U5SerialPortLib.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/U5SeriesPkg.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/U5SeriesPkgExtra.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/TimerDxe/Timer.uni
>  create mode 100644 Platform/SiFive/U5SeriesPkg/Universal/Dxe/TimerDxe/TimerExtra.uni
> 
> -- 
> 2.7.4
> 
> 
> 
> 

  parent reply	other threads:[~2019-11-26 15:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  4:20 [platform/devel-riscv-v2 PATCHv5 00/18] Initial version of RISC-V Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 01/18] Silicon/SiFive: Initial version of SiFive silicon package Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 02/18] SiFive/E51: Initial version of SiFive E51 core library Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 03/18] SiFive/U54: Initial version of SiFive U54 " Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 04/18] SiFive/U54MC: Initial version of SiFive U54MC Coreplex library Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 05/18] U5SeriesPkg/PeiCoreInfoHobLib: Library to create core information Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 06/18] U5SeriesPkg/TimerDxe: U5 Series Platform Timer DXE driver Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 07/18] U5SeriesPkg/RamFvbServicesRuntimeDxe: Firmware Volume Block service Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 08/18] U5SeriesPkg/RiscVPlatformTimerLib: Platform Timer library Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 09/18] U5SeriesPkg/SerialIoLib: Platform Serial Port library Abner Chang
2019-11-19 15:30   ` [edk2-devel] " Mark Salter
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 10/18] FreedomU540HiFiveUnleashedBoard/PlatformPei:Platform PEI Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 11/18] FreedomU540HiFiveUnleashedBoard/OpensbiPlatformLib:OpenSBI platform lib Abner Chang
2019-11-19 15:30   ` [edk2-devel] " Mark Salter
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 12/18] U5SeriesPkg/FreedomU540HiFiveUnleashedBoard: Add SiFive U540 platform Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 13/18] FreedomU500VC707Board/PlatformPei: Platform initialization PEI module Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 14/18] FreedomU500VC707Board/OpensbiPlatformLib: OpenSBI platform interface Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 15/18] U5SeriesPkg/FreedomU500VC707Board: Add SiFive U500 platform Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 16/18] SiFive/U5SeriesPkg Add U5SeriesPkg Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 17/18] edk2-platforms: Update Readme.md for RISC-V platform Abner Chang
2019-10-28  4:20 ` [platform/devel-riscv-v2 PATCHv5 18/18] edk2-platforms: Update Maintainers file Abner Chang
2019-11-26 15:22 ` Leif Lindholm [this message]
2019-12-22  6:09   ` [edk2-devel] [platform/devel-riscv-v2 PATCHv5 00/18] Initial version of RISC-V Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191126152214.GC7359@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox