From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web09.14878.1574787659654419901 for ; Tue, 26 Nov 2019 09:01:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nhQoHygo; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id l1so4014108wme.2 for ; Tue, 26 Nov 2019 09:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ih2nWXEELKftOKrLG1YMg518nX7qHlQv0UbR71E89QE=; b=nhQoHygoKw0PshFGgGS66lfkfU0u1dgwX0cPq+6Y+L1S6+AcUUFmivaj0SkyJdshbu 43saUZxHA5huurhRDHfK3+xM+aZtj4BsSa17rvWAJKaHMcnEPoR5c8JMLuev+JTQio1r YoSudfVLyoP5Ngcp8z4i13SELDIpKuB5tqxrOWqupUdmIfFBHTGaZciaIx8s+G5znXsG 7d5KEf0jPE+oDXfOP/yZBPZwJWvspcZPKIkppfBR4CuHKOhTCI2zmCpwHqMc8lstFUUh vk5qW2EAC5e+Din0lBuKNlM5YYdyn1xYPhL4YLLMheqDlfMonWk/3D1NhKz+kN3N6sTm 8DeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ih2nWXEELKftOKrLG1YMg518nX7qHlQv0UbR71E89QE=; b=ZEuYBTU486SbZDg4RJ25sucnzM/W5fgs6cRhLiQOQ62RKfrUN/eSZqrjp3o55+VPc+ e/R6DzyFNNX9opuk5NRp/F0hlc7lbn+G4GP1HuiqwUdIBte6W3bl2jF/UZtphPPPbmQp nEasgWsP0LjytYV1ucDQebizqBA2dQ1ev4qImmaS+PdlKKS4I5bv2UCdr+EnFdfHPB8s WfmxYUl8Umn7EIFTP40c0NGSFQzIHVFL8EskgRjuBI9JvpJdIXPrUfy/tm0FzCaAq28u BWYrXiPVbLCmM2WHYC4J5FPGzUbNL2ajm+kUgQXDu/KfMxkp06ntTTAG/0nenIihvYvG hwSA== X-Gm-Message-State: APjAAAVf5uv0xGRAlWDXAu+CnIUIL5nk3RJsHEtHG58jsq4ozYGC5D6g 2UwHGIKad+rCNcjFQt5BGbnNVg== X-Google-Smtp-Source: APXvYqyscV1KLt4dVFjAorO/oqfV+u2DPxa8cVQueW4DPufvm4HL5CNS6eKmZkKo89GZJLl5vYuATQ== X-Received: by 2002:a1c:23ca:: with SMTP id j193mr5030278wmj.83.1574787658181; Tue, 26 Nov 2019 09:00:58 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v20sm3764301wmj.32.2019.11.26.09.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 09:00:56 -0800 (PST) Date: Tue, 26 Nov 2019 17:00:55 +0000 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com Subject: Re: [edk2-platforms] [PATCH v2 05/11] Silicon/NXP: Add support for I2c driver Message-ID: <20191126170055.GH7359@bivouac.eciton.net> References: <1570639758-30355-1-git-send-email-meenakshi.aggarwal@nxp.com> <1574353514-23986-1-git-send-email-meenakshi.aggarwal@nxp.com> <1574353514-23986-6-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1574353514-23986-6-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 21, 2019 at 21:55:08 +0530, Meenakshi Aggarwal wrote: > I2C driver produces gEfiI2cMasterProtocolGuid which can be > used by other modules. > > Signed-off-by: Meenakshi Aggarwal Sorry, I missed the Reviewed-by: Leif Lindholm on this file. No need to resubmit with v3. > --- > > Notes: > v2: > - indentation correction > - STATIC variable with 'm' prefix > > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf | 58 ++ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 100 +++ > Silicon/NXP/Drivers/I2cDxe/ComponentName.c | 179 +++++ > Silicon/NXP/Drivers/I2cDxe/DriverBinding.c | 235 +++++++ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 690 ++++++++++++++++++++ > 5 files changed, 1262 insertions(+)