From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: devel@edk2.groups.io
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: [edk2-platforms][PATCH V1 0/2] KabylakeSiliconPkg: Remove redundant ResetSystem() implementation
Date: Tue, 26 Nov 2019 18:56:41 -0800 [thread overview]
Message-ID: <20191127025643.32056-1-michael.a.kubacki@intel.com> (raw)
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2375
This patch series:
1. Removes a ResetSystemLib.h override in KabylakeSiliconPkg
2. Removes a redundant implementation of ResetSystem ()
The redundant ResetSystem () implementation causes a build failure
in VS2017. The build failure does not reproduce in VS2015. The new
ResetSystem () implementation that led to the issue was introduced
in the following commits:
* 2393cff0d4
* 07fd95c9ca
* 0ad2f057d8
* a6e61d43c9
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
Michael Kubacki (2):
KabylakeSiliconPkg: Remove ResetSystemLib.h override
KabylakeSiliconPkg: Remove redundant ResetSystem() implementation
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeResetSystemLib.inf | 3 +-
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/DxeRuntimeResetSystemLib.inf | 3 +-
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchResetLib.inf | 3 +-
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiResetSystemLib.inf | 3 +-
Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Library/ResetSystemLib.h | 62 --------------------
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PchReset.c | 55 -----------------
Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiResetSystemLib.c | 5 ++
7 files changed, 13 insertions(+), 121 deletions(-)
delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Library/ResetSystemLib.h
--
2.16.2.windows.1
next reply other threads:[~2019-11-27 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 2:56 Kubacki, Michael A [this message]
2019-11-27 2:56 ` [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Kubacki, Michael A
2019-11-27 3:26 ` Chiu, Chasel
2019-11-27 4:49 ` Nate DeSimone
2019-11-27 6:42 ` Chaganty, Rangasai V
2019-11-27 18:41 ` Kubacki, Michael A
2019-11-28 0:31 ` Kubacki, Michael A
2019-12-02 8:36 ` Chaganty, Rangasai V
2019-11-27 2:56 ` [edk2-platforms][PATCH V1 2/2] KabylakeSiliconPkg: Remove redundant ResetSystem() implementation Kubacki, Michael A
2019-11-27 3:26 ` Chiu, Chasel
2019-11-27 4:49 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127025643.32056-1-michael.a.kubacki@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox