From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.9061.1574874275593496330 for ; Wed, 27 Nov 2019 09:04:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=qatrh1r9; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id n1so27572453wra.10 for ; Wed, 27 Nov 2019 09:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ig/7nOYej3AwbQV5siBhLxaMb0KnXO0N99397PuM8bI=; b=qatrh1r93iCcti0EgFW6CX1/FdNWBPM20/vTgpFZ5J/PTCt55O9LYEXl+xUERXUV49 PDU7yyNlEwwQZOfAv4Wiz9fADMQV3jiQZth+CNIZfafNCQgdVVDrdF8inD/g8dUNFoo5 M7yhHqrEaG/OlGgWkHQ50B/diAw6uL2Vz63wlDGSqIkItHszSoPxt3YxBkk+8/nerw0U hq/5DUpiRxKwbr968n+6eBUJBFohH9cqecvJ7dX0McwgB+S8jW8QKNaWZGISr9035+E/ 1VtGA/AvOEq/Wk/3095/FxYtC/XhZ/kypRKqPDHh2vN27sBDIRJR/DcerKEHgriipi7+ GWpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ig/7nOYej3AwbQV5siBhLxaMb0KnXO0N99397PuM8bI=; b=O/JRawyzbLViyArgJJtQ8UmqYZntOC0LDN1/4OaBBz4uYofHfEuRSlmT4WyLOumPZT oDaRSBNx1EOPMY6C4g9MaN4VGFnb+X9yJaNbk4Osf7IeH6d2GJWTEpR/6oenyJvH3cZl ko73RRw0lYDgr5kOBbRtrJ4BfVLAiezsZUdUK+exqXEaFSKZWmkD1XgsgtMt+O3hvJXv xz1QugtY7Q9eyWpB2wusxIZtf2upsYJokH8fPgRALfiJUhkrt3aOhqC3krS9lW1HKIlN kQ1alVy/aJJnBQGzlvfH7tAzek4jb8xxl6x7cGFAa0OwdIIIMKLNIZanB6KYl6JQ9RQi CBDQ== X-Gm-Message-State: APjAAAWPpKlgOqD0ICBLLPNBVlzuth36093T9u1rCx+k+At9qdfbYoEJ QF08AQ/92erhbjc6JGAx8fgtiQ== X-Google-Smtp-Source: APXvYqxwpBqnM1Pv+cAD1gcI5Kc5NPVLUogLgHa3NfMPUULUl12/VAvE2kNZskJum45B3CPTYx5gBg== X-Received: by 2002:adf:e80d:: with SMTP id o13mr45553372wrm.73.1574874273998; Wed, 27 Nov 2019 09:04:33 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l204sm6076366wmf.2.2019.11.27.09.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 09:04:32 -0800 (PST) Date: Wed, 27 Nov 2019 17:04:31 +0000 From: "Leif Lindholm" To: Pete Batard , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com, andrey.warkentin@gmail.com Subject: Re: [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model Message-ID: <20191127170431.GM7359@bivouac.eciton.net> References: <20191127123706.4604-1-pete@akeo.ie> <20191127123706.4604-6-pete@akeo.ie> <672a8fd3-f9db-3d60-ea02-188af6e8a6a5@redhat.com> <514e89d4-d571-b89b-0598-e6a56de93215@akeo.ie> MIME-Version: 1.0 In-Reply-To: <514e89d4-d571-b89b-0598-e6a56de93215@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Nov 27, 2019 at 16:33:28 +0000, Pete Batard wrote: > > > Signed-off-by: Pete Batard > > > --- > > >   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 137 > > > ++++++++++++++------ > > >   1 file changed, 96 insertions(+), 41 deletions(-) > > > > > > diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > > > b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > > > index 98e58a560ed4..26bc92f28185 100644 > > > --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > > > +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > > > @@ -1,6 +1,7 @@ > > >   /** @file > > >    * > > > - *  Copyright (c) 2018, Andrei Warkentin > > > + *  Copyright (c) 2019, ARM Limited. All rights reserved. > > > > "All rights reserved."? > > To be honest, that's something that's been bothering me too in this codebase > (and some other ones too, where you get to see the same), since there are > only so many rights one can reserve when the code is actually governed by > the Open Source license being used, and therefore asserting that you reserve > "all rights" seems to be in direct conflict with that. > > However, I am not a lawyer, and this seems to be standard boilerplate being > imposed by large companies. For instance, you'll find plenty of instances of > it in the existing codebase. E.g. > https://github.com/tianocore/edk2/blob/master/ArmPkg/Include/AsmMacroIoLib.h > has three separate entities that appear to state that each one holds all the > rights to the source, which I can't help by find amusing. > > I guess we're supposed to understand that each entity reserves all rights to > the code they've actually written (including the right to do something that > might go against the license, since "All rights" > "Rights to the extent > being granted by the BSD"), and that it's up to legal departments to sort up > the mess, if mess there is... Yeah, that mostly matches my interpretation. My understanding is that there are certain paranoid interpretations under which you *give away* rights to code you contribute to an open source project - like the right to also publish/contribute the same code under some other license. I don't know if this stems from things like copyright assignment agreements, which (for similar reasons) may explicitly grant back to the contributor a bunch of rights to the contributed code, and various corporate legal departments just blindly require it to be included everywhere. Phil: do a grep in linux, u-boot or qemu. This is silly, but it's commonplace and non-controversial. / Leif > Then again, while I think I can wrap my head against what copyright entails, > I'm not sure I completely get what these additional "rights" are supposed to > mean in this context (my current take being that we're supposed to be > believe that there exists an implicit grandfathered license, which gives all > rights to the parent company, and that governs a virtual version of the > source code containing only the changes that the developer applied, and > therefore that the BSD licensed version of the source that is then made > public is meant to be seen as a derivative of this virtual "All rights > reserved" incomplete source, hence granting a partial "All rights" for said > source to the company, if that makes any sense), so it may be good for > someone with better understanding of this to clarify, or point to a place > where this might be explained.