From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.5805.1574944324148656669 for ; Thu, 28 Nov 2019 04:32:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gWFbgdy7; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id b18so30897131wrj.8 for ; Thu, 28 Nov 2019 04:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8MgIiXRH5sioc8NvEZBDm6rIB2jXLiZvigTo8w0/X7w=; b=gWFbgdy7lG7l/82oBAhcsmE0smMugPVqgVVVnEM3QdxuuSZ9rPdj92I4awurivF+b4 PcJqm1Ia0zD9oWumXJyG9yWWdYuddNpFeUKv8PHcsNuiQcyCZ1ppMjHo6Ht+K3qstuBD Vd8VKIrI57lgYDimngJ+Rqlb8sMAEYW68boScmfytqkYtrdZzX8rH5yZta42RN1boB4b EohT1zlY7gEi3JXys0o1A7+TIjIzriuh72NTk9cjfzDBMSHzKiioagb+1uO2uEaaInQ5 kQ+49Is/q6uzytvdSdBrMYBq/C6OEmP9wYfsF0aJG+IJVUe57TOTMlBRCiAaG6O32/Mb 0KHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8MgIiXRH5sioc8NvEZBDm6rIB2jXLiZvigTo8w0/X7w=; b=EGD61FKwCUeIu4BWs+e0xiurQ/vFJnk1uUmBXjFE3F8SDcL4+TauvHqnXg7Bswc6tJ zeFjkhtwIXLQTUYCeuOM6R8nedZQKG1uWl2mnzult9G71NIo9tMikNoOG+oFWS0Shs9e qcU/afrWn/xJQY0ll8ZncPAMGJ2RRQ7vp/1k/Na0WJXokEoLQPUIJBMLcYin1pqXqBBG KBpk4rhX2IqaKieDBgm9WrzMRB7Y9DDha+XHF/QsHKAvNxJR3Cnipo2+8g3WD9s7zc9+ Tq8ZcYTC6Alt9DQiW2GhNj1EtMCYi51kOFmEWaGX5o1vPwmvl6dSaoEZQ1XKuVYAGOh4 0rvg== X-Gm-Message-State: APjAAAUv7b+mpY1vp0TWPUXifA8DaukMkvF6icjhzQMFneE4a7Xu5BTw ctF6r4MzBToyaohfYetECmtL/g== X-Google-Smtp-Source: APXvYqwvm5kdfxXTH/df8bIaVmhOJJC2ZFhns0QxQ5VrpaHn/FTD4brt75RouLylnDMhxsKYDm8hVA== X-Received: by 2002:a5d:4d4a:: with SMTP id a10mr40263216wru.220.1574944322481; Thu, 28 Nov 2019 04:32:02 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u3sm8499328wmm.45.2019.11.28.04.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 04:32:01 -0800 (PST) Date: Thu, 28 Nov 2019 12:32:00 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms v2 3/8] Platform/Overdrive: fix a typo in the DT Message-ID: <20191128123200.GN7359@bivouac.eciton.net> References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-4-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191127184439.16793-4-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote: > DT unit addresses are hex quantities but they should not include > the 0x prefix. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm But can you clarify in commit message that this is a cosmetic/style change only? (And maybe mirror this cleanup in Platform/SoftIron/Overdrive1000Board/FdtBlob/styx-overdrive1000.dts ? These appear to be the only two instances in the repo.) / Leif > --- > Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > index 1d8a6caafd82..a92ab695fb2e 100644 > --- a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > +++ b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > @@ -291,7 +291,7 @@ > dma-coherent; > }; > > - ccn@0xe8000000 { > + ccn@e8000000 { > compatible = "arm,ccn-504"; > reg = <0x0 0xe8000000 0x0 0x1000000>; > interrupts = <0x0 0x17c 0x4>; > -- > 2.17.1 >