From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.6407.1574948278402636185 for ; Thu, 28 Nov 2019 05:37:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=GVm6GAYA; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id w15so208718wru.4 for ; Thu, 28 Nov 2019 05:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZF7XwpjYliyoOXVbpt/er0m3YGmjxSKM64CNLaq4j2w=; b=GVm6GAYAyR5Q/8QUdNMqSaarm92P+aq2Wt9l2NFCXt4R3S1QkpzX1ScUTUtuCubJHF od9OIcb4Rd2LjIT0DV50zaKmfumrJPY34O48INuOkNkMM+nlKwNLGmKnrxy1phqKLDjc seqcv6C//4BZGbWtJckmUpOg8c7x4uvERA29hiyrmieSUTF1lLX/qdTV8QfBYLcCMXkz Qdbw0Rn1jp9lWqIaZH9PbWFqEdhcIAdS8+HZRbUY8KF4aGJB/C7og+yPxx3jNaCB3OWv e3zSOWibaTiiIpuy1gxkt21Y29THZEt37f9puRHfpCDiTK0zsFx104lq91AxbUPnDlu8 7ZVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZF7XwpjYliyoOXVbpt/er0m3YGmjxSKM64CNLaq4j2w=; b=lOTslo74SVVrpNX7MIQSYbSNgFfwyUnd+UPl1BLfjwKqlB+Ra2tbJKQRLHJGTvPGS2 yBhj/cJJmZ02pPyGU6cVW1qgcBVziXlDsznPy3VvQyEp4e7in70uiJcRbmq+51QoRcG+ 2xYqO0VWDNIW9pHYO4pNHesR0v1mMC1ccKlrKtRtvpsldIxEMBY946U7ZtlC09X27H9M PwESS9ZTegIRnQyUsqH6rMtT80rw6o0nvOHL9eWAXWbdDfJGQrLan/aJhJPqBNtUbbSR Ym4W0gnMHmpBgU1sRR8QRohMz+WsFruMwLJYCXp7XV/gaF22iCUXJZExlOdYKqAkKTDz vCCQ== X-Gm-Message-State: APjAAAXO6na9FL7XT8wEwuB4XpgVa/sHPnQQLeMy4a+vMfZDIlwKzHzL vpjoy+ahPO0C4omeZhkWsy7C2Q== X-Google-Smtp-Source: APXvYqynTapbR+CVLTH6Dob9PhQxxHNxxwyxaHI+Pne/NrfYsOIEe9AwM44ghB8EnJwXdZDZexBXBg== X-Received: by 2002:a5d:460b:: with SMTP id t11mr49913305wrq.185.1574948276868; Thu, 28 Nov 2019 05:37:56 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 13sm10260579wmk.1.2019.11.28.05.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 05:37:55 -0800 (PST) Date: Thu, 28 Nov 2019 13:37:54 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms v2 7/8] Silicon/AMD/StyxDtbLoaderLib: use Cortex-A57 IDs instead of generic ARMv8 Message-ID: <20191128133754.GQ7359@bivouac.eciton.net> References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-8-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191127184439.16793-8-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote: > Use the more precise Cortex-A57 based compatible strings to describe > the CPUs and the PMUs in the device tree. > > Signed-off-by: Ard Biesheuvel > --- > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > index e723e77c7965..091d151ac722 100644 > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > @@ -405,7 +405,7 @@ PrepareFdt ( > ArmCoreInfoTable[Index].CoreId); > MpId = cpu_to_fdt64 (MpId); > fdt_setprop (Fdt, CpuNode, "reg", &MpId, sizeof (MpId)); > - fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,armv8"); > + fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,cortex-a57"); > fdt_setprop_string (Fdt, CpuNode, "device_type", "cpu"); > > fdt_setprop_cell (Fdt, CpuNode, "i-cache-size", 3 * SIZE_16KB); > @@ -474,7 +474,7 @@ PrepareFdt ( > // Create /pmu node > PmuNode = fdt_add_subnode(Fdt, 0, "pmu"); > if (PmuNode >= 0) { > - fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,armv8-pmuv3"); > + fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,cortex-a57-pmu"); Since we've always only published "arm,armv8-pmuv3" before, is it worth keeping that around as a secondary compatible string rather than replacing it outright? / Leif > // append PMU interrupts > for (Index = 0; Index < ArmCoreCount; Index++) { > -- > 2.17.1 >