From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.6606.1574948311027703051 for ; Thu, 28 Nov 2019 05:38:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=pHdO/F6c; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id l1so11014484wme.2 for ; Thu, 28 Nov 2019 05:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cm58FP7/3DSjcq/0hzptrCvvraamXJs0wySbiyOzKW0=; b=pHdO/F6cnRiPlrBU/RGlpPRn+vv/6e3PS+iZcqGu4HcaYY5S24xMBJ48IRO8fY5Bnl QVFf/rbl/qsTABDXVwR/TU10OIW7P6DfhHjobp7mvFDLXC5FowxsLCclD5/cy7mQUFfI Hwc7IW9FDpmftGVxhw+nAf4BDsfiBqIGzzqDDrh3xebeXQK8m9Q9m1gEssYParNTF+Ag +dx+ZYIvFSkQnZNNp+lamLtAJm7OhQjnoE+cMDP9/4LNXMv//vQY+piMGoYxgSyEgRrR kHa34cvxyckE2oZm4xWbW6Nlpo6P1mQA1c9X3mXkCYIUBHSLy/GjpFYWpG740dW2QhGr SHWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cm58FP7/3DSjcq/0hzptrCvvraamXJs0wySbiyOzKW0=; b=TtuF7SqJ7vduQntrAPcZXcYB6ft8Br5GdoTnfs8YPdKxel2HwDhFJUTQhqO3Dupxkd AOH5W4LyYFWVzzO43IcseXLe5AOO2jkqRUgammbmMNRzQMQ0wA/touQ9FG+fIVuO6dav iziYxjDjpCXABskbPGU+V+ET3jGc3HW3GkSgpyCECvctJKpwWFU1L07REXQvyIJU30sz rK5LYnCKRF3SAHe49ttiRoGNyUrBsatGLt1O6kIRNyWvM7VhgEXWl8z10FbY2/p2dGnN JD6rRywjY7xiUBk9nXR6T92UkY0bdAlV8dzizJt/acZOUbcC4FwvNVPHml3Zj36OihtO wIFQ== X-Gm-Message-State: APjAAAV42PkXoDqvSAskT7kYynKA869D1yanmvdXMdV3CvH1QCet0sve 5bzBT5G+1jjknLsm2zcjNsHfQg== X-Google-Smtp-Source: APXvYqx4/uF6QDxIXl0jYKl+tcWbJLEpnft3hP9KHcUU22QmxKMpHzbrIyAzPNK+Yu5Q4R8l6K2NKQ== X-Received: by 2002:a1c:6405:: with SMTP id y5mr10275707wmb.175.1574948309443; Thu, 28 Nov 2019 05:38:29 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f6sm23820064wrr.15.2019.11.28.05.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 05:38:28 -0800 (PST) Date: Thu, 28 Nov 2019 13:38:27 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms v2 8/8] Silicon/AMD/StyxDtbLoaderLib: omit linux,phandle properties Message-ID: <20191128133827.GR7359@bivouac.eciton.net> References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-9-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191127184439.16793-9-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 27, 2019 at 19:44:39 +0100, Ard Biesheuvel wrote: > The linux,phandle property is a deprecated alias for the phandle property > which was standardized long ago, so don't bother emitting it. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > index 091d151ac722..6ce694573f9f 100644 > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > @@ -397,7 +397,6 @@ PrepareFdt ( > } > Phandle[Index] = fdt_alloc_phandle (Fdt); > fdt_setprop_cell (Fdt, CpuNode, "phandle", Phandle[Index]); > - fdt_setprop_cell (Fdt, CpuNode, "linux,phandle", Phandle[Index]); > > fdt_setprop_string (Fdt, CpuNode, "enable-method", "psci"); > > -- > 2.17.1 >