From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.6618.1574948408572224629 for ; Thu, 28 Nov 2019 05:40:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=zaZLLfnt; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id i12so31094624wrn.11 for ; Thu, 28 Nov 2019 05:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oE9FrgVow1giikh7xpV26KR9IG7AGO/GrdLT+ZyP7Oo=; b=zaZLLfntCqZzorjUgaeIq+STbqLAwen8L6hmTYx7l4eqXH+80+wNW1Soys2uz1RNPF rZOTHxHeLmsZB+8FrLGTIDThRs4ZiUXDla4g8/ulOqjh6OkKo0LSAlpPcZBJ8hH1VRFh PTnXxeFd3m/iybwwQXAw0U7s+k+mmDv/wftXAMxEBqO+uDNcdsQc9SdBh79qpky5K0TY 4EHGCunblfdFH9fwHbyaac933eEfDB09S9VCN0mD7pvpzIV5nxNpvgMkDL5MF9SJhFDO E6fkPJvQgmfkf6wwcG1oHbZ/YC3sv2Er+rrn9YAl53pBpfDqY2g5tYybx9Bcdtdj4q+W E8TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oE9FrgVow1giikh7xpV26KR9IG7AGO/GrdLT+ZyP7Oo=; b=GoDZ1gxaFJJUbesCOLJGruIOre8pM9mcwZTabe5QCDl4JUygH0m6G9E5mRn1z/ixV2 ++tOlsEb2IT5kcltp4Ps53pPBQfDV6Zc9/I/FgcodrIkPeXBhcwXk1W+SZhO90B0cn8b 1W4Yr+Ev8bCVWP2YnKtvQSx+CDAaEMxI33Q3iA8TYa+wZkl/7PW9cWjOfGnX24PcHLgB gxGExuWfzwJvCUVDwaUq++s+c4y8EBazEinXB9lgjFlhfzSIAN73QbFzQchIBZ/nFDsS bZ1w/cxDLuTOHkoh0RzGWt+GCijybGG4U83oVXrUGugZskG3hiSmrct6+6vUZK3uRU0z RyLg== X-Gm-Message-State: APjAAAWkT9XGcsGleHmQ/Ya7Btiu7nHyw7ecYZ6LGoGBvPNiqvZaonLx MQnUDOV6E4EjP3F+o82RLjwXrw== X-Google-Smtp-Source: APXvYqxFimjAPyfOJPXyNyG09rGdXe/+HqihsWbfAdXo76AlBjsHIbXGog8a93RhrHqMuePWf1RsRg== X-Received: by 2002:a5d:528e:: with SMTP id c14mr13656662wrv.308.1574948407002; Thu, 28 Nov 2019 05:40:07 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u22sm4280495wru.30.2019.11.28.05.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 05:40:06 -0800 (PST) Date: Thu, 28 Nov 2019 13:40:04 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io Subject: Re: [PATCH edk2-platforms v2 7/8] Silicon/AMD/StyxDtbLoaderLib: use Cortex-A57 IDs instead of generic ARMv8 Message-ID: <20191128134004.GS7359@bivouac.eciton.net> References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-8-ard.biesheuvel@linaro.org> <20191128133754.GQ7359@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 28, 2019 at 14:39:23 +0100, Ard Biesheuvel wrote: > On Thu, 28 Nov 2019 at 14:37, Leif Lindholm wrote: > > > > On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote: > > > Use the more precise Cortex-A57 based compatible strings to describe > > > the CPUs and the PMUs in the device tree. > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > > index e723e77c7965..091d151ac722 100644 > > > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > > @@ -405,7 +405,7 @@ PrepareFdt ( > > > ArmCoreInfoTable[Index].CoreId); > > > MpId = cpu_to_fdt64 (MpId); > > > fdt_setprop (Fdt, CpuNode, "reg", &MpId, sizeof (MpId)); > > > - fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,armv8"); > > > + fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,cortex-a57"); > > > fdt_setprop_string (Fdt, CpuNode, "device_type", "cpu"); > > > > > > fdt_setprop_cell (Fdt, CpuNode, "i-cache-size", 3 * SIZE_16KB); > > > @@ -474,7 +474,7 @@ PrepareFdt ( > > > // Create /pmu node > > > PmuNode = fdt_add_subnode(Fdt, 0, "pmu"); > > > if (PmuNode >= 0) { > > > - fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,armv8-pmuv3"); > > > + fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,cortex-a57-pmu"); > > > > Since we've always only published "arm,armv8-pmuv3" before, is it > > worth keeping that around as a secondary compatible string rather > > than replacing it outright? > > Yeah, good point. I'll change that. Thanks. With that: Reviewed-by: Leif Lindholm