public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache
Date: Thu, 28 Nov 2019 15:48:40 +0100	[thread overview]
Message-ID: <20191128144840.25654-2-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20191128144840.25654-1-ard.biesheuvel@linaro.org>

The variable runtime cache for SMM enabled implementations of the
variable runtime DXE driver was introduced after the standalone
MM based implementation was merged for the DeveloperBox platform.

This means the combined binary image of ARM Trusted Firmware and
the standalone MM runtime we carry in edk2-non-osi predates this
feature, so we need to disable it when building the non-secure side
when incorporating the prebuilt binary.

Whether it makes sense to enable the runtime cache for this platform
is a different question, so let's keep it enabled entirely until
someone identifies a need for it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
index a10e48ca07ea..084b4c994b97 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
@@ -130,6 +130,8 @@ [PcdsFeatureFlag]
   # needed for NFIT tables installed by RamDiskDxe
   gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
 
+  gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE
+
 [PcdsFixedAtBuild.common]
 !ifdef $(FIRMWARE_VENDOR)
   gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"$(FIRMWARE_VENDOR)"
-- 
2.20.1


  reply	other threads:[~2019-11-28 14:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 14:48 [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Ard Biesheuvel
2019-11-28 14:48 ` Ard Biesheuvel [this message]
2019-11-28 15:01   ` [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache Leif Lindholm
2019-11-28 15:04     ` Ard Biesheuvel
2019-11-28 15:20       ` [edk2-devel] " Leif Lindholm
2019-11-28 14:56 ` [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Leif Lindholm
2019-11-28 14:59   ` Ard Biesheuvel
2019-11-28 15:19     ` Leif Lindholm
2019-11-28 15:58       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128144840.25654-2-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox