From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.7278.1574952978600665213 for ; Thu, 28 Nov 2019 06:56:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=k0FxkaTt; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id a131so6939271wme.5 for ; Thu, 28 Nov 2019 06:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MLW0MJXjKxXkftxfYiwggAZBRsBN/An9g1wlE+dYV7g=; b=k0FxkaTt/nAKNeTftOgP9N+X1GNBBEnfFl6rVnFmqPd0+AXKq+y69YEv8w+fAfa8LK K6jJMiGTC2B66fMVxrFI6t3OEBJOjgf+kQ+VcrSrtSBjO0O2Aj+mFz7NruBrDrTHquI5 xNtgo30Fpdq8iuCMLBMjtqLxdBc8Pph75Txl2/da7vbSsXboT6cYJ7tOpJIfMzywYlzz o4v8LpxQU9RxsiIiSxLNCigRFLtVvrB5T0zY3TXOWHWauXoEZk+Oye/xrvKMH5A6YzFP 5HuBYafrszjErp9vcIA7sMViJKKK+mDM8J86Jkm1JUpQLBDY64pvjrkB91YDQqcTF4p1 Rk9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MLW0MJXjKxXkftxfYiwggAZBRsBN/An9g1wlE+dYV7g=; b=LY0Su8GWZcaJxMKmRcZXz0LAjNVb3GyC+S7EDBKUhJpdifLYY566PQyiCVUx/j/2Gl mPq/aCWNZUF5HTqe4xHBeDOUT5svDEe0MZhLyvAUTKwkFmZhtPG7iu+PyppE/vOYyHH+ xdAUS1XDPjVl2VRzH6bEMFYDJZDGntl9kJsS8QM1R9fsY/LVmvqN5z9Iut6p8sOvBBoG apwmV5GjmcaQWK8pFPO5iRiZjpJtyV4JZT4YN6VRBaB9S5kfKFIgbcfMnub8/rKg3Vw/ 0fRjnIiD40vbCF7MD43riQATbWTorp+1dSBOjIbsfNih3drPXxreiaXfMdppqMZFezf7 pIJA== X-Gm-Message-State: APjAAAWtd6FffHQtagmMxHtmra3AFkNL7Q5P3Udekay8UUsqo7egdwgU cLUCzLM9UG6qEydCo5kO0acZAA== X-Google-Smtp-Source: APXvYqwYPjw+AmJmVC6N57VmvSxlPi1lRnoe7BMipxqQtBIu4H60qqs26ZJ0ZCa69StrUEQDOYaUOg== X-Received: by 2002:a1c:152:: with SMTP id 79mr9637552wmb.70.1574952976959; Thu, 28 Nov 2019 06:56:16 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t5sm7183wrr.35.2019.11.28.06.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 06:56:16 -0800 (PST) Date: Thu, 28 Nov 2019 14:56:14 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Message-ID: <20191128145614.GT7359@bivouac.eciton.net> References: <20191128144840.25654-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191128144840.25654-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 28, 2019 at 15:48:39 +0100, Ard Biesheuvel wrote: > We switched to cache coherent DMA for the NETSEC network controller ages > ago, but the platform driver that registers the non-discoverable device > currently does not reflect this change, which we haven't noticed since > the driver doesn't look at this flag. Should the drive look at this flag? > Let's fix this nonetheless, in case it ever matters. > > Signed-off-by: Ard Biesheuvel This patch clearly makes sense anyway, so: Reviewed-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > index 73cc560fa8d8..57f8fa90343a 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > @@ -130,7 +130,7 @@ RegisterDevice ( > } > > Device->Type = TypeGuid; > - Device->DmaType = NonDiscoverableDeviceDmaTypeNonCoherent; > + Device->DmaType = NonDiscoverableDeviceDmaTypeCoherent; > Device->Resources = Desc; > > Status = gBS->InstallMultipleProtocolInterfaces (Handle, > -- > 2.20.1 >