public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent
@ 2019-11-28 14:48 Ard Biesheuvel
  2019-11-28 14:48 ` [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache Ard Biesheuvel
  2019-11-28 14:56 ` [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Leif Lindholm
  0 siblings, 2 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2019-11-28 14:48 UTC (permalink / raw)
  To: devel; +Cc: leif.lindholm, Ard Biesheuvel

We switched to cache coherent DMA for the NETSEC network controller ages
ago, but the platform driver that registers the non-discoverable device
currently does not reflect this change, which we haven't noticed since
the driver doesn't look at this flag.

Let's fix this nonetheless, in case it ever matters.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
index 73cc560fa8d8..57f8fa90343a 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
@@ -130,7 +130,7 @@ RegisterDevice (
   }
 
   Device->Type = TypeGuid;
-  Device->DmaType = NonDiscoverableDeviceDmaTypeNonCoherent;
+  Device->DmaType = NonDiscoverableDeviceDmaTypeCoherent;
   Device->Resources = Desc;
 
   Status = gBS->InstallMultipleProtocolInterfaces (Handle,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-11-28 15:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-28 14:48 [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Ard Biesheuvel
2019-11-28 14:48 ` [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache Ard Biesheuvel
2019-11-28 15:01   ` Leif Lindholm
2019-11-28 15:04     ` Ard Biesheuvel
2019-11-28 15:20       ` [edk2-devel] " Leif Lindholm
2019-11-28 14:56 ` [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent Leif Lindholm
2019-11-28 14:59   ` Ard Biesheuvel
2019-11-28 15:19     ` Leif Lindholm
2019-11-28 15:58       ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox