From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.7604.1574953376553655147 for ; Thu, 28 Nov 2019 07:02:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JiyDsXN7; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id g206so11305076wme.1 for ; Thu, 28 Nov 2019 07:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DPFZjNhIWFa0aIjQFTiLEevyjiISfHczy8jyxOZoucU=; b=JiyDsXN7o5q3TsxyGnAcpe8kSkuV0T4YxvDRWZxC/pjXV9Ul2tkvz6ek4ylugdN3IH w/gQ6o6sHDZGjRNRjRjDXqvHtj9NFZLLalJRjCMjLm+H+/DmaoaVFSZ6naXVeOQeO7ag LRV4puQgaVhGI37uiT7n3vQnreh2NiUUHPNmr04JxYq40UgcRBHoqSSkZ01ITUvAWcAO 5CRYisSvEXPuHHCehTwuwVumaaHRjF77e9qed4EFONjJc3rrT+ebyR/ajLSdKUEumJd0 rWGJOfU/dsFurhjDRbPz/DkpZqtmW1pXDkPotQRQl2VOqFasNbNfxxMyxfAUMJb2+eDf nh8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DPFZjNhIWFa0aIjQFTiLEevyjiISfHczy8jyxOZoucU=; b=jXCzNIQUyCLxkitfBGtRYZKEw8tHNt5d5o+8/0HtIlYYUvohdPUOQ017tm9SHn6qf1 1MfdS5t1mkhu/yxEnjGX1CdI+PJSAYv66t4dIXsLyFUOFnwzOeF6Po70C9jB0SFr6iQF NHc3WU3TiC1fxE9vYC2JOadxUpLRME0Rlq5Ab5mD14XAgYrRFAaUN2lg6z/BNAo8pToP mvj93bTv8lafKZgztU2hT0EBc5UYPr4kStRP+7/qsQyabQ+6h18nzyWUf+TxGvySRkyW Qxey+HebSy+4ZD2VdRZ3mrq/4wGxCio101fDqYk0SBq3RkzXNZTZc5KdXXfHH/OsyxpQ KU+Q== X-Gm-Message-State: APjAAAXAbJOXXBSpLtIClsfgO8PFCQk4WpsM+bpKIslva9kOHRiwyo6o OQ8a5DTt+u6J9yoGEFNx/N+WjA== X-Google-Smtp-Source: APXvYqzJKP3Onfdw8Y4mPX2O8uOmziuI50iEIXNLSaEaMUIURgISv3uhSXveM2unnM4DP+jwYBV7Tg== X-Received: by 2002:a1c:20c6:: with SMTP id g189mr10559761wmg.6.1574953374928; Thu, 28 Nov 2019 07:02:54 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y20sm2424263wmi.25.2019.11.28.07.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 07:02:17 -0800 (PST) Date: Thu, 28 Nov 2019 15:01:57 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache Message-ID: <20191128150157.GU7359@bivouac.eciton.net> References: <20191128144840.25654-1-ard.biesheuvel@linaro.org> <20191128144840.25654-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191128144840.25654-2-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote: > The variable runtime cache for SMM enabled implementations of the > variable runtime DXE driver was introduced after the standalone > MM based implementation was merged for the DeveloperBox platform. > > This means the combined binary image of ARM Trusted Firmware and > the standalone MM runtime we carry in edk2-non-osi predates this > feature, so we need to disable it when building the non-secure side > when incorporating the prebuilt binary. Is this something that needs to be explicitly disabled in current upstream TF? (And if so, could we add a comment to edk2-non-osi README?) Or does this only affect the requests made from Non-secure side? > Whether it makes sense to enable the runtime cache for this platform > is a different question, so let's keep it enabled entirely until enabled -> disabled? / Leif > someone identifies a need for it. > > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > index a10e48ca07ea..084b4c994b97 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > @@ -130,6 +130,8 @@ [PcdsFeatureFlag] > # needed for NFIT tables installed by RamDiskDxe > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE > + > [PcdsFixedAtBuild.common] > !ifdef $(FIRMWARE_VENDOR) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"$(FIRMWARE_VENDOR)" > -- > 2.20.1 >