From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.7895.1574954452232919364 for ; Thu, 28 Nov 2019 07:20:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LjhneyEI; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id b18so31601512wrj.8 for ; Thu, 28 Nov 2019 07:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6vb1ASq1o/Db1Zs4VOwnGXDZoEYxFYrTtbMJjq32pp4=; b=LjhneyEIhaV1nmEM3JzDU3MJUUNdptqpqXGFVUVtm+eM/z4yO5VvgKk+iuOrYC1jMx b6ClbG1f5twQeZZyFPHEE6dwvpTOJzlLhd5gd1g20t02l+8ON3T1UtTauQ3Y8Y/Ub6MC fKe3vvdhZZUvnR/54U2HYjs2kyj8TmyhBgIA4QeCEhQCtuFWID9wsCQvU9CNXCsp2RnV flvkbsjgdLfVnEyOSK3wKf+XpEtUDYpLfyZTHayNdS0/rVvpBhBJhpAYKMQlXFjudM4q RVwZcxK0eqorw4u8rbdPOu+zwn1OB1N7H6Ca7WrJPzGWVkdOUjR+5PJpklPgfW9Lq71N I4Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6vb1ASq1o/Db1Zs4VOwnGXDZoEYxFYrTtbMJjq32pp4=; b=TtuUCq4XV1BIJmF7NjBLcOIEk6idIDKUSqoP0irqMD7pl2HN2LSBZTCfl88FreZcD2 +1+Wd0fjUgdnOW2hti4m3N9jhf2XbjAPgeIy0OfwePBtybMlSmGk4Ny0hqvEqrikPH9F 7YJEoXJiOlvGrh7tTdEvRkHOFDPDAVp+0bzEZNVJShv6OMo2JV2f2tBk6lklnJJatkm/ oYRel/M6WHMYZz+AEe4mguIcUZj6OL4Sa78HtWvdgGRl9VieLn4Drsq/6284CMm0IAH6 /HgkT8kMUcsppBLCWEqbfeBfzp2p6QpEzA/+QT91mUBRXUXeCcAH4JIFC9bzH5093Zfu 20Fg== X-Gm-Message-State: APjAAAXLOCBpLVni8ium9dYhEqtNY6sOmlw0Fka2LeCCwqssYqilRA8F yS8m/tOHJNmZQ5TERpsWNTJGb40xdL0= X-Google-Smtp-Source: APXvYqwh7FVvfm8yFOLjsMFfALJg7vmEJZRr4bHmiGcCNZYAYGpCLs9egHNI16hdgA35sbelJOyrlA== X-Received: by 2002:a5d:5687:: with SMTP id f7mr18853014wrv.384.1574954450122; Thu, 28 Nov 2019 07:20:50 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g74sm10353448wme.5.2019.11.28.07.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 07:20:49 -0800 (PST) Date: Thu, 28 Nov 2019 15:20:47 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache Message-ID: <20191128152047.GW7359@bivouac.eciton.net> References: <20191128144840.25654-1-ard.biesheuvel@linaro.org> <20191128144840.25654-2-ard.biesheuvel@linaro.org> <20191128150157.GU7359@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 28, 2019 at 16:04:29 +0100, Ard Biesheuvel wrote: > On Thu, 28 Nov 2019 at 16:02, Leif Lindholm wrote: > > > > On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote: > > > The variable runtime cache for SMM enabled implementations of the > > > variable runtime DXE driver was introduced after the standalone > > > MM based implementation was merged for the DeveloperBox platform. > > > > > > This means the combined binary image of ARM Trusted Firmware and > > > the standalone MM runtime we carry in edk2-non-osi predates this > > > feature, so we need to disable it when building the non-secure side > > > when incorporating the prebuilt binary. > > > > Is this something that needs to be explicitly disabled in current > > upstream TF? (And if so, could we add a comment to edk2-non-osi > > README?) Or does this only affect the requests made from Non-secure > > side? > > No, it has to be disabled on both sides. But this .dsc.inc gets > included by both sides when you build them from scratch. Oh, right. That's fine then. > > > Whether it makes sense to enable the runtime cache for this platform > > > is a different question, so let's keep it enabled entirely until > > > > enabled -> disabled? > > Yep With that: Reviewed-by: Leif Lindholm > > > > > someone identifies a need for it. > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > index a10e48ca07ea..084b4c994b97 100644 > > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > @@ -130,6 +130,8 @@ [PcdsFeatureFlag] > > > # needed for NFIT tables installed by RamDiskDxe > > > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE > > > + > > > [PcdsFixedAtBuild.common] > > > !ifdef $(FIRMWARE_VENDOR) > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"$(FIRMWARE_VENDOR)" > > > -- > > > 2.20.1 > > > > > >