From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.7088.1575026970439360056 for ; Fri, 29 Nov 2019 03:29:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=rZ+yrrZp; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id t2so34703581wrr.1 for ; Fri, 29 Nov 2019 03:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vGWvsuKaueo3HPtzEv6afXxNIQc/9Sq3p1g7tqGig+E=; b=rZ+yrrZpHyH+Q2jG26+TMkBW7UvUFFkVAIUVeuAOMvmLlL60xEVTV0yU1IzfGUQOHQ EUOWZrIBxjGg98t+1EPqSGzOG1TOS8dkhzXFRGwO8wiYX7ESM2hrg4xXqy4jazg29dtm dOrCXg7OActVhSDX697HnWTGd0duvwy6Eww1MXcgbhjshNPKvNalXV9i6PQyfSLy3T7D z8ykz6QeMKtdXxCiPFOxU9fYjlBppaMO7BhC+T/R0//lR1oGAgiIWxRHmZCiuo4Jsf+h pBo9gsMHzLRTBfizSTHRIwhAmJGTET4TZI5e3OngmbFsUMzTBLb2jU/INC4yMryVPgbj 1H5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vGWvsuKaueo3HPtzEv6afXxNIQc/9Sq3p1g7tqGig+E=; b=SekNsHb+uMxUXeyXF6nrgycWn87H8NtsqtGBFmAROrbfoHqKcRbJ10GGPN4UFw+CAp SLkOhsltnLKIYlJGKawrBzd0DTIVAH09ygf3lqz81GpLg418VHoyTSuzuBDhlnXtPsY6 FP9C6oK/Cr87He3sESHGmPXvfaC6SX27yj/EHmHTP0lu2Q/aVGM8bBSDV9eiLa0GBBil MJSDXJe+uvQYySomUofntfo3izBCr2LVEWWpi8yiImGhORpyInmTxgGQ3GA2K9MHe4at pOAxtq+4WxE4wrXlj8HOcqXQEykoRp5XHmsA3O+EzYc+b2o6aop8my7mJHqLg0R8mtLV X6jA== X-Gm-Message-State: APjAAAX7n96DMIYMZfPcu2/2jEJuDEs9fSsZDFEaoqFA11pnAvbZvPVZ GgUCsbZ0Tki7c9FDZxHrfrwxww== X-Google-Smtp-Source: APXvYqyjKL1a/qNuWlEvT0P+QYTFBIH9SqmV5YLw8NtXaKxul/Oorij37KkdXh2QeMv712ECL3OLgg== X-Received: by 2002:a05:6000:11c6:: with SMTP id i6mr3647746wrx.178.1575026968727; Fri, 29 Nov 2019 03:29:28 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b2sm27423651wrr.76.2019.11.29.03.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 03:29:27 -0800 (PST) Date: Fri, 29 Nov 2019 11:29:26 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode Message-ID: <20191129112926.GA7359@bivouac.eciton.net> References: <20191129104716.819-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20191129104716.819-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > the code in patch #2 to expose a SSDT with a device node describing > OP-TEE when booting in ACPI mode and OP-TEE is present. If we need any more SSDTs for this platform in future, I'll probably start grumbling about refactoring away the per-table global variables, but I guess it would be a bit overkill at this point... For the series: Reviewed-by: Leif Lindholm > Ard Biesheuvel (2): > Silicon/SynQuacer/PlatformDxe: move EMMC SSDT handling to core routine > Silicon/SynQuacer/PlatformDxe: add ACPI device node for OP-TEE if > present > > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > .../SynQuacer/Drivers/PlatformDxe/Emmc.c | 55 ------------ > .../SynQuacer/Drivers/PlatformDxe/Optee.asl | 23 +++++ > .../Drivers/PlatformDxe/PlatformDxe.c | 83 +++++++++++++++++++ > .../Drivers/PlatformDxe/PlatformDxe.h | 2 + > .../Drivers/PlatformDxe/PlatformDxe.inf | 2 + > 6 files changed, 111 insertions(+), 55 deletions(-) > create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl > > -- > 2.17.1 >