From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.95.1575288163190425545 for ; Mon, 02 Dec 2019 04:02:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=fKO32kYH; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id g17so11861029wro.2 for ; Mon, 02 Dec 2019 04:02:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P184gUg06qp++DKUAhZuBKCnMxJ6EFNcllTHQ6oA4Vc=; b=fKO32kYHQULgwXkE3vEwYGj2FOrVMMPPKyOM9O+fw22DHcR8ZReXgBAaS7sLfZ/N4s engEgZn03zjCrFjiJIDUVhx3WEjEUu1rOW6zPkdaV3Z/evz/MyA1F8B5KmLK9jMDAGzP GpIJAeSUlNbZI2fkJr2lMXkZ+F+7bO+mYDWJCLIZZYHJjoWLd3LQeGhHySN1kDTZ0u+j dXLOX78hyGEc8lf29MREVaiGy6jiOFVwYolvm1izKJ142La5Yt3C9k+sEH7871NGvHqz LuhWEm3tUda+z0iu2T/JYu/ueRcOoN5EFOjAqraBt0jzhGV9IIaqD1m1FOBR9Q8k8hXn T78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P184gUg06qp++DKUAhZuBKCnMxJ6EFNcllTHQ6oA4Vc=; b=KQShHSWEcGsF2NrpGkAfF515JdDf850fk7vBIeoSn/U4zC8AtCxHvQOtsKlfENNzFC o3C760FfNLWeQDiHbs7Zu1NTQEL4N5KacSkBNNnxXJQwI70pFjNQcWYZNhyrUNr/CsOS BEXarwaXfGMg5Ee7mY3J53ewfBA6Hr/TZOnAbgt1DoRbWCh0Ih6y/pSOPQu4snOxadyy /wGHPDxRMhE3z+FqLH9ztmecdcQGNdi33PR/TuXdCv5cvmUNZ94fdEWb4YXhZCxk9I0O HvwNPuxFyGgQjzFZXyRjB9jLRD3MbNz4E/roROBZVjNebJSzW+7XLVPwv3L1ogS4pJdI phGQ== X-Gm-Message-State: APjAAAWnAbdxBEevEk1jGJjNRUvILkI2X0HIaAFhTYBDFyMC1uBz60Nu S9Qexta/AlhO7HB3FfiY95MM2Q== X-Google-Smtp-Source: APXvYqz1AtMkSEaOee9AouohFcO6vXpnnf6bi4uWw6IIjsU+nA3uCecm//qEzVcejojE7FZ/k9JCIw== X-Received: by 2002:adf:f18b:: with SMTP id h11mr16941891wro.56.1575288161740; Mon, 02 Dec 2019 04:02:41 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 11sm24720214wmb.34.2019.12.02.04.02.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 04:02:40 -0800 (PST) Date: Mon, 2 Dec 2019 12:02:39 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode Message-ID: <20191202120239.GB7359@bivouac.eciton.net> References: <20191129104716.819-1-ard.biesheuvel@linaro.org> <20191129112926.GA7359@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote: > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel wrote: > > > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm wrote: > > > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote: > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in > > > > the code in patch #2 to expose a SSDT with a device node describing > > > > OP-TEE when booting in ACPI mode and OP-TEE is present. > > > > > > If we need any more SSDTs for this platform in future, I'll probably > > > start grumbling about refactoring away the per-table global variables, > > > but I guess it would be a bit overkill at this point... > > > > > > > Yeah, the thought crossed my mind as well, but let's defer that to the > > next time. > > > > > For the series: > > > Reviewed-by: Leif Lindholm > > > > > > > Actually, I need to apply this on top > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c > @@ -282,13 +282,16 @@ InstallAcpiTables ( > return; > } > > + if (mEmmcSsdtSize > 0) { > Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize, > &TableKey); Indentation presumably added for clarity? > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n", > __FUNCTION__, Status)); > } > + } > > + if (mTos0SsdtSize > 0) { > Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize, > &TableKey); > if (EFI_ERROR (Status)) { > @@ -296,6 +299,7 @@ InstallAcpiTables ( > __FUNCTION__, Status)); > } > } > +} LGTM. Reviewed-by: Leif Lindholm > EFI_STATUS > EFIAPI > > or we will call InstallAcpiTable() with a zero size if we're only > installing one of the tables.