From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.4599.1575308013642392006 for ; Mon, 02 Dec 2019 09:33:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F9lNH90O; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575308012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jwl1ld8bhsx4mLLsWpc6pSuRpLudPrzU7TWBfaZcESo=; b=F9lNH90OS0yDlRsskxwruf0H/iqTU+oJSrudg3XTgvnASplZhQ/x4UOmxS2SXjpfbez7H7 SpQcalpSVS9OQBTQysgg30B/IDt++iIdNB6ixoujozXtX6h8m9Hff3kxBSjpP6aQdxYGg/ hfobY44EoredgLgYUTtOGh/cHvYCYC0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-n_b-80idNaiKB3L9979fAQ-1; Mon, 02 Dec 2019 12:33:29 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3664E100551C; Mon, 2 Dec 2019 17:33:28 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F6CB19C68; Mon, 2 Dec 2019 17:33:25 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Sean Brogan , "Zhiju . Fan" , Bob Feng , Bret Barkelew , Liming Gao , Michael D Kinney , Philippe Mathieu-Daude Subject: [PATCH 2/2] .pytool: Avoid "is" with a literal Python 3.8 warnings in CI plugins Date: Mon, 2 Dec 2019 18:33:09 +0100 Message-Id: <20191202173309.10411-3-philmd@redhat.com> In-Reply-To: <20191202173309.10411-1-philmd@redhat.com> References: <20191202173309.10411-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: n_b-80idNaiKB3L9979fAQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To avoid SyntaxWarning with Python 3.8, change the 'is' operator by the conventional '=3D=3D' comparator. Signed-off-by: Philippe Mathieu-Daude --- .pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py | 2 +- .pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py b/.pytool/= Plugin/DscCompleteCheck/DscCompleteCheck.py index e2485f570841..9af4f72c8de3 100644 --- a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py +++ b/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py @@ -61,7 +61,7 @@ class DscCompleteCheck(ICiBuildPlugin): abs_dsc_path =3D os.path.join(abs_pkg_path, pkgconfig["DscPath"].s= trip()) wsr_dsc_path =3D Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(a= bs_dsc_path) =20 - if abs_dsc_path is None or wsr_dsc_path is "" or not os.path.isfil= e(abs_dsc_path): + if abs_dsc_path is None or wsr_dsc_path =3D=3D "" or not os.path.i= sfile(abs_dsc_path): tc.SetSkipped() tc.LogStdError("Package Dsc not found") return 0 diff --git a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py b/.pytoo= l/Plugin/LibraryClassCheck/LibraryClassCheck.py index 5dafcbc13f8a..a62a7e912b15 100644 --- a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py +++ b/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py @@ -67,7 +67,7 @@ class LibraryClassCheck(ICiBuildPlugin): abs_dec_path =3D self.__GetPkgDec(abs_pkg_path) wsr_dec_path =3D Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(a= bs_dec_path) =20 - if abs_dec_path is None or wsr_dec_path is "" or not os.path.isfil= e(abs_dec_path): + if abs_dec_path is None or wsr_dec_path =3D=3D "" or not os.path.i= sfile(abs_dec_path): tc.SetSkipped() tc.LogStdError("No DEC file {0} in package {1}".format(abs_dec= _path, abs_pkg_path)) return -1 --=20 2.21.0