public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Steven Shi" <steven.shi@intel.com>
To: devel@edk2.groups.io
Cc: liming.gao@intel.com, bob.c.feng@intel.com
Subject: [PATCH v2 2/4] BaseTools: enhance the CacheCopyFile method arg names
Date: Tue,  3 Dec 2019 13:17:16 +0800	[thread overview]
Message-ID: <20191203051718.22508-3-steven.shi@intel.com> (raw)
In-Reply-To: <20191203051718.22508-1-steven.shi@intel.com>

Enhance the CacheCopyFile method arg names to be more
clear and readable

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Steven Shi <steven.shi@intel.com>
---
 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
index fce00c3ee7..eb52f40a9d 100755
--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
@@ -1650,9 +1650,9 @@ class ModuleAutoGen(AutoGen):
 
         self.IsAsBuiltInfCreated = True
 
-    def CacheCopyFile(self, OriginDir, CopyDir, File):
-        sub_dir = os.path.relpath(File, CopyDir)
-        destination_file = os.path.join(OriginDir, sub_dir)
+    def CacheCopyFile(self, DestDir, SourceDir, File):
+        sub_dir = os.path.relpath(File, SourceDir)
+        destination_file = os.path.join(DestDir, sub_dir)
         destination_dir = os.path.dirname(destination_file)
         CreateDirectory(destination_dir)
         try:
-- 
2.17.1


  parent reply	other threads:[~2019-12-03  5:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  5:17 [PATCH v2 0/4] BaseTools: Leverage compiler output dependency files for binary cache Steven Shi
2019-12-03  5:17 ` [PATCH v2 1/4] BaseTools: store more complete output files in " Steven Shi
2019-12-03  5:17 ` Steven Shi [this message]
2019-12-03  5:17 ` [PATCH v2 3/4] BaseTools: Leverage compiler output to optimize " Steven Shi
2019-12-03  5:17 ` [PATCH v2 4/4] BaseTools: Remove redundant binary cache file Steven Shi
2019-12-03  5:33 ` [PATCH v2 0/4] BaseTools: Leverage compiler output dependency files for binary cache Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203051718.22508-3-steven.shi@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox