From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.8438.1575389893532092057 for ; Tue, 03 Dec 2019 08:18:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CUxnIQEP; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575389892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uOxDYequx5f1CVBVGpN4hti3s9RyJWD9Vw9NA0RdQ88=; b=CUxnIQEPsk3Kktn65d6vlRTYepj9vneBF+3P9zde+JCsf/vwo2WFWMs4+JxKQjg38yTafk yRsLE6JTTvEnd53IAku/2MzObt79cYc4yVZf9+znqDVyMAtNxmVFFmTPEaWn3Wfqz3Ch+1 NJg14m6QakaQfUVDMRIRGvOWtMMQvwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-UIvlXjcsOrGWveT5av2vUw-1; Tue, 03 Dec 2019 11:18:11 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 096171005502; Tue, 3 Dec 2019 16:18:10 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-86.brq.redhat.com [10.40.204.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E845E60C80; Tue, 3 Dec 2019 16:18:07 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Antoine Coeur , Jiaxin Wu , Siyuan Fu , Maciej Rabeda , Philippe Mathieu-Daude Subject: [PATCH 33/79] NetworkPkg/Dhcp4Dxe: Fix various typos Date: Tue, 3 Dec 2019 17:15:16 +0100 Message-Id: <20191203161602.15969-34-philmd@redhat.com> In-Reply-To: <20191203161602.15969-1-philmd@redhat.com> References: <20191203161602.15969-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: UIvlXjcsOrGWveT5av2vUw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-- NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +- NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++++++------- NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +++--- NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 ++--- NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++++----- NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 ++++++++++---------- 7 files changed, 38 insertions(+), 38 deletions(-) diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h b/NetworkPkg/Dhcp4Dxe/Dhcp4D= river.h index cebde20dca5b..f6370582cbd1 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h @@ -104,7 +104,7 @@ Dhcp4DriverBindingStop ( then a new handle is created. If it is a pointer to = an existing UEFI handle, then the protocol is added to the existing UEFI hand= le. =20 - @retval EFI_SUCCES The protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available t= o create the child @@ -128,7 +128,7 @@ Dhcp4ServiceBindingCreateChild ( @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance= . @param ChildHandle Handle of the child to destroy =20 - @retval EFI_SUCCES The protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol = that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval EFI_ACCESS_DENIED The protocol could not be removed from the= ChildHandle diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h index 01283e5e17b9..0dd6b46b87d0 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h @@ -108,7 +108,7 @@ DhcpSendMessage ( /** Each DHCP service has three timer. Two of them are count down timer. One for the packet retransmission. The other is to collect the offers. - The third timer increaments the lease life which is compared to T1, T2, + The third timer increments the lease life which is compared to T1, T2, and lease to determine the time to renew and rebind the lease. DhcpOnTimerTick will be called once every second. =20 diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4O= ption.h index 393176c8996d..a58bb1b0baa8 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h @@ -81,9 +81,9 @@ typedef struct { /// /// Structure used to describe and validate the format of DHCP options. /// Type is the options' data type, such as DHCP_OPTION_INT8. MinOccur -/// is the minium occurance of this data type. MaxOccur is defined +/// is the minimum occurrence of this data type. MaxOccur is defined /// similarly. If MaxOccur is -1, it means that there is no limit on the -/// maximum occurance. Alert tells whether DHCP client should further +/// maximum occurrence. Alert tells whether DHCP client should further /// inspect the option to parse DHCP_PARAMETER. /// typedef struct { @@ -114,8 +114,8 @@ EFI_STATUS found @param[in] Context The opaque parameter for Check =20 - @retval EFI_SUCCESS The DHCP packet's options are well format= ed - @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well fo= rmated + @retval EFI_SUCCESS The DHCP packet's options are well format= ted + @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well fo= rmatted =20 **/ EFI_STATUS @@ -133,7 +133,7 @@ DhcpIterateOptions ( @param[out] Para The variable to save the DHCP paramet= ers. =20 @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the= packet. - @retval EFI_INVALID_PARAMETER The options are malformatted + @retval EFI_INVALID_PARAMETER The options are mal-formatted @retval EFI_SUCCESS The options are parsed into OptionPoint =20 **/ @@ -146,8 +146,8 @@ DhcpValidateOptions ( /** Parse the options of a DHCP packet. It supports RFC 3396: Encoding Long Options in DHCP. That is, it will combine all the option value - of all the occurances of each option. - A little bit of implemenation: + of all the occurrences of each option. + A little bit of implementation: It adopts the "Key indexed counting" algorithm. First, it allocates an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded as a UINT8. It then iterates the DHCP packet to get data length of @@ -167,7 +167,7 @@ DhcpValidateOptions ( =20 @retval EFI_NOT_FOUND Cannot find any option. @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the pa= cket. - @retval EFI_INVALID_PARAMETER The options are malformatted + @retval EFI_INVALID_PARAMETER The options are mal-formatted @retval EFI_SUCCESS The options are parsed into OptionPoint =20 **/ @@ -211,7 +211,7 @@ DhcpAppendOption ( function. =20 @retval EFI_OUT_OF_RESOURCES Failed to allocate memory - @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatte= d + @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatt= ed @retval EFI_SUCCESS The packet is build. =20 **/ diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c b/NetworkPkg/Dhcp4Dxe/Dhcp4D= river.c index e891b6888307..970141abfe3a 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c @@ -326,7 +326,7 @@ Dhcp4DriverBindingStart ( } =20 // - // Install the Dhcp4ServiceBinding Protocol onto ControlerHandle + // Install the Dhcp4ServiceBinding Protocol onto ControllerHandle // Status =3D gBS->InstallMultipleProtocolInterfaces ( &ControllerHandle, @@ -438,7 +438,7 @@ Dhcp4DriverBindingStop ( DhcpSb =3D DHCP_SERVICE_FROM_THIS (ServiceBinding); if (!IsListEmpty (&DhcpSb->Children)) { // - // Destroy all the children instances before destory the service. + // Destroy all the children instances before destroy the service. // List =3D &DhcpSb->Children; Status =3D NetDestroyLinkList ( @@ -523,7 +523,7 @@ DhcpInitProtocol ( then a new handle is created. If it is a pointer to = an existing UEFI handle, then the protocol is added to the existing UEFI hand= le. =20 - @retval EFI_SUCCES The protocol was added to ChildHandle. + @retval EFI_SUCCESS The protocol was added to ChildHandle. @retval EFI_INVALID_PARAMETER ChildHandle is NULL. @retval EFI_OUT_OF_RESOURCES There are not enough resources available t= o create the child @@ -617,7 +617,7 @@ Dhcp4ServiceBindingCreateChild ( @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance= . @param ChildHandle Handle of the child to destroy =20 - @retval EFI_SUCCES The protocol was removed from ChildHandle. + @retval EFI_SUCCESS The protocol was removed from ChildHandle. @retval EFI_UNSUPPORTED ChildHandle does not support the protocol = that is being removed. @retval EFI_INVALID_PARAMETER Child handle is NULL. @retval EFI_ACCESS_DENIED The protocol could not be removed from the= ChildHandle diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Imp= l.c index 0b35bdf4df95..82905337908d 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c @@ -64,7 +64,7 @@ EfiDhcp4GetModeData ( not NULL. Otherwise, the state was left un= changed. @retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol d= river was not in the Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, = or Dhcp4Bound state; - Or onother instance of this EFI DHCPv4 Pro= tocol driver is already + Or another instance of this EFI DHCPv4 Pro= tocol driver is already in a valid configured state. @retval EFI_INVALID_PARAMETER Some parameter is NULL. @retval EFI_OUT_OF_RESOURCES Required system resources could not be all= ocated. @@ -611,7 +611,7 @@ DhcpYieldControl ( not NULL. Otherwise, the state was left un= changed. @retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol d= river was not in the Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, = or Dhcp4Bound state; - Or onother instance of this EFI DHCPv4 Pro= tocol driver is already + Or another instance of this EFI DHCPv4 Pro= tocol driver is already in a valid configured state. @retval EFI_INVALID_PARAMETER Some parameter is NULL. @retval EFI_OUT_OF_RESOURCES Required system resources could not be all= ocated. @@ -805,7 +805,7 @@ EfiDhcp4Start ( } =20 // - // Check Media Satus. + // Check Media Status. // MediaStatus =3D EFI_SUCCESS; NetLibDetectMediaWaitTimeout (DhcpSb->Controller, DHCP_CHECK_MEDIA_WAITI= NG_TIME, &MediaStatus); diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c index 4728b94c5803..34c72d690a31 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c @@ -604,7 +604,7 @@ DhcpEndSession ( is, all the option value that we care. =20 @retval EFI_SUCCESS The packet is successfully processed. - @retval Others Some error occured. + @retval Others Some error occurred. =20 **/ EFI_STATUS @@ -632,7 +632,7 @@ DhcpHandleSelect ( =20 // // Call the user's callback. The action according to the return is as: - // 1. EFI_SUCESS: stop waiting for more offers, select the offer now + // 1. EFI_SUCCESS: stop waiting for more offers, select the offer now // 2. EFI_NOT_READY: wait for more offers // 3. EFI_ABORTED: abort the address acquiring. // @@ -679,7 +679,7 @@ ON_EXIT: is, all the option value that we care. =20 @retval EFI_SUCCESS The packet is successfully processed. - @retval Others Some error occured. + @retval Others Some error occurred. =20 **/ EFI_STATUS @@ -772,7 +772,7 @@ ON_EXIT: is, all the option value that we care. =20 @retval EFI_SUCCESS The packet is successfully processed. - @retval Others Some error occured. + @retval Others Some error occurred. =20 **/ EFI_STATUS @@ -856,7 +856,7 @@ ON_EXIT: is, all the option value that we care. =20 @retval EFI_SUCCESS The packet is successfully processed. - @retval Others Some error occured. + @retval Others Some error occurred. =20 **/ EFI_STATUS @@ -1473,7 +1473,7 @@ DhcpRetransmit ( /** Each DHCP service has three timer. Two of them are count down timer. One for the packet retransmission. The other is to collect the offers. - The third timer increaments the lease life which is compared to T1, T2, + The third timer increments the lease life which is compared to T1, T2, and lease to determine the time to renew and rebind the lease. DhcpOnTimerTick will be called once every second. =20 diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4O= ption.c index 3b077de11177..37a63022c55f 100644 --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c @@ -195,7 +195,7 @@ DhcpOptionIsValid ( } =20 // - // Validate the occurance of the option unit is with in [MinOccur, MaxOc= cur] + // Validate the occurrence of the option unit is with in [MinOccur, MaxO= ccur] // Occur =3D Len / Unit; =20 @@ -230,7 +230,7 @@ DhcpOptionIsValid ( @param[out] Para The variable to save the interested p= arameter =20 @retval EFI_SUCCESS The DHCP option is successfully extracted= . - @retval EFI_INVALID_PARAMETER The DHCP option is malformatted + @retval EFI_INVALID_PARAMETER The DHCP option is mal-formatted =20 **/ EFI_STATUS @@ -303,7 +303,7 @@ DhcpGetParameter ( option. =20 @retval EFI_SUCCESS All the options are valid - @retval EFI_INVALID_PARAMETER The options are malformatted. + @retval EFI_INVALID_PARAMETER The options are mal-formatted. =20 **/ EFI_STATUS @@ -376,8 +376,8 @@ DhcpIterateBufferOptions ( found @param[in] Context The opaque parameter for Check =20 - @retval EFI_SUCCESS The DHCP packet's options are well format= ed - @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well fo= rmated + @retval EFI_SUCCESS The DHCP packet's options are well format= ted + @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well fo= rmatted =20 **/ EFI_STATUS @@ -438,7 +438,7 @@ DhcpIterateOptions ( =20 /** Call back function to DhcpIterateOptions to compute each option's - length. It just adds the data length of all the occurances of this + length. It just adds the data length of all the occurrences of this Tag. Context is an array of 256 DHCP_OPTION_COUNT. =20 @param[in] Tag The current option to check @@ -473,7 +473,7 @@ DhcpGetOptionLen ( =20 @param[in] Tag The option to consolidate its data @param[in] Len The length of option data - @param[in] Data The data of the option's current occu= rance + @param[in] Data The data of the option's current occu= rrence @param[in] Context The context, which is DHCP_OPTION_CON= TEXT. This array is just a wrap to pass THREE p= arameters. =20 @@ -517,8 +517,8 @@ DhcpFillOption ( /** Parse the options of a DHCP packet. It supports RFC 3396: Encoding Long Options in DHCP. That is, it will combine all the option value - of all the occurances of each option. - A little bit of implemenation: + of all the occurrences of each option. + A little bit of implementation: It adopts the "Key indexed counting" algorithm. First, it allocates an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded as a UINT8. It then iterates the DHCP packet to get data length of @@ -538,7 +538,7 @@ DhcpFillOption ( =20 @retval EFI_NOT_FOUND Cannot find any option. @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the pa= cket. - @retval EFI_INVALID_PARAMETER The options are malformatted + @retval EFI_INVALID_PARAMETER The options are mal-formatted @retval EFI_SUCCESS The options are parsed into OptionPoint =20 **/ @@ -639,7 +639,7 @@ ON_EXIT: @param[out] Para The variable to save the DHCP paramet= ers. =20 @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the= packet. - @retval EFI_INVALID_PARAMETER The options are malformatted + @retval EFI_INVALID_PARAMETER The options are mal-formatted @retval EFI_SUCCESS The options are parsed into OptionPoint =20 **/ @@ -770,7 +770,7 @@ DhcpAppendOption ( function. =20 @retval EFI_OUT_OF_RESOURCES Failed to allocate memory - @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatte= d + @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatt= ed @retval EFI_SUCCESS The packet is build. =20 **/ @@ -794,7 +794,7 @@ DhcpBuild ( UINT8 *Buf; =20 // - // Use an array of DHCP_OPTION to mark the existance + // Use an array of DHCP_OPTION to mark the existence // and position of each valid options. // Mark =3D AllocatePool (sizeof (DHCP_OPTION) * DHCP_MAX_OPTIONS); --=20 2.21.0