From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web09.8777.1575392322701826767 for ; Tue, 03 Dec 2019 08:58:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=lw2p1LNJ; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id f129so4358987wmf.2 for ; Tue, 03 Dec 2019 08:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ilXuva8U6OHEMq/qWFm2od7fch17GwM+TGUexzRnbJM=; b=lw2p1LNJPGH7GM/wUgIbA+KSQFOZBZqpSYBhqpKuIE0dexQ/e+hpZ9JsQ/ndtAtcL8 dWbeyuIgNRJjWV15JHlt48JpJV6p3X6+lySFC29OezO3YXbPUqVU5rAl5j7DftdalB7z +ZEMtzEfg6w4wTirzYeS108VondBaDFuT2qD30Vqbi0YxfCrhxq9+OIuxE0HCUka+8pj YkXgjri04uD+aRzUJq5T+3UE4W+k63A3YhERGG81hx2MUHrqQ9Q5vuiD1tR1KGHMklc8 F3RCnLUlK1HC5Hq//czNgt9oQmzPvOHbec+U/Q3NwmgEp+JEmYl8gVOfUDezebjkdvh5 3tmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ilXuva8U6OHEMq/qWFm2od7fch17GwM+TGUexzRnbJM=; b=ISznezIp+RsK9V3LfV7dznuv6SD8URltuCLB14XWEaE9IIKz9kXJ9ceHeLvdIMi+RY /Nlv9zREghRFWnnVnF6EyC2ZtFHKbUPozF+gxFvhivtSfOam9AgCUOis7CLguGCZGKyx WZaMcHqrNrZjtg3zH86WBZSjAcqbOzl5hKrjPPhU1BbxyN+S5+te0Dcx+9RrcusyNZX7 UMpxjchkGUCyFlLs+8Ka2HAoAapnLEQrxKQPskD0YWOXY6RoiI89NHjevcF/fJYm5z1N TX08j2QZsXTPaYjmke1yjXrFrHV+TfQ86CmS9WuPh9w+U2DJgsN5b3oeqQWS+stDE1JK NRtg== X-Gm-Message-State: APjAAAUUPvtLMNNfPt+ZNygbx/zr47zPSuanKxBixf46/Mcidft4RWdi 8B5t0SKncEtjrFPfp2qeHJaasw== X-Google-Smtp-Source: APXvYqwWuzn0VqVRajARX4o8XKG+cW4WMJHnhbkhIljmHp0aXoCggO1NPuTB7KOiMNzx5uqwa+vbog== X-Received: by 2002:a7b:cc13:: with SMTP id f19mr36583917wmh.81.1575392321069; Tue, 03 Dec 2019 08:58:41 -0800 (PST) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n3sm3803529wmc.27.2019.12.03.08.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 08:58:40 -0800 (PST) Date: Tue, 3 Dec 2019 16:58:38 +0000 From: "Leif Lindholm" To: Philippe Mathieu-Daude Cc: devel@edk2.groups.io, Antoine Coeur , Ard Biesheuvel Subject: Re: [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo Message-ID: <20191203165838.GJ7359@bivouac.eciton.net> References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191203161602.15969-3-philmd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Phil, Antoine, This file is imported from an external project, and arguably we should be converting the libfdt import to a submodule instead. So I'd prefer not pulling this one in. / Leif On Tue, Dec 03, 2019 at 17:14:45 +0100, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix a typo in a comment. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > EmbeddedPkg/Include/libfdt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Include/libfdt.h b/EmbeddedPkg/Include/libfdt.h > index 141ecb579bde..606c80a0e8ca 100644 > --- a/EmbeddedPkg/Include/libfdt.h > +++ b/EmbeddedPkg/Include/libfdt.h > @@ -107,7 +107,7 @@ > * nodes, or subnodes preceding properties). */ > #define FDT_ERR_BADLAYOUT 12 > /* FDT_ERR_BADLAYOUT: For read-write functions, the given > - * device tree has it's sub-blocks in an order that the > + * device tree has its sub-blocks in an order that the > * function can't handle (memory reserve map, then structure, > * then strings). Use fdt_open_into() to reorganize the tree > * into a form suitable for the read-write operations. */ > -- > 2.21.0